diff for duplicates of <7559062.XA9lTlmQ7K@avalon> diff --git a/a/1.txt b/N1/1.txt index c39f63d..2ede4f4 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -30,9 +30,9 @@ On Thursday 03 September 2015 18:00:34 Javier Martinez Canillas wrote: > > /* Create links. */ > list_for_each_entry(entity, &vsp1->entities, list_dev) { -> - if (entity->type = VSP1_ENTITY_LIF || -> - entity->type = VSP1_ENTITY_RPF) -> + if (entity->type = VSP1_ENTITY_LIF) { +> - if (entity->type == VSP1_ENTITY_LIF || +> - entity->type == VSP1_ENTITY_RPF) +> + if (entity->type == VSP1_ENTITY_LIF) { > + ret = vsp1_wpf_create_pads_links(vsp1, entity); Could you please s/pads_links/links/ ? There's no other type of links handled @@ -50,7 +50,7 @@ instead of a continue. > + } > + -> + if (entity->type = VSP1_ENTITY_RPF) { +> + if (entity->type == VSP1_ENTITY_RPF) { > + ret = vsp1_rpf_create_pads_links(vsp1, entity); > + if (ret < 0) > + goto done; diff --git a/a/content_digest b/N1/content_digest index 2427208..2211316 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -2,7 +2,7 @@ "ref\01441296036-20727-4-git-send-email-javier@osg.samsung.com\0" "From\0Laurent Pinchart <laurent.pinchart@ideasonboard.com>\0" "Subject\0Re: [PATCH 3/5] [media] v4l: vsp1: separate links creation from entities init\0" - "Date\0Sun, 06 Dec 2015 02:51:04 +0000\0" + "Date\0Sun, 06 Dec 2015 04:51:04 +0200\0" "To\0Javier Martinez Canillas <javier@osg.samsung.com>\0" "Cc\0linux-kernel@vger.kernel.org" Hans Verkuil <hans.verkuil@cisco.com> @@ -43,9 +43,9 @@ "> \n" "> \t/* Create links. */\n" "> \tlist_for_each_entry(entity, &vsp1->entities, list_dev) {\n" - "> -\t\tif (entity->type = VSP1_ENTITY_LIF ||\n" - "> -\t\t entity->type = VSP1_ENTITY_RPF)\n" - "> +\t\tif (entity->type = VSP1_ENTITY_LIF) {\n" + "> -\t\tif (entity->type == VSP1_ENTITY_LIF ||\n" + "> -\t\t entity->type == VSP1_ENTITY_RPF)\n" + "> +\t\tif (entity->type == VSP1_ENTITY_LIF) {\n" "> +\t\t\tret = vsp1_wpf_create_pads_links(vsp1, entity);\n" "\n" "Could you please s/pads_links/links/ ? There's no other type of links handled \n" @@ -63,7 +63,7 @@ "\n" "> +\t\t}\n" "> +\n" - "> +\t\tif (entity->type = VSP1_ENTITY_RPF) {\n" + "> +\t\tif (entity->type == VSP1_ENTITY_RPF) {\n" "> +\t\t\tret = vsp1_rpf_create_pads_links(vsp1, entity);\n" "> +\t\t\tif (ret < 0)\n" "> +\t\t\t\tgoto done;\n" @@ -211,4 +211,4 @@ "\n" Laurent Pinchart -3b4ba4d387b1a4b8bf79a59e1cde63546038883ba4db087d916361adde7f8afa +6167a0e00d7d74bcfa26389b9d05a1f4fc4b08071e9d34f9a9b0cd1969614878
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.