All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: Ali Alnubani <alialnu@nvidia.com>
Cc: dev@dpdk.org
Subject: Re: [PATCH v2] devtools: check patch from stdin only if nothing else
Date: Sat, 29 Nov 2025 20:05:38 +0100	[thread overview]
Message-ID: <7561331.DvuYhMxLoT@thomas> (raw)
In-Reply-To: <20251128144127.1552516-1-thomas@monjalon.net>

28/11/2025 15:40, Thomas Monjalon:
> From: Ali Alnubani <alialnu@nvidia.com>
> 
> The checkpatches.sh script was checking if stdin is a terminal before
> honoring the -n flag, causing it to incorrectly attempt to read patches
> from stdin when run without a TTY (e.g., in Jenkins/CI pipelines).
> 
> Reorder the conditionals to check for the -n and -r flags
> before checking stdin state.
> This ensures the -n/-r flags takes precedence
> and the script checks git commits as intended.
> 
> Signed-off-by: Ali Alnubani <alialnu@nvidia.com>
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>

Applied




      reply	other threads:[~2025-11-29 19:05 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-14  7:43 [PATCH] devtools: honor -n flag regardless of stdin state Ali Alnubani
2025-10-23 14:33 ` Thomas Monjalon
2025-10-23 14:51   ` Thomas Monjalon
2025-11-28 14:40     ` [PATCH v2] devtools: check patch from stdin only if nothing else Thomas Monjalon
2025-11-29 19:05       ` Thomas Monjalon [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7561331.DvuYhMxLoT@thomas \
    --to=thomas@monjalon.net \
    --cc=alialnu@nvidia.com \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.