From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH] gitignore: ignore top level build/ directory
Date: Tue, 22 May 2018 23:45:31 +0200
Message-ID: <7564883.QMXTE167Kr@xps>
References: <2dfce93f986deb95eb5ac4773e020005d45f0c48.1481629710.git.baruch@tkos.co.il>
 <B27915DBBA3421428155699D51E4CFE2026891C2@IRSMSX103.ger.corp.intel.com>
 <20161219171434.GA188176@bricha3-MOBL3.ger.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: "Mcnamara, John" <john.mcnamara@intel.com>, "Yigit,
 Ferruh" <ferruh.yigit@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
To: Bruce Richardson <bruce.richardson@intel.com>,
 Baruch Siach <baruch@tkos.co.il>
Return-path: <dev-bounces@dpdk.org>
Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com
 [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 41D1A1D9E
 for <dev@dpdk.org>; Tue, 22 May 2018 23:45:33 +0200 (CEST)
In-Reply-To: <20161219171434.GA188176@bricha3-MOBL3.ger.corp.intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

19/12/2016 18:14, Bruce Richardson:
> On Mon, Dec 19, 2016 at 04:50:57PM +0000, Mcnamara, John wrote:
> > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Bruce Richardson
> > > On Mon, Dec 19, 2016 at 03:05:20PM +0100, Thomas Monjalon wrote:
> > > > 2016-12-13 12:02, Ferruh Yigit:
> > > > > On 12/13/2016 11:48 AM, Baruch Siach wrote:
> > > > > > RTE_OUTPUT defaults to build/.
> > > > > >
> > > > > > Signed-off-by: Baruch Siach <baruch@tkos.co.il>
> > > > >
> > > > > There is a similar patch:
> > > > > http://dpdk.org/dev/patchwork/patch/11637/
> > > > >
> > > > > If you want you can review/comment that one too.
> > > >
> > > > Yes, sorry I've never commented above patch.
> > > >
> > > > I do not like filling .gitignore because I prefer seeing what is built
> > > > or copied or whatever with "git status".
> > > > What is really the benefit of .gitignore?
> > > 
> > > I take the opposite view. I only like to see files that I actually care
> > > about in the git status. Any build artifacts should be ignored by git as
> > > they are not files that it ever should track. That way doing a build does
> > > not change the status of the repo as git sees it.
> > 
> > As a workaround I have the following in my .gitconfig:
> > 
> >     [core]
> >     excludesfile = ~/.gitignore
> > 
> > Then I put the ignore rules in ~/.gitignore.
> > 
> > John
> > 
> Yes, I have something similar done, so this is not a problem for me
> personally. I just find it strange that we don't make more use of
> gitignore in DPDK. The file's name itself seems to imply that it should
> be used to list out files that git should not track, and build output is
> definitely one of those.

I don't understand why we should hide the default build directory and not
the other ones with different names.
It would be perceived as inconsistent and confusing.