From: Alex Dubov <oakad@yahoo.com>
To: Andrew Morton <akpm@linux-foundation.org>,
Maxim Levitsky <maximlevitsky@gmail.com>
Cc: LKML <linux-kernel@vger.kernel.org>, Takashi Iwai <tiwai@suse.de>
Subject: Re: [PATCH 3/4] memstick: add support for legacy memorysticks
Date: Mon, 10 Jan 2011 18:48:43 -0800 (PST) [thread overview]
Message-ID: <757175.38063.qm@web37603.mail.mud.yahoo.com> (raw)
In-Reply-To: <1294710624-12379-4-git-send-email-maximlevitsky@gmail.com>
> +
> + case 2: /* send INT request */
> + if
> (msb_read_int_reg(msb, -1))
> +
> break;
> + msb->state++;
> +
> + case 3: /* get result of the INT
I still think it would look nicer if you could name your state with explicit
names and use "next_state()" or something to move on, instead of just
incrementing it.
Otherwise, I have no principal objections.
next prev parent reply other threads:[~2011-01-11 2:48 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-11 1:50 MEMSTICK: My 2 drivers for 2.6.38 inclusion Maxim Levitsky
2011-01-11 1:50 ` [PATCH 1/4] scatterlist: new helper functions Maxim Levitsky
2011-01-11 1:50 ` [PATCH 2/4] memstick: Add driver for Ricoh R5C592 card reader Maxim Levitsky
2011-01-11 2:50 ` Alex Dubov
2011-01-11 1:50 ` [PATCH 3/4] memstick: add support for legacy memorysticks Maxim Levitsky
2011-01-11 2:48 ` Alex Dubov [this message]
2011-01-11 1:50 ` [PATCH 4/4] memstick: add Alex Dubov to MAINTAINERS of the memstick core Maxim Levitsky
-- strict thread matches above, loose matches on Subject: below --
2011-01-11 23:36 [PATCH V2 0/4]: MEMSTICK: My 2 drivers for 2.6.38 inclusion Maxim Levitsky
2011-01-11 23:36 ` [PATCH 3/4] memstick: add support for legacy memorysticks Maxim Levitsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=757175.38063.qm@web37603.mail.mud.yahoo.com \
--to=oakad@yahoo.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maximlevitsky@gmail.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.