From: Thomas Monjalon <thomas@monjalon.net>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: dev@dpdk.org, Stephen Hemminger <sthemmin@microsoft.com>
Subject: Re: [PATCH] l3fwd: set cli back to unix style
Date: Mon, 15 Jan 2018 12:24:16 +0100 [thread overview]
Message-ID: <758014701.CxxNsLCgt3@xps> (raw)
In-Reply-To: <20171211231258.16494-1-sthemmin@microsoft.com>
12/12/2017 00:12, Stephen Hemminger:
> The l3fwd program became chatty, and the code looks cluttered in
> recent versions. DPDK programs should try for Unix (not VMS) style
> and not print messages for the options user selected. Also, errors should
> be printed on stderr. To make it easier to find code matching error
> messages; error strings should be placed in situ rather than saved
> as string vaiables.
>
> Fixes: 268888b5b020 ("examples/l3fwd: modularize")
> Signed-off-by: Stephen Hemminger <sthemmin@microsoft.com>
Applied, thanks
prev parent reply other threads:[~2018-01-15 11:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-11 23:12 [PATCH] l3fwd: set cli back to unix style Stephen Hemminger
2018-01-15 11:24 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=758014701.CxxNsLCgt3@xps \
--to=thomas@monjalon.net \
--cc=dev@dpdk.org \
--cc=stephen@networkplumber.org \
--cc=sthemmin@microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.