Re: Failing tests with WITH_BREAKING_CHANGES

[Phillip Wood <phillip.wood123@gmail.com>]

Hi brian

On 28/07/2026 01:46, brian m. carlson wrote:
> I have the following in `config.mak`:
> 
> ----
> DEVELOPER=1
> CC=clang
> GENERATE_COMPILATION_DATABASE=yes
> WITH_RUST=1
> USE_ASCIIDOCTOR=1
> WITH_BREAKING_CHANGES=1
> ----
> 
> In this configuration, I've noticed some tests failing:
> 
> ----
> t0014-alias.sh                                   (Wstat: 256 (exited 1) Tests: 23 Failed: 2)
>    Failed tests:  4, 8
>    Non-zero exit status: 1
> t1517-outside-repo.sh                            (Wstat: 256 (exited 1) Tests: 404 Failed: 2)
>    Failed tests:  248-249
>    Non-zero exit status: 1
> ----

I find t1517 fails quite often for me due to cruft from a previous build 
when a different branch was checked out. I wonder if there is a command 
that is no-longer built by WITH_BREAKING_CHANGES whose executable still 
exists in the build directory from a previous build. Its not clear to me 
why the alias tests might be failing though.

Thanks

Phillip

> These don't occur if I remove `WITH_BREAKING_CHANGES=1`, so they appear
> to be related to that option.  However, I know we have a CI job for that
> case, so it's unclear to me why these tests are failing; perhaps the CI
> job is not testing what we think it's testing.
> 
> I noticed this because I plan to send out a series soon based on that
> option and obviously I want to run the testsuite first.