Re: [PATCH] [SCSI] sd: make error handling more robust (v2)

[Luben Tuikov <ltuikov@yahoo.com>]

--- On Mon, 2/4/08, James Bottomley <James.Bottomley@HansenPartnership.com> wrote:
> On Mon, 2008-02-04 at 01:11 -0800, Luben Tuikov wrote:
> > Looks good except that "End LBA" is usually
> defined
> > to be something of the sort of "the LBA of the
> last
> > logical block accessed by the command" or
> "the LBA
> > of the logical block on which the command
> failed".
> > 
> > A spec savvy editor of this code would be
> > "pleasantly" surprised if they had to use
> "end_lba",
> > and didn't pay attention that it was actually
> > "End LBA" + 1.
> 
> Heh, well, that's where spec people and programmers
> part company.  The
> universal expectation of a programmer in looping is
> 
> for (a = beginning; a < end; a++)
> 
> rather than <= if end were actually to point to last
> rather than last +
> 1.

For loop invariants that's true, although I didn't see
a loop in sd_done().

   Luben