From mboxrd@z Thu Jan 1 00:00:00 1970 Received: by 2002:a19:e20e:0:0:0:0:0 with SMTP id z14csp3761409lfg; Tue, 4 May 2021 09:13:29 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzZMTdkx4qSR/WoqMeULCEzI6C88X6yP/at3e0KfZP+dtc/EMgkpTyYzSCaC0+lneFzl5Wg X-Received: by 2002:aa7:d14f:: with SMTP id r15mr26451067edo.71.1620144808658; Tue, 04 May 2021 09:13:28 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1620144808; cv=none; d=google.com; s=arc-20160816; b=xTuSf2owoKXKh8nJkBJmQ3coGcgdCJooE6SPEC1hIIJIwaBmxdhcjVYob9VbPjNQLc ObQZNPHLKvoi3LrWdaBaUrYkpRy3VuPlFyrixMD8eGncl+o43o6wBIVgQh1pHx8e54n5 n7ssPNfeJMJLT2WHeoj5z9kyMqR3wigCpeuHrkeht1Q+8N35smEp4ZbKSgiHxkuPp3ma Y5bOVpfu+457pah+OEueymOzQkwRwWubrdJao9GDr+2D9iKrz5bC+p2tTaXLek2hKWjk dFqUbc/MvmwRzkG2eKlBqG7sLT4eI9G1dUo8/Lsc6ly16ygeu7DyPK/e01jC4lURiyTy TcJQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:cc:to:subject :dkim-signature; bh=WDjH8HUsPkhGMMcrdHjqQzQOQEJ2YcdFedYMSf93gzs=; b=v8vnnhbsVbtGyBDVKuYVGIGzGZDW3guN6jiR1g0O1VE6tIExEeViG4j7sCFtXK1fL4 Lc94m1HD6oFWAtL9Z54dhXuXwWzfR3xVt+mwu5BWVzKln1QSF1QGYe97kwdEr7kcUTxp omRRJKpJ5Uyc8u94stPUc6GVTPhKvLAX2qPAI0v9qN++6WmOyWQ88gEZUAl1s4EDpatH HyKXSimQBvvXfEqllwzQOrRQGPNhftc8i6qHqT9C6e7PhtIyQ9pw1BIHpzUp+SY64fSS KqY4LjJRtFsNyQX+hkzwnIA0mMJcPwWue4cjH2dmv1lZ9i3yYMWRa5L+ZUShenrNk1Ok QKug== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=iyBFTTAX; spf=pass (google.com: domain of philmd@redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com. [216.205.24.124]) by mx.google.com with ESMTPS id c14si304525edr.409.2021.05.04.09.13.28 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 04 May 2021 09:13:28 -0700 (PDT) Received-SPF: pass (google.com: domain of philmd@redhat.com designates 216.205.24.124 as permitted sender) client-ip=216.205.24.124; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=iyBFTTAX; spf=pass (google.com: domain of philmd@redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1620144807; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=WDjH8HUsPkhGMMcrdHjqQzQOQEJ2YcdFedYMSf93gzs=; b=iyBFTTAXWFXVrvIYGw95/WVLKDa4Bhlkg+IzZNuEuffVpILg0FLT3RKNkaZwSSTogSlExI OfHQvfU1/QeuJSnfPqbGBj5szwmV6JwyAYyl27NkwtpvyHAhd4pnzmhPclXtQgycZJvlv5 S0AXonFggEilFnTxnAgcVq7IleG4UYI= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-105-wEuUV0wLPjOpFupG85bxUQ-1; Tue, 04 May 2021 12:13:26 -0400 X-MC-Unique: wEuUV0wLPjOpFupG85bxUQ-1 Received: by mail-wr1-f72.google.com with SMTP id 4-20020adf80040000b029010cab735fdeso5946015wrk.14 for ; Tue, 04 May 2021 09:13:25 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=WDjH8HUsPkhGMMcrdHjqQzQOQEJ2YcdFedYMSf93gzs=; b=LiJ98oCfqAlTvs5FSBHuRwHdrAUQkn5VvppNtTBdPV9i4SgQ2gc3bHjtIeRJYmPlC/ Leju5si/jDb7QNI5UxPrseSEmytp4F4TEX3gAhYkt61k9F4XrIZs8/wRxS9NlicHeNsU jsLCpGxT+Y5AMnI//ypJMkXnIhLf7Y3QV8KHmYygZbshvWkG/BVPmfLENR9G3sr0tkhc 7CezOt6M9OXBW6dc2e30cdqIXnfrbCdmETbjN+4NkVECt5x/5ohOLL3HVLhPOSim1aCl dWTbaFZN8M9CrOxkznWyereXdjFWx2oTop2RiAQ93qGLmFXa93htYnDtWnA5/0z1sB83 8P6w== X-Gm-Message-State: AOAM532eQ9Kpc6bAVz5FZvkA1ZYvh3BRBuCbiOTWat11FzqLIDA3OvpQ /yVFk9ktbUOSfbQ+VxIIMyQM+AGInHOWaawvvFnv4TzCMjBs75lgcVG9mFizisZcgISZbf9cPd4 7F4wnvUs/rDN9xoNgMm32xd8zy8LKeqBx/lP+RxT0ewYT7SmmscsAV4uZfMS//uJUug== X-Received: by 2002:a1c:6646:: with SMTP id a67mr4837517wmc.11.1620144804502; Tue, 04 May 2021 09:13:24 -0700 (PDT) X-Received: by 2002:a1c:6646:: with SMTP id a67mr4837479wmc.11.1620144804127; Tue, 04 May 2021 09:13:24 -0700 (PDT) Return-Path: Received: from [192.168.1.19] (astrasbourg-653-1-188-220.w90-13.abo.wanadoo.fr. [90.13.127.220]) by smtp.gmail.com with ESMTPSA id s1sm3081836wmj.8.2021.05.04.09.13.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 04 May 2021 09:13:23 -0700 (PDT) Subject: Re: [PATCH v6 11/12] qtest/bios-tables-test: Make test build-independent from accelerator To: Eric Blake , qemu-devel@nongnu.org Cc: "Michael S. Tsirkin" , Thomas Huth , Markus Armbruster , Paolo Bonzini , qemu-arm@nongnu.org, Igor Mammedov , =?UTF-8?Q?Alex_Benn=c3=a9e?= References: <20210503211020.894589-1-philmd@redhat.com> <20210503211020.894589-12-philmd@redhat.com> <8e675e24-fedc-c4df-22d6-b385142e0e4b@redhat.com> From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= Message-ID: <759a1dfd-371a-7e08-e0cc-15114d5b2b3a@redhat.com> Date: Tue, 4 May 2021 18:13:22 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <8e675e24-fedc-c4df-22d6-b385142e0e4b@redhat.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-TUID: QSvuRUQQTvMS On 5/3/21 11:19 PM, Eric Blake wrote: > On 5/3/21 4:10 PM, Philippe Mathieu-Daudé wrote: >> Now than we can probe if the TCG accelerator is available > > that Oops. I'll wait for Igor review before respinning. > >> at runtime with a QMP command, do it once at the beginning >> and only register the tests we can run. >> We can then replace the #ifdef'ry by an assertion. >> >> Signed-off-by: Philippe Mathieu-Daudé >> --- >> v5 had: >> Reviewed-by: Eric Blake >> Reviewed-by: Alex Bennée >> >> v6 is simplified and keeps the same logic, however since >> it is different, I'm not keeping the R-b tags. >> --- >> tests/qtest/bios-tables-test.c | 14 ++++++-------- >> 1 file changed, 6 insertions(+), 8 deletions(-) >> > > Reviewed-by: Eric Blake Thanks! Phil. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7DFE2C433B4 for ; Tue, 4 May 2021 16:17:41 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 14072611AD for ; Tue, 4 May 2021 16:17:41 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 14072611AD Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:55304 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ldxjw-0007tO-4Y for qemu-devel@archiver.kernel.org; Tue, 04 May 2021 12:17:40 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:56744) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ldxfz-0004aR-M8 for qemu-devel@nongnu.org; Tue, 04 May 2021 12:13:40 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:24034) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ldxft-0005EM-HX for qemu-devel@nongnu.org; Tue, 04 May 2021 12:13:34 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1620144807; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=WDjH8HUsPkhGMMcrdHjqQzQOQEJ2YcdFedYMSf93gzs=; b=iyBFTTAXWFXVrvIYGw95/WVLKDa4Bhlkg+IzZNuEuffVpILg0FLT3RKNkaZwSSTogSlExI OfHQvfU1/QeuJSnfPqbGBj5szwmV6JwyAYyl27NkwtpvyHAhd4pnzmhPclXtQgycZJvlv5 S0AXonFggEilFnTxnAgcVq7IleG4UYI= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-542--X7hADwTPoGVRVMrwBpVKQ-1; Tue, 04 May 2021 12:13:25 -0400 X-MC-Unique: -X7hADwTPoGVRVMrwBpVKQ-1 Received: by mail-wr1-f72.google.com with SMTP id x10-20020adfc18a0000b029010d83c83f2aso5952510wre.8 for ; Tue, 04 May 2021 09:13:25 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=WDjH8HUsPkhGMMcrdHjqQzQOQEJ2YcdFedYMSf93gzs=; b=FfKP36neo6yHZ5WRuDJwx8QsVAnAN1BBVLtwYON7Tb+RTQpG61NwSy5OfBh7ssh7Wy U7frXwfUz2VeFR0jr2ifgKqRQ18miZhSpWBN7oHjeQeIAABQdC/uftVyQy/nTFWgxg+u HxJxBFCyuOzjKwObSvyooZej/x6m/22xU+L6qGBOj9YzZHkeHJal4EE1yW8OANB06i33 jWPhxpga8tU7m/XAtDisqf4ahumDJMXGSg3PrZ9kraJXA697okfV0gkxKo9JzwBH7ORi 21blKmACz/RlGb+PFzxByqqtVvLv9cMT/D4mCAb0aBA6FxLmTtfl5IMTGhUA4v2REift 7iMw== X-Gm-Message-State: AOAM531jLO9OPE16twWRLEwjeY7g2J5PkJSCRwcSKxRwT3i3Kam9edx4 vWKJ1Ggm/VSzDg0Q3lKyJD8gDdLzHFUhlbAmgo5RHgjVQRIOaKJ3UhPi8Neo6fPUWdAht7DiIJb 3Fz7DGjJYYFdnWXw= X-Received: by 2002:a1c:6646:: with SMTP id a67mr4837503wmc.11.1620144804415; Tue, 04 May 2021 09:13:24 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzf5u8/7hb0tx50JECxyRwkz/p47GlzYsM74hvf5qBFysNjp1Q93reUZvSc16yiMCouZb39UQ== X-Received: by 2002:a1c:6646:: with SMTP id a67mr4837479wmc.11.1620144804127; Tue, 04 May 2021 09:13:24 -0700 (PDT) Received: from [192.168.1.19] (astrasbourg-653-1-188-220.w90-13.abo.wanadoo.fr. [90.13.127.220]) by smtp.gmail.com with ESMTPSA id s1sm3081836wmj.8.2021.05.04.09.13.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 04 May 2021 09:13:23 -0700 (PDT) Subject: Re: [PATCH v6 11/12] qtest/bios-tables-test: Make test build-independent from accelerator To: Eric Blake , qemu-devel@nongnu.org References: <20210503211020.894589-1-philmd@redhat.com> <20210503211020.894589-12-philmd@redhat.com> <8e675e24-fedc-c4df-22d6-b385142e0e4b@redhat.com> From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= Message-ID: <759a1dfd-371a-7e08-e0cc-15114d5b2b3a@redhat.com> Date: Tue, 4 May 2021 18:13:22 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <8e675e24-fedc-c4df-22d6-b385142e0e4b@redhat.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=170.10.133.124; envelope-from=philmd@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -34 X-Spam_score: -3.5 X-Spam_bar: --- X-Spam_report: (-3.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.697, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Thomas Huth , "Michael S. Tsirkin" , Markus Armbruster , qemu-arm@nongnu.org, Igor Mammedov , Paolo Bonzini , =?UTF-8?Q?Alex_Benn=c3=a9e?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 5/3/21 11:19 PM, Eric Blake wrote: > On 5/3/21 4:10 PM, Philippe Mathieu-Daudé wrote: >> Now than we can probe if the TCG accelerator is available > > that Oops. I'll wait for Igor review before respinning. > >> at runtime with a QMP command, do it once at the beginning >> and only register the tests we can run. >> We can then replace the #ifdef'ry by an assertion. >> >> Signed-off-by: Philippe Mathieu-Daudé >> --- >> v5 had: >> Reviewed-by: Eric Blake >> Reviewed-by: Alex Bennée >> >> v6 is simplified and keeps the same logic, however since >> it is different, I'm not keeping the R-b tags. >> --- >> tests/qtest/bios-tables-test.c | 14 ++++++-------- >> 1 file changed, 6 insertions(+), 8 deletions(-) >> > > Reviewed-by: Eric Blake Thanks! Phil.