All of lore.kernel.org
 help / color / mirror / Atom feed
From: Quentin Schulz <quentin.schulz@cherry.de>
To: Heiko Schocher <hs@nabladev.com>,
	U-Boot Mailing List <u-boot@lists.denx.de>
Cc: Ilias Apalodimas <ilias.apalodimas@linaro.org>,
	Alif Zakuan Yuslaimi <alif.zakuan.yuslaimi@altera.com>,
	Anshul Dalal <anshuld@ti.com>,
	Arturs Artamonovs <arturs.artamonovs@analog.com>,
	Casey Connolly <casey.connolly@linaro.org>,
	Dinesh Maniyam <dinesh.maniyam@altera.com>,
	Greg Malysa <malysagreg@gmail.com>,
	Heinrich Schuchardt <xypron.glpk@gmx.de>,
	Ibai Erkiaga <ibai.erkiaga-elorza@amd.com>,
	Jaehoon Chung <jh80.chung@samsung.com>,
	Jerome Forissier <jerome.forissier@linaro.org>,
	"Kory Maincent (TI.com)" <kory.maincent@bootlin.com>,
	Marek Vasut <marek.vasut@mailbox.org>,
	Martin Schwan <m.schwan@phytec.de>,
	Mattijs Korpershoek <mkorpershoek@kernel.org>,
	Michael Trimarchi <michael@amarulasolutions.com>,
	Michal Simek <michal.simek@amd.com>,
	Mikhail Kshevetskiy <mikhail.kshevetskiy@iopsys.eu>,
	Nathan Barrett-Morrison <nathan.morrison@timesys.com>,
	Oliver Gaskell <Oliver.Gaskell@analog.com>,
	Paul Barker <paul.barker.ct@bp.renesas.com>,
	Peng Fan <peng.fan@nxp.com>,
	Peter Robinson <pbrobinson@gmail.com>,
	Simon Glass <sjg@chromium.org>,
	Stefan Roese <stefan.roese@mailbox.org>,
	Sumit Garg <sumit.garg@kernel.org>, Tom Rini <trini@konsulko.com>,
	Utsav Agarwal <utsav.agarwal@analog.com>,
	Vasileios Bimpikas <vasileios.bimpikas@analog.com>,
	Venkatesh Yadav Abbarapu <venkatesh.abbarapu@amd.com>,
	briansune <briansune@gmail.com>
Subject: Re: [PATCH v3 3/6] lib: sm3: implement U-Boot parts
Date: Tue, 18 Nov 2025 11:30:18 +0100	[thread overview]
Message-ID: <75a1e7a9-3a66-49ca-92d4-75dbecd7ff4a@cherry.de> (raw)
In-Reply-To: <20251118043042.27726-4-hs@nabladev.com>

Hi Heiko,

On 11/18/25 5:30 AM, Heiko Schocher wrote:
> add the U-Boot specific parts for the SM3 hash
> implementation:
> 
> Signed-off-by: Heiko Schocher <hs@nabladev.com>
> ---
> 
> Changes in v3:
> New in version 3 as Ilias recommended to split linux
> and U-boot changes.
> 
>   MAINTAINERS          |   1 +
>   boot/Kconfig         |   1 +
>   cmd/Kconfig          |  15 ++++++
>   cmd/Makefile         |   1 +
>   cmd/sm3sum.c         |  48 +++++++++++++++++

Please add some doc for the new command in doc/usage/cmd/.

[...]

> diff --git a/cmd/Kconfig b/cmd/Kconfig
> index 5b9c13d85e7..8e3efff2bee 100644
> --- a/cmd/Kconfig
> +++ b/cmd/Kconfig
> @@ -264,6 +264,21 @@ config CMD_SBI
>   	help
>   	  Display information about the SBI implementation.
>   
> +config CMD_SM3SUM
> +	bool "sm3sum"
> +	select SM3
> +	select HASH
> +	help
> +	  Compute SM3 checksum.
> +	  add SM3 hash functionality
> +

Spurious second line?

Cheers,
Quentin

  reply	other threads:[~2025-11-18 13:17 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-18  4:30 [PATCH v3 0/6] Add support for SM3 secure hash Heiko Schocher
2025-11-18  4:30 ` [PATCH v3 1/6] lib: Import rol32 function from Linux Heiko Schocher
2025-11-18  4:30 ` [PATCH v3 2/6] lib: import sm3 256 hash parts from linux Heiko Schocher
2025-11-19 11:02   ` Ilias Apalodimas
2025-11-18  4:30 ` [PATCH v3 3/6] lib: sm3: implement U-Boot parts Heiko Schocher
2025-11-18 10:30   ` Quentin Schulz [this message]
2025-11-19  7:13     ` Heiko Schocher
2025-11-18  4:30 ` [PATCH v3 4/6] test: cmd: hash: add unit test for sm3_256 Heiko Schocher
2025-11-18  4:30 ` [PATCH v3 5/6] tpm2: add sm3 256 hash support Heiko Schocher
2025-11-18  4:30 ` [PATCH v3 6/6] test: cmd: fix a typo in md5 test Heiko Schocher
2025-11-18 10:06 ` [PATCH v3 0/6] Add support for SM3 secure hash Ilias Apalodimas
2025-11-18 15:11 ` Raymond Mao
2025-11-19  5:40   ` Heiko Schocher
2025-11-19  7:18     ` Ilias Apalodimas
2025-12-04 19:31 ` Tom Rini
2025-12-05  5:03   ` Heiko Schocher
2025-12-05  7:24     ` Ilias Apalodimas
2025-12-05  8:02       ` Heiko Schocher
2025-12-05 14:11         ` Tom Rini
2025-12-08  9:07           ` Ilias Apalodimas
2025-12-08  9:26             ` Heiko Schocher

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=75a1e7a9-3a66-49ca-92d4-75dbecd7ff4a@cherry.de \
    --to=quentin.schulz@cherry.de \
    --cc=Oliver.Gaskell@analog.com \
    --cc=alif.zakuan.yuslaimi@altera.com \
    --cc=anshuld@ti.com \
    --cc=arturs.artamonovs@analog.com \
    --cc=briansune@gmail.com \
    --cc=casey.connolly@linaro.org \
    --cc=dinesh.maniyam@altera.com \
    --cc=hs@nabladev.com \
    --cc=ibai.erkiaga-elorza@amd.com \
    --cc=ilias.apalodimas@linaro.org \
    --cc=jerome.forissier@linaro.org \
    --cc=jh80.chung@samsung.com \
    --cc=kory.maincent@bootlin.com \
    --cc=m.schwan@phytec.de \
    --cc=malysagreg@gmail.com \
    --cc=marek.vasut@mailbox.org \
    --cc=michael@amarulasolutions.com \
    --cc=michal.simek@amd.com \
    --cc=mikhail.kshevetskiy@iopsys.eu \
    --cc=mkorpershoek@kernel.org \
    --cc=nathan.morrison@timesys.com \
    --cc=paul.barker.ct@bp.renesas.com \
    --cc=pbrobinson@gmail.com \
    --cc=peng.fan@nxp.com \
    --cc=sjg@chromium.org \
    --cc=stefan.roese@mailbox.org \
    --cc=sumit.garg@kernel.org \
    --cc=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    --cc=utsav.agarwal@analog.com \
    --cc=vasileios.bimpikas@analog.com \
    --cc=venkatesh.abbarapu@amd.com \
    --cc=xypron.glpk@gmx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.