From mboxrd@z Thu Jan 1 00:00:00 1970 From: Archit Taneja Subject: Re: [PATCH 0/4] drm/bridge/adv7511: add CEC support Date: Thu, 10 Aug 2017 14:38:59 +0530 Message-ID: <75a39db0-a5cc-9a20-2bbf-ebfc3573efca@codeaurora.org> References: <20170730130743.19681-1-hverkuil@xs4all.nl> <9d1757b3-24f9-2f0f-1971-62d1ef4b79e3@codeaurora.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Hans Verkuil Cc: devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-renesas-soc@vger.kernel.org, linux-media@vger.kernel.org List-Id: linux-arm-msm@vger.kernel.org CgpPbiAwOC8xMC8yMDE3IDAyOjI2IFBNLCBIYW5zIFZlcmt1aWwgd3JvdGU6Cj4gT24gMTAvMDgv MTcgMTA6NDksIEFyY2hpdCBUYW5lamEgd3JvdGU6Cj4+IEhpIEhhbnMsCj4+Cj4+IE9uIDA3LzMw LzIwMTcgMDY6MzcgUE0sIEhhbnMgVmVya3VpbCB3cm90ZToKPj4+IEZyb206IEhhbnMgVmVya3Vp bCA8aGFucy52ZXJrdWlsQGNpc2NvLmNvbT4KPj4+Cj4+PiBUaGlzIHBhdGNoIHNlcmllcyBhZGRz IENFQyBzdXBwb3J0IHRvIHRoZSBkcm0gYWR2NzUxMS9hZHY3NTMzIGRyaXZlcnMuCj4+Pgo+Pj4g SSBoYXZlIHRlc3RlZCB0aGlzIHdpdGggdGhlIFF1YWxjb21tIERyYWdvbmJvYXJkIEM0MTAgKGFk djc1MzMgYmFzZWQpCj4+PiBhbmQgdGhlIFJlbmVzYXMgUi1DYXIgS29lbHNjaCBib2FyZCAoYWR2 NzUxMSBiYXNlZCkuCj4+Pgo+Pj4gTm90ZTogdGhlIERyYWdvbmJvYXJkIG5lZWRzIHRoaXMgcGF0 Y2g6Cj4+Pgo+Pj4gaHR0cHM6Ly9wYXRjaHdvcmsua2VybmVsLm9yZy9wYXRjaC85ODI0NzczLwo+ Pj4KPj4+IEFyY2hpdCwgY2FuIHlvdSBjb25maXJtIHRoYXQgdGhpcyBwYXRjaCB3aWxsIGdvIHRv IGtlcm5lbCA0LjE0Pwo+Pj4KPj4+IEFuZCB0aGUgS29lbHNjaCBib2FyZCBuZWVkcyB0aGlzIDQu MTMgZml4Ogo+Pj4KPj4+IGh0dHBzOi8vcGF0Y2h3b3JrLmtlcm5lbC5vcmcvcGF0Y2gvOTgzNjg2 NS8KPj4+Cj4+PiBJIG9ubHkgaGF2ZSB0aGUgS29lbHNjaCBib2FyZCB0byB0ZXN0IHdpdGgsIGJ1 dCBpdCBsb29rcyBsaWtlIG90aGVyCj4+PiBSLUNhciBib2FyZHMgdXNlIHRoZSBzYW1lIGFkdjc1 MTEuIEl0IHdvdWxkIGJlIG5pY2UgaWYgc29tZW9uZSBjYW4KPj4+IGFkZCBDRUMgc3VwcG9ydCB0 byB0aGUgb3RoZXIgUi1DYXIgYm9hcmRzIGFzIHdlbGwuIFRoZSBtYWluIHRoaW5nCj4+PiB0byBj aGVjayBpcyBpZiB0aGV5IGFsbCB1c2UgdGhlIHNhbWUgMTIgTUh6IGZpeGVkIENFQyBjbG9jayBz b3VyY2UuCj4+Pgo+Pj4gQW55b25lIHdobyB3YW50cyB0byB0ZXN0IHRoaXMgd2lsbCBuZWVkIHRo ZSBDRUMgdXRpbGl0aWVzIHRoYXQKPj4+IGFyZSBwYXJ0IG9mIHRoZSB2NGwtdXRpbHMgZ2l0IHJl cG9zaXRvcnk6Cj4+Pgo+Pj4gZ2l0IGNsb25lIGdpdDovL2xpbnV4dHYub3JnL3Y0bC11dGlscy5n aXQKPj4+IGNkIHY0bC11dGlscwo+Pj4gLi9ib290c3RyYXAuc2gKPj4+IC4vY29uZmlndXJlCj4+ PiBtYWtlCj4+PiBzdWRvIG1ha2UgaW5zdGFsbAo+Pj4KPj4+IE5vdyBjb25maWd1cmUgdGhlIENF QyBhZGFwdGVyIGFzIGEgUGxheWJhY2sgZGV2aWNlOgo+Pj4KPj4+IGNlYy1jdGwgLS1wbGF5YmFj awo+Pj4KPj4+IERpc2NvdmVyIG90aGVyIENFQyBkZXZpY2VzOgo+Pj4KPj4+IGNlYy1jdGwgLVMK Pj4KPj4gSSB0cmllZCB0aGUgaW5zdHJ1Y3Rpb25zLCBhbmQgSSBnZXQgdGhlIGZvbGxvd2luZyBv dXRwdXQuIEkgZG9uJ3QgdGhpbmsgSSBoYXZlCj4+IGFueSBDRUMgZGV2aWNlIGNvbm5lY3RlZCwg dGhvdWdoLiBJcyB0aGlzIHRoZSBleHBlY3RlZCBiZWhhdmlvdXI/Cj4+Cj4+ICNjZWMtY3RsIC1T Cj4+IERyaXZlciBJbmZvOgo+PiAgICAgICAgICBEcml2ZXIgTmFtZSAgICAgICAgICAgICAgICA6 IGFkdjc1MTEKPj4gICAgICAgICAgQWRhcHRlciBOYW1lICAgICAgICAgICAgICAgOiAzLTAwMzkK Pj4gICAgICAgICAgQ2FwYWJpbGl0aWVzICAgICAgICAgICAgICAgOiAweDAwMDAwMDBlCj4+ICAg ICAgICAgICAgICAgICAgTG9naWNhbCBBZGRyZXNzZXMKPj4gICAgICAgICAgICAgICAgICBUcmFu c21pdAo+PiAgICAgICAgICAgICAgICAgIFBhc3N0aHJvdWdoCj4+ICAgICAgICAgIERyaXZlciB2 ZXJzaW9uICAgICAgICAgICAgIDogNC4xMy4wCj4+ICAgICAgICAgIEF2YWlsYWJsZSBMb2dpY2Fs IEFkZHJlc3NlczogMwo+PiAgICAgICAgICBQaHlzaWNhbCBBZGRyZXNzICAgICAgICAgICA6IDEu MC4wLjAKPj4gICAgICAgICAgTG9naWNhbCBBZGRyZXNzIE1hc2sgICAgICAgOiAweDAwMDAKPj4g ICAgICAgICAgQ0VDIFZlcnNpb24gICAgICAgICAgICAgICAgOiAyLjAKPj4gICAgICAgICAgTG9n aWNhbCBBZGRyZXNzZXMgICAgICAgICAgOiAwCj4+Cj4+ICNjZWMtY3RsIC0tcGxheWJhY2sKPj4g WyAxMDM4Ljc2MTU0NV0gY2VjLTMtMDAzOTogY2VjX3RocmVhZF9mdW5jOiBtZXNzYWdlIDQ0IHRp bWVkIG91dCEKPiAKPiBUaGlzIGlzbid0IHJpZ2h0LiBZb3Ugc2hvdWxkbid0IHNlZSB0aGlzLiBJ dCBuZXZlciByZWNlaXZlcyBhbiBpbnRlcnJ1cHQKPiB3aGVuIHRoZSB0cmFuc21pdCBoYXMgZmlu aXNoZWQsIHdoaWNoIGNhdXNlcyB0aGVzZSB0aW1lIG91dHMuCj4gCj4gV2hhdCBhcmUgeW91IHRl c3RpbmcgdGhpcyBvbj8gVGhlIERyYWdvbmJvYXJkIGM0MTA/CgpZZXMuCgo+IAo+IENhbiB5b3Ug Y2hlY2sgdGhlIGNlYyBjbG9jayBmcmVxdWVuY3k/IEl0IHNob3VsZCBiZSAxOS4yIE1Iei4KPiBS ZW1lbWJlciB0byBhcHBseSB0aGlzIHBhdGNoOiBodHRwczovL3BhdGNod29yay5rZXJuZWwub3Jn L3BhdGNoLzk4MjQ3NzMvCj4gWW91IHByb2JhYmx5IGRpZCwgYnV0IGp1c3QgaW4gY2FzZS4uLgoK Y2xrX3N1bW1hcnkgZG9lcyBzaG93IGJiX2NsazIgdG8gYmUgc2V0IHRvIDE5LjIgTWh6LgoKSSBh cHBsaWVkIGEgbmV3ZXIgdmVyc2lvbiBvZiB0aGlzIHBhdGNoLCB3aGljaCBnb3QgbWVyZ2VkIGlu IGNsay1uZXh0OgoKaHR0cHM6Ly9wYXRjaHdvcmsua2VybmVsLm9yZy9wYXRjaC85ODQ1NDkzLwoK SSB3aWxsIHRyeSB0byBhcHBseSB0aGUgcGF0Y2ggeW91IHVzZSBhbmQgY2hlY2sgYWdhaW4uCgpU aGFua3MsCkFyY2hpdAoKPiAKPiBSZWdhcmRzLAo+IAo+IAlIYW5zCj4gCj4+IERyaXZlciBJbmZv Ogo+PiAgICAgICAgICBEcml2ZXIgTmFtZSAgICAgICAgICAgICAgICA6IGFkdjc1MTEKPj4gICAg ICAgICAgQWRhcHRlciBOYW1lICAgICAgICAgICAgICAgOiAzLTAwMzkKPj4gICAgICAgICAgQ2Fw YWJpbGl0aWVzICAgICAgICAgICAgICAgOiAweDAwMDAwMDBlCj4+ICAgICAgICAgICAgICAgICAg TG9naWNhbCBBZGRyZXNzZXMKPj4gICAgICAgICAgICAgICAgICBUcmFuc21pdAo+PiAgICAgICAg ICAgICAgICAgIFBhc3N0aHJvdWdoCj4+ICAgICAgICAgIERyaXZlciB2ZXJzaW9uICAgICAgICAg ICAgIDogNC4xMy4wCj4+ICAgICAgICAgIEF2YWlsYWJsZSBMb2dpY2FsIEFkZHJlc3NlczogMwo+ PiAgICAgICAgICBQaHlzaWNhbCBBZGRyZXNzICAgICAgICAgICA6IDEuMC4wLjAKPj4gICAgICAg ICAgTG9naWNhbCBBZGRyZXNzIE1hc2sgICAgICAgOiAweDAwMTAKPj4gICAgICAgICAgQ0VDIFZl cnNpb24gICAgICAgICAgICAgICAgOiAyLjAKPj4gICAgICAgICAgVmVuZG9yIElEICAgICAgICAg ICAgICAgICAgOiAweDAwMGMwMwo+PiAgICAgICAgICBMb2dpY2FsIEFkZHJlc3NlcyAgICAgICAg ICA6IDEgKEFsbG93IFJDIFBhc3N0aHJvdWdoKQo+Pgo+PiAgICAgICAgICAgIExvZ2ljYWwgQWRk cmVzcyAgICAgICAgICA6IDQKPj4gICAgICAgICAgICAgIFByaW1hcnkgRGV2aWNlIFR5cGUgICAg OiBQbGF5YmFjawo+PiAgICAgICAgICAgICAgTG9naWNhbCBBZGRyZXNzIFR5cGUgICA6IFBsYXli YWNrCj4+ICAgICAgICAgICAgICBBbGwgRGV2aWNlIFR5cGVzICAgICAgIDogUGxheWJhY2sKPj4g ICAgICAgICAgICAgIFJDIFRWIFByb2ZpbGUgICAgICAgICAgOiBOb25lCj4+ICAgICAgICAgICAg ICBEZXZpY2UgRmVhdHVyZXMgICAgICAgIDoKPj4gICAgICAgICAgICAgICAgICBOb25lCj4+Cj4+ Cj4+IFsgMTA0MS4wNjM2MDVdIGNlYy0zLTAwMzk6IGNlY190aHJlYWRfZnVuYzogbWVzc2FnZSA0 ZiBhNiAwNiAxMCAwMCAwMCB0aW1lZCBvdXQhCj4+IFsgMTA0My4zNjc0ODJdIGNlYy0zLTAwMzk6 IGNlY190aHJlYWRfZnVuYzogbWVzc2FnZSA0ZiA4NCAxMCAwMCAwNCB0aW1lZCBvdXQhCj4+Cj4+ IFRoYW5rcywKPj4gQXJjaGl0Cj4+Cj4+Pgo+Pj4gUmVnYXJkcywKPj4+Cj4+PiAgICAgIEhhbnMK Pj4+Cj4+PiBIYW5zIFZlcmt1aWwgKDQpOgo+Pj4gICAgIGR0LWJpbmRpbmdzOiBhZGksYWR2NzUx MS50eHQ6IGRvY3VtZW50IGNlYyBjbG9jawo+Pj4gICAgIGFybTogZHRzOiBxY29tOiBhZGQgY2Vj IGNsb2NrIGZvciBhcHE4MDE2IGJvYXJkCj4+PiAgICAgYXJtOiBkdHM6IHJlbmVzYXM6IGFkZCBj ZWMgY2xvY2sgZm9yIEtvZWxzY2ggYm9hcmQKPj4+ICAgICBkcm06IGFkdjc1MTEvMzM6IGFkZCBI RE1JIENFQyBzdXBwb3J0Cj4+Pgo+Pj4gICAgLi4uL2JpbmRpbmdzL2Rpc3BsYXkvYnJpZGdlL2Fk aSxhZHY3NTExLnR4dCAgICAgICAgfCAgIDQgKwo+Pj4gICAgYXJjaC9hcm0vYm9vdC9kdHMvcjhh Nzc5MS1rb2Vsc2NoLmR0cyAgICAgICAgICAgICAgfCAgIDggKwo+Pj4gICAgYXJjaC9hcm02NC9i b290L2R0cy9xY29tL2FwcTgwMTYtc2JjLmR0c2kgICAgICAgICAgfCAgIDIgKwo+Pj4gICAgZHJp dmVycy9ncHUvZHJtL2JyaWRnZS9hZHY3NTExL0tjb25maWcgICAgICAgICAgICAgfCAgIDggKwo+ Pj4gICAgZHJpdmVycy9ncHUvZHJtL2JyaWRnZS9hZHY3NTExL01ha2VmaWxlICAgICAgICAgICAg fCAgIDEgKwo+Pj4gICAgZHJpdmVycy9ncHUvZHJtL2JyaWRnZS9hZHY3NTExL2Fkdjc1MTEuaCAg ICAgICAgICAgfCAgNDUgKystCj4+PiAgICBkcml2ZXJzL2dwdS9kcm0vYnJpZGdlL2Fkdjc1MTEv YWR2NzUxMV9jZWMuYyAgICAgICB8IDMxNCArKysrKysrKysrKysrKysrKysrKysKPj4+ICAgIGRy aXZlcnMvZ3B1L2RybS9icmlkZ2UvYWR2NzUxMS9hZHY3NTExX2Rydi5jICAgICAgIHwgMTUyICsr KysrKysrKy0KPj4+ICAgIGRyaXZlcnMvZ3B1L2RybS9icmlkZ2UvYWR2NzUxMS9hZHY3NTMzLmMg ICAgICAgICAgIHwgIDMwICstCj4+PiAgICA5IGZpbGVzIGNoYW5nZWQsIDUxNCBpbnNlcnRpb25z KCspLCA1MCBkZWxldGlvbnMoLSkKPj4+ICAgIGNyZWF0ZSBtb2RlIDEwMDY0NCBkcml2ZXJzL2dw dS9kcm0vYnJpZGdlL2Fkdjc1MTEvYWR2NzUxMV9jZWMuYwo+Pj4KPj4KPiAKPiAtLQo+IFRvIHVu c3Vic2NyaWJlIGZyb20gdGhpcyBsaXN0OiBzZW5kIHRoZSBsaW5lICJ1bnN1YnNjcmliZSBsaW51 eC1hcm0tbXNtIiBpbgo+IHRoZSBib2R5IG9mIGEgbWVzc2FnZSB0byBtYWpvcmRvbW9Admdlci5r ZXJuZWwub3JnCj4gTW9yZSBtYWpvcmRvbW8gaW5mbyBhdCAgaHR0cDovL3ZnZXIua2VybmVsLm9y Zy9tYWpvcmRvbW8taW5mby5odG1sCj4gCgotLSAKUXVhbGNvbW0gSW5ub3ZhdGlvbiBDZW50ZXIs IEluYy4gaXMgYSBtZW1iZXIgb2YgQ29kZSBBdXJvcmEgRm9ydW0sCmEgTGludXggRm91bmRhdGlv biBDb2xsYWJvcmF0aXZlIFByb2plY3QKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJl ZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGlu Zm8vZHJpLWRldmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Subject: Re: [PATCH 0/4] drm/bridge/adv7511: add CEC support To: Hans Verkuil Cc: linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, linux-renesas-soc@vger.kernel.org, devicetree@vger.kernel.org, Lars-Peter Clausen References: <20170730130743.19681-1-hverkuil@xs4all.nl> <9d1757b3-24f9-2f0f-1971-62d1ef4b79e3@codeaurora.org> From: Archit Taneja Message-ID: <75a39db0-a5cc-9a20-2bbf-ebfc3573efca@codeaurora.org> Date: Thu, 10 Aug 2017 14:38:59 +0530 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: devicetree-owner@vger.kernel.org List-ID: On 08/10/2017 02:26 PM, Hans Verkuil wrote: > On 10/08/17 10:49, Archit Taneja wrote: >> Hi Hans, >> >> On 07/30/2017 06:37 PM, Hans Verkuil wrote: >>> From: Hans Verkuil >>> >>> This patch series adds CEC support to the drm adv7511/adv7533 drivers. >>> >>> I have tested this with the Qualcomm Dragonboard C410 (adv7533 based) >>> and the Renesas R-Car Koelsch board (adv7511 based). >>> >>> Note: the Dragonboard needs this patch: >>> >>> https://patchwork.kernel.org/patch/9824773/ >>> >>> Archit, can you confirm that this patch will go to kernel 4.14? >>> >>> And the Koelsch board needs this 4.13 fix: >>> >>> https://patchwork.kernel.org/patch/9836865/ >>> >>> I only have the Koelsch board to test with, but it looks like other >>> R-Car boards use the same adv7511. It would be nice if someone can >>> add CEC support to the other R-Car boards as well. The main thing >>> to check is if they all use the same 12 MHz fixed CEC clock source. >>> >>> Anyone who wants to test this will need the CEC utilities that >>> are part of the v4l-utils git repository: >>> >>> git clone git://linuxtv.org/v4l-utils.git >>> cd v4l-utils >>> ./bootstrap.sh >>> ./configure >>> make >>> sudo make install >>> >>> Now configure the CEC adapter as a Playback device: >>> >>> cec-ctl --playback >>> >>> Discover other CEC devices: >>> >>> cec-ctl -S >> >> I tried the instructions, and I get the following output. I don't think I have >> any CEC device connected, though. Is this the expected behaviour? >> >> #cec-ctl -S >> Driver Info: >> Driver Name : adv7511 >> Adapter Name : 3-0039 >> Capabilities : 0x0000000e >> Logical Addresses >> Transmit >> Passthrough >> Driver version : 4.13.0 >> Available Logical Addresses: 3 >> Physical Address : 1.0.0.0 >> Logical Address Mask : 0x0000 >> CEC Version : 2.0 >> Logical Addresses : 0 >> >> #cec-ctl --playback >> [ 1038.761545] cec-3-0039: cec_thread_func: message 44 timed out! > > This isn't right. You shouldn't see this. It never receives an interrupt > when the transmit has finished, which causes these time outs. > > What are you testing this on? The Dragonboard c410? Yes. > > Can you check the cec clock frequency? It should be 19.2 MHz. > Remember to apply this patch: https://patchwork.kernel.org/patch/9824773/ > You probably did, but just in case... clk_summary does show bb_clk2 to be set to 19.2 Mhz. I applied a newer version of this patch, which got merged in clk-next: https://patchwork.kernel.org/patch/9845493/ I will try to apply the patch you use and check again. Thanks, Archit > > Regards, > > Hans > >> Driver Info: >> Driver Name : adv7511 >> Adapter Name : 3-0039 >> Capabilities : 0x0000000e >> Logical Addresses >> Transmit >> Passthrough >> Driver version : 4.13.0 >> Available Logical Addresses: 3 >> Physical Address : 1.0.0.0 >> Logical Address Mask : 0x0010 >> CEC Version : 2.0 >> Vendor ID : 0x000c03 >> Logical Addresses : 1 (Allow RC Passthrough) >> >> Logical Address : 4 >> Primary Device Type : Playback >> Logical Address Type : Playback >> All Device Types : Playback >> RC TV Profile : None >> Device Features : >> None >> >> >> [ 1041.063605] cec-3-0039: cec_thread_func: message 4f a6 06 10 00 00 timed out! >> [ 1043.367482] cec-3-0039: cec_thread_func: message 4f 84 10 00 04 timed out! >> >> Thanks, >> Archit >> >>> >>> Regards, >>> >>> Hans >>> >>> Hans Verkuil (4): >>> dt-bindings: adi,adv7511.txt: document cec clock >>> arm: dts: qcom: add cec clock for apq8016 board >>> arm: dts: renesas: add cec clock for Koelsch board >>> drm: adv7511/33: add HDMI CEC support >>> >>> .../bindings/display/bridge/adi,adv7511.txt | 4 + >>> arch/arm/boot/dts/r8a7791-koelsch.dts | 8 + >>> arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi | 2 + >>> drivers/gpu/drm/bridge/adv7511/Kconfig | 8 + >>> drivers/gpu/drm/bridge/adv7511/Makefile | 1 + >>> drivers/gpu/drm/bridge/adv7511/adv7511.h | 45 ++- >>> drivers/gpu/drm/bridge/adv7511/adv7511_cec.c | 314 +++++++++++++++++++++ >>> drivers/gpu/drm/bridge/adv7511/adv7511_drv.c | 152 +++++++++- >>> drivers/gpu/drm/bridge/adv7511/adv7533.c | 30 +- >>> 9 files changed, 514 insertions(+), 50 deletions(-) >>> create mode 100644 drivers/gpu/drm/bridge/adv7511/adv7511_cec.c >>> >> > > -- > To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project