All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Jan Beulich <jbeulich@suse.com>,
	"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: "George Dunlap" <george.dunlap@citrix.com>,
	"Julien Grall" <julien@xen.org>,
	"Stefano Stabellini" <sstabellini@kernel.org>,
	"Wei Liu" <wl@xen.org>, "Roger Pau Monné" <roger.pau@citrix.com>,
	"Nicola Vetrini" <nicola.vetrini@bugseng.com>
Subject: Re: [PATCH v2] x86/DMI: adjustments to comply with Misra C:2012 Rule 9.3
Date: Wed, 6 Dec 2023 20:45:01 +0000	[thread overview]
Message-ID: <75a57d20-e2e2-47d3-8aa8-79b6ffb18f07@citrix.com> (raw)
In-Reply-To: <1ca903e7-ed2c-435e-999d-2a8519957498@suse.com>

On 05/12/2023 1:35 pm, Jan Beulich wrote:
> The rule demands that all array elements be initialized (or dedicated
> initializers be used). Introduce a small set of macros to allow doing so
> without unduly affecting use sites (in particular in terms of how many
> elements .matches[] actually has; right now there's no use of
> DMI_MATCH4(), so we could even consider reducing the array size to 3).
>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
> ---
> Of course a question is how many of these DMI table entries are in fact
> no longer applicable (e.g. because of naming 32-bit-only systems).
> Subsequently the table in dmi_scan.c itself may want cleaning up as
> well, yet I guess the question of stale entries is even more relevant
> there.
> ---
> v2: Make things also build with older gcc.


This is broken with Ubuntu
https://gitlab.com/xen-project/xen/-/jobs/5691138448  and you don't
appear to have been online today.

Unless you have a clever idea for a very prompt fix, it's going to need
reverting to cause GitlabCI to be usable for everyone else.

~Andrew


  parent reply	other threads:[~2023-12-06 20:45 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-05 13:35 [PATCH v2] x86/DMI: adjustments to comply with Misra C:2012 Rule 9.3 Jan Beulich
2023-12-05 16:25 ` Nicola Vetrini
2023-12-05 22:53 ` Stefano Stabellini
2023-12-06 20:45 ` Andrew Cooper [this message]
2023-12-07  7:31   ` Jan Beulich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=75a57d20-e2e2-47d3-8aa8-79b6ffb18f07@citrix.com \
    --to=andrew.cooper3@citrix.com \
    --cc=george.dunlap@citrix.com \
    --cc=jbeulich@suse.com \
    --cc=julien@xen.org \
    --cc=nicola.vetrini@bugseng.com \
    --cc=roger.pau@citrix.com \
    --cc=sstabellini@kernel.org \
    --cc=wl@xen.org \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.