All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com>
To: Mark Brown <broonie@kernel.org>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
	Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
	linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ASoC: core: Support INPUT and OUTPUT DAPM widgets in DT
Date: Thu, 6 Aug 2026 09:14:02 +0300	[thread overview]
Message-ID: <75ab739a-b70c-49ab-af90-03d40fc3b5ff@gmail.com> (raw)
In-Reply-To: <f2b01744-69d1-429d-bffc-db0e571665f9@sirena.org.uk>



On 5.08.26 г. 20:23 ч., Mark Brown wrote:
> On Wed, Aug 05, 2026 at 08:16:10PM +0300, Ivaylo Dimitrov wrote:
> 
>> I have an out-of-tree audio-graph-card2 based machine description for
>> Motorola OMAP4 devices using the CPCAP codec together with an external modem
>> codec. Without modelling the remote endpoint as a DAPM INPUT/OUTPUT widget,
>> the DAPM graph is incomplete and one side of the codec-to-codec link does
>> not become active as expected, so runtime PM does not resume one of the
>> devices in the link during a call.
> 
> Why is it appropriate that the remote endpoint be a raw widget of this
> non-specific type?
> 
>> I used INPUT/OUTPUT because they appear to be the generic DAPM endpoint
>> widgets for this type of digital connection. If there is a more appropriate
>> existing widget type for modelling such a remote DAI endpoint, I'd be happy
>> to use that instead.
> 
> If it's a DAI to DAI link you need a custom machine driver, we don't
> have anything like the infrastructure to put DAI<->DAI links in DT.
> These should be using AIF widgets.

Thanks for the pointer. It turned out that everything needed was already 
there; I had simply misunderstood the codec2codec example (or perhaps it 
could be a bit clearer).

The missing piece was to route the modem DAI stream widgets to the CPCAP 
AIF widgets in the audio-graph-card2 routing:

/* codec2codec */
"Voice RX", "Voice Call Playback",
"Voice Call Capture", "Voice TX";

With that in place, the codec-to-codec DAPM graph is complete and voice 
calls work correctly, so there is no need for my DT parser patch after all.

I'm sending this follow-up mainly as a reference in case someone else 
runs into the same issue in the future.

Thanks again for pointing me in the right direction.

Best regards,
Ivo

      parent reply	other threads:[~2026-08-06  6:14 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-05 14:56 [PATCH] ASoC: core: Support INPUT and OUTPUT DAPM widgets in DT Ivaylo Dimitrov
2026-08-05 16:40 ` Mark Brown
2026-08-05 17:16   ` Ivaylo Dimitrov
2026-08-05 17:23     ` Mark Brown
2026-08-05 21:36       ` Ivaylo Dimitrov
2026-08-06  6:14       ` Ivaylo Dimitrov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=75ab739a-b70c-49ab-af90-03d40fc3b5ff@gmail.com \
    --to=ivo.g.dimitrov.75@gmail.com \
    --cc=broonie@kernel.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=perex@perex.cz \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.