Re: [Buildroot] [PATCH/next v2 5/9] package/flutter-sdk-bin/Config.in.host: add pub-cache location option

[Arnout Vandecappelle via buildroot <buildroot@buildroot.org>]

On 18/11/2023 23:12, Adam Duskett wrote:
> When running the command "flutter pub get," the plugins are stored in the
> pub-cache directory along with their sha256sum hashes. The default location
> of the pub-cache directory is $(HOST_DIR)/share/flutter/sdk/.pub-cache.
> While the above location is a perfectly acceptable choice by default, users
> may want to define an alternate location to prevent downloading all of the
> plugins on each fresh build of a Flutter application, and they may want to
> commit the pub-cache directory to their project.
> 
> Add the new option BR2_PACKAGE_HOST_FLUTTER_SDK_BIN_PUB_CACHE_LOCATION to the
> flutter-sdk-bin/Config.in.host file, and set the default to the current
> default of $(HOST_DIR)/share/flutter/sdk/.pub-cache.
> 
> Signed-off-by: Adam Duskett <adam.duskett@amarulasolutions.com>
> ---
>   package/flutter-sdk-bin/Config.in.host     | 11 +++++++++++
>   package/flutter-sdk-bin/flutter-sdk-bin.mk |  2 +-
>   2 files changed, 12 insertions(+), 1 deletion(-)
> 
> diff --git a/package/flutter-sdk-bin/Config.in.host b/package/flutter-sdk-bin/Config.in.host
> index a48714ea7f..0e31a8e0fa 100644
> --- a/package/flutter-sdk-bin/Config.in.host
> +++ b/package/flutter-sdk-bin/Config.in.host
> @@ -14,3 +14,14 @@ config BR2_PACKAGE_HOST_FLUTTER_SDK_BIN
>   	  free and open source.
>   
>   	  https://flutter.dev/
> +
> +if BR2_PACKAGE_HOST_FLUTTER_SDK_BIN_ARCH_SUPPORTS
> +
> +config BR2_PACKAGE_HOST_FLUTTER_SDK_BIN_PUB_CACHE_LOCATION
> +	string "pub-cache location"
> +	default "$(HOST_DIR)/share/flutter/sdk/.pub-cache"
> +	help
> +	  Directory to store cached packages used by Pub with
> +	  Dart/Flutter.
> +
> +endif
> diff --git a/package/flutter-sdk-bin/flutter-sdk-bin.mk b/package/flutter-sdk-bin/flutter-sdk-bin.mk
> index 9461148dfb..6471c11d4e 100644
> --- a/package/flutter-sdk-bin/flutter-sdk-bin.mk
> +++ b/package/flutter-sdk-bin/flutter-sdk-bin.mk
> @@ -95,4 +95,4 @@ HOST_FLUTTER_SDK_BIN_DART_BIN = \
>   $(eval $(host-generic-package))
>   
>   # For target packages to locate said pub-cache
> -FLUTTER_SDK_BIN_PUB_CACHE = $(HOST_FLUTTER_SDK_BIN_SDK)/.pub-cache
> +FLUTTER_SDK_BIN_PUB_CACHE = $(call qstrip,$(BR2_PACKAGE_HOST_FLUTTER_SDK_BIN_PUB_CACHE_LOCATION))

  What about this code?

# Remove the cache, as we will run precache after setting up flutter and dart
# with the new config options.
define HOST_FLUTTER_SDK_BIN_BUILD_CMDS
         mkdir -p $(HOST_FLUTTER_SDK_BIN_SDK)
         rm -rf $(HOST_FLUTTER_SDK_BIN_SDK)/.pub-cache
         cd $(@D) && \
                 $(HOST_FLUTTER_SDK_BIN_ENV) $(@D)/bin/flutter precache;
endef


  Either this code is needed and the idea of a shared cache is void, and it 
really shouldn't be in DL_DIR at all. Or it is not needed and it should be 
removed, with an explanation about why this "setting up flutter and dart with 
the new config optoins" doesn't actually apply.

  Regards,
  Arnout
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot