From mboxrd@z Thu Jan 1 00:00:00 1970 From: Amos Kong Subject: Re: qemu-kvm: remove "boot=on|off" drive parameter compatibility Date: Sun, 30 Sep 2012 21:02:49 -0400 (EDT) Message-ID: <760290371.4049669.1349053369230.JavaMail.root@redhat.com> References: <20120930191146.GA20012@amt.cnet> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: Jan Kiszka , kvm To: Marcelo Tosatti Return-path: Received: from mx3-phx2.redhat.com ([209.132.183.24]:58753 "EHLO mx3-phx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751254Ab2JABCw (ORCPT ); Sun, 30 Sep 2012 21:02:52 -0400 In-Reply-To: <20120930191146.GA20012@amt.cnet> Sender: kvm-owner@vger.kernel.org List-ID: ----- Original Message ----- > > Option is deprecated and warning has been in place for one year. > > Signed-off-by: Marcelo Tosatti > > diff --git a/blockdev.c b/blockdev.c > index 4a5266e..7c83baa 100644 > --- a/blockdev.c > +++ b/blockdev.c > @@ -432,12 +432,6 @@ DriveInfo *drive_init(QemuOpts *opts, int > default_to_scsi) > return NULL; > } > > - if (qemu_opt_get(opts, "boot") != NULL) { > - fprintf(stderr, "qemu-kvm: boot=on|off is deprecated and > will be " > - "ignored. Future versions will reject this > parameter. Please " > - "update your scripts.\n"); > - } > - > on_write_error = BLOCK_ERR_STOP_ENOSPC; > if ((buf = qemu_opt_get(opts, "werror")) != NULL) { > if (type != IF_IDE && type != IF_SCSI && type != IF_VIRTIO > && type != IF_NONE) { > diff --git a/qemu-config.c b/qemu-config.c > index 3eaee48..eba977e 100644 > --- a/qemu-config.c > +++ b/qemu-config.c > @@ -114,10 +114,6 @@ static QemuOptsList qemu_drive_opts = { > .name = "copy-on-read", > .type = QEMU_OPT_BOOL, > .help = "copy read data from backing file into image > file", > - },{ > - .name = "boot", > - .type = QEMU_OPT_BOOL, > - .help = "(deprecated, ignored)", > }, > { /* end of list */ } > }, Reviewed-by: Amos Kong