From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E4DA3C77B61 for ; Tue, 25 Apr 2023 18:46:20 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id A152D862F0; Tue, 25 Apr 2023 20:46:18 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=ti.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=ti.com header.i=@ti.com header.b="P8nquf8v"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 9AE09862E2; Tue, 25 Apr 2023 20:46:17 +0200 (CEST) Received: from fllv0016.ext.ti.com (fllv0016.ext.ti.com [198.47.19.142]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id C0D8A862E7 for ; Tue, 25 Apr 2023 20:46:13 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=ti.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=afd@ti.com Received: from fllv0035.itg.ti.com ([10.64.41.0]) by fllv0016.ext.ti.com (8.15.2/8.15.2) with ESMTP id 33PIk3RJ116893; Tue, 25 Apr 2023 13:46:03 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1682448363; bh=IihvrWYc7zgAXg70O7mxZkXNh4SPEfPkw7cjEt2rByg=; h=Date:Subject:To:CC:References:From:In-Reply-To; b=P8nquf8v2y2oUiBaduEv7Kkinggt+TDppT+gtdkaYWk3iHLE0ZMPwTkMtgIcerC2B lDdaIYFp1YsXOKR/TyFFrRk9cszvyZXo8e/eWZt8M0ajS2f8ebsl7NL6sxHI+v5Hw5 h7X5gysiH2yTpoYuw/abmt/WwSX9pSyaZoWAXbs0= Received: from DLEE108.ent.ti.com (dlee108.ent.ti.com [157.170.170.38]) by fllv0035.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 33PIk3xj052231 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Tue, 25 Apr 2023 13:46:03 -0500 Received: from DLEE110.ent.ti.com (157.170.170.21) by DLEE108.ent.ti.com (157.170.170.38) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.16; Tue, 25 Apr 2023 13:46:02 -0500 Received: from fllv0039.itg.ti.com (10.64.41.19) by DLEE110.ent.ti.com (157.170.170.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.16 via Frontend Transport; Tue, 25 Apr 2023 13:46:02 -0500 Received: from [10.250.35.77] (ileaxei01-snat.itg.ti.com [10.180.69.5]) by fllv0039.itg.ti.com (8.15.2/8.15.2) with ESMTP id 33PIk2TW129995; Tue, 25 Apr 2023 13:46:02 -0500 Message-ID: <760595cc-9c59-3cac-31da-8370bb01b544@ti.com> Date: Tue, 25 Apr 2023 13:46:01 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [PATCH v3 11/19] am64x: dts: binman: Package tiboot3.bin, tispl.bin u-boot.img Content-Language: en-US To: Neha Malcom Francis , Simon Glass CC: , , , , , , , References: <20230421123203.1315330-1-n-francis@ti.com> <20230421123203.1315330-12-n-francis@ti.com> <05206f93-9873-7bf4-7910-1892bb227253@ti.com> From: Andrew Davis In-Reply-To: <05206f93-9873-7bf4-7910-1892bb227253@ti.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean On 4/25/23 2:31 AM, Neha Malcom Francis wrote: > Hi Simon > > On 25/04/23 01:12, Simon Glass wrote: >> Hi Neha, >> >> On Fri, 21 Apr 2023 at 06:32, Neha Malcom Francis wrote: >>> >>> Support added for HS and GP boot binaries for AM64x. >>> >>> tiboot3.bin, tispl.bin and u-boot.img: For HS-SE devices >>> tiboot3.bin_fs, tispl.bin and u-boot.img: For HS-FS devices >>> tiboot3.bin_unsigned, tispl.bin_unsigned, u-boot.img_unsigned: For GP >>> devices >>> >>> Note that the bootflow followed by AM64x requires: >>> >>> tiboot3.bin: >>>          * R5 SPL >>>          * R5 SPL dtbs >>>          * sysfw >>>          * board-cfg >>>          * pm-cfg >>>          * sec-cfg >>>          * rm-cfg >>> >>> tispl.bin: >>>          * ATF >>>          * OPTEE >>>          * A53 SPL >>>          * A53 SPL dtbs >>> >>> u-boot.img: >>>          * A53 U-Boot >>>          * A53 U-Boot dtbs >>> >>> Signed-off-by: Neha Malcom Francis >>> --- >>>   arch/arm/dts/k3-am642-evm-u-boot.dtsi |   2 + >>>   arch/arm/dts/k3-am642-r5-evm.dts      |   1 + >>>   arch/arm/dts/k3-am64x-binman.dtsi     | 569 ++++++++++++++++++++++++++ >>>   board/ti/am64x/Kconfig                |   2 + >>>   4 files changed, 574 insertions(+) >>>   create mode 100644 arch/arm/dts/k3-am64x-binman.dtsi >> >> Reviewed-by: Simon Glass >> >> I notice that some of the entries are optional. Do you actual make use >> of this (i.e. that when they are missing binman removes the entries)? >> > > So right now the build generates binaries for all three types: HS-FS, HS-SE and GP devices. It's not necessary for the user to provide component binaries for all three of them, say they only have GP SYSFW binaries available with them. Would this ever need to happen? We provide all three firmware types for all our SoCs out in public[0], why would anyone only have one type of firmware available? Andrew [0] https://git.ti.com/cgit/processor-firmware/ti-linux-firmware/tree/ti-sysfw?h=ti-linux-firmware > So that was the reasoning behind putting those binaries as optional, we should not have a failed build in those cases. However binaries like DM and board-config binaries that are common between all three needs to be there so it's not optional. > >> Regards, >> Simon >