From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0CFEAC47410 for ; Tue, 19 Nov 2019 17:17:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E0B93223CE for ; Tue, 19 Nov 2019 17:17:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728339AbfKSRRK (ORCPT ); Tue, 19 Nov 2019 12:17:10 -0500 Received: from foss.arm.com ([217.140.110.172]:55780 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727805AbfKSRRK (ORCPT ); Tue, 19 Nov 2019 12:17:10 -0500 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 841311FB; Tue, 19 Nov 2019 09:17:09 -0800 (PST) Received: from [10.1.196.37] (e121345-lin.cambridge.arm.com [10.1.196.37]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id B5FBF3F703; Tue, 19 Nov 2019 09:17:04 -0800 (PST) Subject: Re: [PATCH] dma-mapping: treat dev->bus_dma_mask as a DMA limit To: Christoph Hellwig , Nicolas Saenz Julienne Cc: Dave Hansen , Andy Lutomirski , Peter Zijlstra , Bjorn Helgaas , Lorenzo Pieralisi , Hanjun Guo , Sudeep Holla , Jens Axboe , Joerg Roedel , Rob Herring , Frank Rowand , Marek Szyprowski , Benjamin Herrenschmidt , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, linux-ide@vger.kernel.org, Paul Mackerras , "H. Peter Anvin" , Paul Burton , Michael Ellerman , x86@kernel.org, phil@raspberrypi.org, linux-acpi@vger.kernel.org, Ingo Molnar , James Hogan , Len Brown , devicetree@vger.kernel.org, Borislav Petkov , Thomas Gleixner , linux-arm-kernel@lists.infradead.org, "Rafael J. Wysocki" , linux-mips@vger.kernel.org, Ralf Baechle , iommu@lists.linux-foundation.org, linuxppc-dev@lists.ozlabs.org References: <20191113161340.27228-1-nsaenzjulienne@suse.de> <20191119170006.GA19569@lst.de> From: Robin Murphy Message-ID: <7609007d-52f5-bb10-e8d5-96fadbfab46d@arm.com> Date: Tue, 19 Nov 2019 17:17:03 +0000 User-Agent: Mozilla/5.0 (X11; Linux aarch64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <20191119170006.GA19569@lst.de> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit Sender: linux-acpi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org On 19/11/2019 5:00 pm, Christoph Hellwig wrote: > On Tue, Nov 19, 2019 at 01:57:43PM +0100, Nicolas Saenz Julienne wrote: >> Hi Rob & Christoph, >> do you mind if I append v2 of this into my upcoming v3 RPi4 PCIe support >> series, I didn't do it initially as I thought this was going to be a >> contentious patch. But as it turned out better than expected, I think it >> should go into the PCIe series. In the end it's the first explicit user of the >> bus DMA limit. >> >> Here's v2 in case you don't know what I'm talking about: >> https://www.spinics.net/lists/arm-kernel/msg768459.html > > In principle I wouldn't mind, but I think this is going to conflict > quite badly with other changes in the dma-mapping tree (including > yours). So I think we'll need a shared tree or I'll need to pull > in the whole series through the dma-mapping tree if there are not > other conflicts and the other maintainers are fine with it. TBH I can't see it being a massive problem even if the DMA patch, driver and DTS patch went entirely separately via the respective DMA, PCI, and arm-soc trees in the same cycle. Bisecting over a merge window is a big enough pain in the bum as it is, and if the worst case is that someone trying to do that on a Pi4 has a wonky PCI controller appear for a couple of commits, they may as well just disable that driver for their bisection, because it wasn't there at the start so can't possibly be the thing they're looking for regressions in ;) Robin. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1A7BCC432C0 for ; Tue, 19 Nov 2019 17:19:26 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8B1C92231A for ; Tue, 19 Nov 2019 17:19:25 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8B1C92231A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 47HXcW0VXyzDqdM for ; Wed, 20 Nov 2019 04:19:23 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=arm.com (client-ip=217.140.110.172; helo=foss.arm.com; envelope-from=robin.murphy@arm.com; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=arm.com Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lists.ozlabs.org (Postfix) with ESMTP id 47HXZ35g0zzDqZQ for ; Wed, 20 Nov 2019 04:17:13 +1100 (AEDT) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 841311FB; Tue, 19 Nov 2019 09:17:09 -0800 (PST) Received: from [10.1.196.37] (e121345-lin.cambridge.arm.com [10.1.196.37]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id B5FBF3F703; Tue, 19 Nov 2019 09:17:04 -0800 (PST) Subject: Re: [PATCH] dma-mapping: treat dev->bus_dma_mask as a DMA limit To: Christoph Hellwig , Nicolas Saenz Julienne References: <20191113161340.27228-1-nsaenzjulienne@suse.de> <20191119170006.GA19569@lst.de> From: Robin Murphy Message-ID: <7609007d-52f5-bb10-e8d5-96fadbfab46d@arm.com> Date: Tue, 19 Nov 2019 17:17:03 +0000 User-Agent: Mozilla/5.0 (X11; Linux aarch64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <20191119170006.GA19569@lst.de> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Zijlstra , Dave Hansen , linux-mips@vger.kernel.org, linux-ide@vger.kernel.org, Paul Mackerras , "H. Peter Anvin" , Frank Rowand , Marek Szyprowski , Lorenzo Pieralisi , Paul Burton , Joerg Roedel , x86@kernel.org, phil@raspberrypi.org, linux-acpi@vger.kernel.org, Ingo Molnar , linux-pci@vger.kernel.org, James Hogan , Len Brown , devicetree@vger.kernel.org, Rob Herring , Borislav Petkov , Andy Lutomirski , Bjorn Helgaas , Thomas Gleixner , linux-arm-kernel@lists.infradead.org, Jens Axboe , "Rafael J. Wysocki" , Hanjun Guo , linux-kernel@vger.kernel.org, Ralf Baechle , iommu@lists.linux-foundation.org, Sudeep Holla , linuxppc-dev@lists.ozlabs.org Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On 19/11/2019 5:00 pm, Christoph Hellwig wrote: > On Tue, Nov 19, 2019 at 01:57:43PM +0100, Nicolas Saenz Julienne wrote: >> Hi Rob & Christoph, >> do you mind if I append v2 of this into my upcoming v3 RPi4 PCIe support >> series, I didn't do it initially as I thought this was going to be a >> contentious patch. But as it turned out better than expected, I think it >> should go into the PCIe series. In the end it's the first explicit user of the >> bus DMA limit. >> >> Here's v2 in case you don't know what I'm talking about: >> https://www.spinics.net/lists/arm-kernel/msg768459.html > > In principle I wouldn't mind, but I think this is going to conflict > quite badly with other changes in the dma-mapping tree (including > yours). So I think we'll need a shared tree or I'll need to pull > in the whole series through the dma-mapping tree if there are not > other conflicts and the other maintainers are fine with it. TBH I can't see it being a massive problem even if the DMA patch, driver and DTS patch went entirely separately via the respective DMA, PCI, and arm-soc trees in the same cycle. Bisecting over a merge window is a big enough pain in the bum as it is, and if the worst case is that someone trying to do that on a Pi4 has a wonky PCI controller appear for a couple of commits, they may as well just disable that driver for their bisection, because it wasn't there at the start so can't possibly be the thing they're looking for regressions in ;) Robin. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 27C03C33C9D for ; Tue, 19 Nov 2019 17:17:15 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CB3732084D for ; Tue, 19 Nov 2019 17:17:14 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="fx8h8hr3" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CB3732084D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=p3vmcPnCX2JQbtKfl6iuaAaDNN9LUKJ0PpJQ1xtBxC0=; b=fx8h8hr3VHZbO9FP695GTAGyv GQs2rv6L7X1CxiGnhBl/Cp7WSnoJYiG517Ynkdhx9hqtDCPBqANls1G2CMk+K4p33vWZf3wNLStoH n7gyL4YqxcYUQ2cDyru59TNKnKEfNuc8x2omVRL4LX9/ysB8O5/QRP2/A4yzC0pOgU8G5ghICmbq7 pHhlEIyqX36urHPJcfdmFCueu9Kfy+/ph2OHCw68clWfp68h2XQkyHZC0nBRezMLjR/WY9WvJ8hva 3qYt7vdzhbgRMbCNPlxKLXdfERjbAvTFzfF7JIeKQOiyEk+jmlmEptoo69OBFIAFr8FU6N5x2PnCi 5NKfpRN6A==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iX77q-00027i-5x; Tue, 19 Nov 2019 17:17:14 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iX77n-00026j-CD for linux-arm-kernel@lists.infradead.org; Tue, 19 Nov 2019 17:17:12 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 841311FB; Tue, 19 Nov 2019 09:17:09 -0800 (PST) Received: from [10.1.196.37] (e121345-lin.cambridge.arm.com [10.1.196.37]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id B5FBF3F703; Tue, 19 Nov 2019 09:17:04 -0800 (PST) Subject: Re: [PATCH] dma-mapping: treat dev->bus_dma_mask as a DMA limit To: Christoph Hellwig , Nicolas Saenz Julienne References: <20191113161340.27228-1-nsaenzjulienne@suse.de> <20191119170006.GA19569@lst.de> From: Robin Murphy Message-ID: <7609007d-52f5-bb10-e8d5-96fadbfab46d@arm.com> Date: Tue, 19 Nov 2019 17:17:03 +0000 User-Agent: Mozilla/5.0 (X11; Linux aarch64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <20191119170006.GA19569@lst.de> Content-Language: en-GB X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191119_091711_459016_D2BB5B9B X-CRM114-Status: GOOD ( 18.61 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Zijlstra , Benjamin Herrenschmidt , Dave Hansen , linux-mips@vger.kernel.org, linux-ide@vger.kernel.org, Paul Mackerras , "H. Peter Anvin" , Frank Rowand , Marek Szyprowski , Lorenzo Pieralisi , Paul Burton , Michael Ellerman , Joerg Roedel , x86@kernel.org, phil@raspberrypi.org, linux-acpi@vger.kernel.org, Ingo Molnar , linux-pci@vger.kernel.org, James Hogan , Len Brown , devicetree@vger.kernel.org, Rob Herring , Borislav Petkov , Andy Lutomirski , Bjorn Helgaas , Thomas Gleixner , linux-arm-kernel@lists.infradead.org, Jens Axboe , "Rafael J. Wysocki" , Hanjun Guo , linux-kernel@vger.kernel.org, Ralf Baechle , iommu@lists.linux-foundation.org, Sudeep Holla , linuxppc-dev@lists.ozlabs.org Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 19/11/2019 5:00 pm, Christoph Hellwig wrote: > On Tue, Nov 19, 2019 at 01:57:43PM +0100, Nicolas Saenz Julienne wrote: >> Hi Rob & Christoph, >> do you mind if I append v2 of this into my upcoming v3 RPi4 PCIe support >> series, I didn't do it initially as I thought this was going to be a >> contentious patch. But as it turned out better than expected, I think it >> should go into the PCIe series. In the end it's the first explicit user of the >> bus DMA limit. >> >> Here's v2 in case you don't know what I'm talking about: >> https://www.spinics.net/lists/arm-kernel/msg768459.html > > In principle I wouldn't mind, but I think this is going to conflict > quite badly with other changes in the dma-mapping tree (including > yours). So I think we'll need a shared tree or I'll need to pull > in the whole series through the dma-mapping tree if there are not > other conflicts and the other maintainers are fine with it. TBH I can't see it being a massive problem even if the DMA patch, driver and DTS patch went entirely separately via the respective DMA, PCI, and arm-soc trees in the same cycle. Bisecting over a merge window is a big enough pain in the bum as it is, and if the worst case is that someone trying to do that on a Pi4 has a wonky PCI controller appear for a couple of commits, they may as well just disable that driver for their bisection, because it wasn't there at the start so can't possibly be the thing they're looking for regressions in ;) Robin. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel