All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Hogander, Jouni" <jouni.hogander@intel.com>
To: "Joshi, Kunal1" <kunal1.joshi@intel.com>,
	"igt-dev@lists.freedesktop.org" <igt-dev@lists.freedesktop.org>
Cc: "Murthy, Arun R" <arun.r.murthy@intel.com>
Subject: Re: [igt-dev] [PATCH i-g-t 5/7] lib/igt_psr: modified psr_get_mode for pr compatability
Date: Tue, 31 Oct 2023 12:06:38 +0000	[thread overview]
Message-ID: <761972b1a6acd4f2d79a5bdb501e3d2bcdb8a4dc.camel@intel.com> (raw)
In-Reply-To: <20231031080949.1145422-6-kunal1.joshi@intel.com>

On Tue, 2023-10-31 at 13:39 +0530, Kunal Joshi wrote:
> Modified psr_get_mode for PR_MODE
> 
> Cc: Jouni Högander <jouni.hogander@intel.com>
> Cc: Animesh Manna <animesh.manna@intel.com>
> Cc: Arun R Murthy <arun.r.murthy@intel.com>
> Signed-off-by: Kunal Joshi <kunal1.joshi@intel.com>
> ---
>  lib/igt_psr.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/lib/igt_psr.c b/lib/igt_psr.c
> index c2b2a4148..bddf80d6a 100644
> --- a/lib/igt_psr.c
> +++ b/lib/igt_psr.c
> @@ -382,7 +382,9 @@ enum psr_mode psr_get_mode(int debugfs_fd)
>                 return PSR_DISABLED;
>         }
>  
> -       if (strstr(buf, "PSR2 selective fetch: enabled"))
> +       if (strstr(buf, "Panel Replay Enabled"))
> +               return PR_MODE;
> +       else if (strstr(buf, "PSR2 selective fetch: enabled"))
>                 return PSR_MODE_2_SEL_FETCH;
>         else if (strstr(buf, "PSR2 enabled"))
>                 return PSR_MODE_2;

You are missing Panel Replay Selective update. I would assume format
like this:
for PR Selective update:

Sink support: Panel Replay Selective update
PSR mode: Panel Replay Selective update enabled
Source PSR ctl: enabled [0xc2004a99]
Source PSR status: DEEP_SLEEP [0x80000100]
Busy frontbuffer bits: 0x00000000
Performance counter: 0
Frame:	PSR2 SU blocks:
0	0
1	0
2	0
3	0
4	0
5	0
6	0
7	0
PSR2 selective fetch: enabled

and PR:

Sink support: Panel Replay
PSR mode: Panel Replay enabled
PSR sink not reliable: no

BR,

Jouni Högander

  reply	other threads:[~2023-10-31 12:06 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-31  8:09 [igt-dev] [PATCH i-g-t 0/7] extend kms_psr test to validate pr Kunal Joshi
2023-10-31  8:09 ` [igt-dev] [PATCH i-g-t 1/7] lib/igt_psr: added enum for panel replay Kunal Joshi
2023-10-31 11:32   ` Hogander, Jouni
2023-10-31  8:09 ` [igt-dev] [PATCH i-g-t 2/7] lib/igt_psr: modified psr_sink_support for pr compatability Kunal Joshi
2023-10-31 10:40   ` Hogander, Jouni
2023-10-31 12:02     ` Hogander, Jouni
2023-10-31  8:09 ` [igt-dev] [PATCH i-g-t 3/7] lib/igt_psr: modified psr_active_check " Kunal Joshi
2023-10-31 11:38   ` Hogander, Jouni
2023-10-31  8:09 ` [igt-dev] [PATCH i-g-t 4/7] lib/igt_psr: modified psr_set " Kunal Joshi
2023-10-31 11:42   ` Hogander, Jouni
2023-10-31  8:09 ` [igt-dev] [PATCH i-g-t 5/7] lib/igt_psr: modified psr_get_mode " Kunal Joshi
2023-10-31 12:06   ` Hogander, Jouni [this message]
2023-10-31  8:09 ` [igt-dev] [PATCH i-g-t 6/7] tests/intel/kms_psr: made test compaitable with pr Kunal Joshi
2023-10-31 12:23   ` Hogander, Jouni
2023-10-31  8:09 ` [igt-dev] [PATCH i-g-t 7/7] HAX PATCH DO NOT MERGE Kunal Joshi
2023-10-31  9:41 ` [igt-dev] ✗ Fi.CI.BAT: failure for extend kms_psr test to validate pr (rev3) Patchwork
2023-10-31  9:43 ` [igt-dev] ✗ CI.xeBAT: " Patchwork
  -- strict thread matches above, loose matches on Subject: below --
2023-11-10  9:52 [igt-dev] [PATCH i-g-t 0/7] extend kms_psr test to validate pr Kunal Joshi
2023-11-10  9:52 ` [igt-dev] [PATCH i-g-t 5/7] lib/igt_psr: modified psr_get_mode for pr compatability Kunal Joshi
2023-11-10  9:43 [igt-dev] [PATCH i-g-t 0/7] extend kms_psr test to validate pr Kunal Joshi
2023-11-10  9:43 ` [igt-dev] [PATCH i-g-t 5/7] lib/igt_psr: modified psr_get_mode for pr compatability Kunal Joshi
2023-11-10  8:15 [igt-dev] [PATCH i-g-t 0/7] extend kms_psr test to validate pr Kunal Joshi
2023-11-10  8:15 ` [igt-dev] [PATCH i-g-t 5/7] lib/igt_psr: modified psr_get_mode for pr compatability Kunal Joshi
2023-11-10  7:16 [igt-dev] [PATCH i-g-t 0/7] extend kms_psr test to validate pr Kunal Joshi
2023-11-10  7:16 ` [igt-dev] [PATCH i-g-t 5/7] lib/igt_psr: modified psr_get_mode for pr compatability Kunal Joshi
2023-11-10  7:35   ` Hogander, Jouni
2023-11-09  6:09 [igt-dev] [PATCH i-g-t 0/7] extend kms_psr test to validate pr Kunal Joshi
2023-11-09  6:09 ` [igt-dev] [PATCH i-g-t 5/7] lib/igt_psr: modified psr_get_mode for pr compatability Kunal Joshi
2023-11-09  3:36 [igt-dev] [PATCH i-g-t 0/7] extend kms_psr test to validate pr Kunal Joshi
2023-11-09  3:37 ` [igt-dev] [PATCH i-g-t 5/7] lib/igt_psr: modified psr_get_mode for pr compatability Kunal Joshi
2023-10-25 14:27 [igt-dev] [PATCH i-g-t 0/7] extend kms_psr test to validate pr Kunal Joshi
2023-10-25 14:27 ` [igt-dev] [PATCH i-g-t 5/7] lib/igt_psr: modified psr_get_mode for pr compatability Kunal Joshi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=761972b1a6acd4f2d79a5bdb501e3d2bcdb8a4dc.camel@intel.com \
    --to=jouni.hogander@intel.com \
    --cc=arun.r.murthy@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=kunal1.joshi@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.