From: Paolo Bonzini <pbonzini@redhat.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: thuth@redhat.com, famz@redhat.com, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 2/3] checkpatch: bump most warnings to errors
Date: Wed, 10 Aug 2016 03:58:55 -0400 (EDT) [thread overview]
Message-ID: <763282314.776277.1470815935631.JavaMail.zimbra@redhat.com> (raw)
In-Reply-To: <87mvkl2hfb.fsf@dusky.pond.sub.org>
----- Original Message -----
> From: "Markus Armbruster" <armbru@redhat.com>
> To: "Paolo Bonzini" <pbonzini@redhat.com>
> Cc: thuth@redhat.com, famz@redhat.com, qemu-devel@nongnu.org
> Sent: Wednesday, August 10, 2016 9:48:24 AM
> Subject: Re: [Qemu-devel] [PATCH 2/3] checkpatch: bump most warnings to errors
>
> Paolo Bonzini <pbonzini@redhat.com> writes:
>
> >> Paolo Bonzini <pbonzini@redhat.com> writes:
> >>
> >> > This only leaves a warning-level message for extra-long lines, which
> >> > are relatively common and cause patchew to send email that will likely
> >> > be ignored.
> >> >
> >> > Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> >>
> >> Are we ready to give up on illegibly long lines?
> >
> > We have other levels of code review than checkpatch. 80 chars can be
> > illegibly short in some circumstances where 83 or 84 are enough.
>
> Isn't that addressed neatly in your patch? It has a soft and a hard
> limit. Exceeding the hard limit is an error, exceeding the soft limit
> is a warning. I rather liked that. If I remember correctly, the only
> disagreements were about the value of the soft limit.
Yes, indeed. I can respin the patch then.
Paolo
next prev parent reply other threads:[~2016-08-10 7:59 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-09 15:47 [Qemu-devel] [PATCH 0/3] checkpatch tweaks Paolo Bonzini
2016-08-09 15:47 ` [Qemu-devel] [PATCH 1/3] checkpatch: tweak the files in which TABs are checked Paolo Bonzini
2016-08-10 2:06 ` Fam Zheng
2016-08-10 6:46 ` Markus Armbruster
2016-08-10 7:32 ` Cornelia Huck
2016-08-09 15:47 ` [Qemu-devel] [PATCH 2/3] checkpatch: bump most warnings to errors Paolo Bonzini
2016-08-10 6:53 ` Markus Armbruster
2016-08-10 7:08 ` Paolo Bonzini
2016-08-10 7:48 ` Markus Armbruster
2016-08-10 7:58 ` Paolo Bonzini [this message]
2016-08-10 7:48 ` Cornelia Huck
2016-08-10 7:46 ` Cornelia Huck
2016-08-10 7:58 ` Paolo Bonzini
2016-08-09 15:47 ` [Qemu-devel] [PATCH 3/3] checkpatch: default to success if only warnings Paolo Bonzini
2016-08-10 2:10 ` [Qemu-devel] [PATCH 0/3] checkpatch tweaks Fam Zheng
2016-08-10 7:15 ` Christian Borntraeger
2016-08-10 7:52 ` Cornelia Huck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=763282314.776277.1470815935631.JavaMail.zimbra@redhat.com \
--to=pbonzini@redhat.com \
--cc=armbru@redhat.com \
--cc=famz@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.