From: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
To: Michael Ellerman <mpe@ellerman.id.au>,
Shuah Khan <skhan@linuxfoundation.org>
Cc: linux-kselftest <linux-kselftest@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
paulmck <paulmck@kernel.org>, Boqun Feng <boqun.feng@gmail.com>
Subject: Re: [PATCH] selftests/rseq: Fix out-of-tree compilation
Date: Thu, 20 Feb 2020 11:16:23 -0500 (EST) [thread overview]
Message-ID: <763647628.2256.1582215383750.JavaMail.zimbra@efficios.com> (raw)
In-Reply-To: <20200220113748.15990-1-mpe@ellerman.id.au>
----- On Feb 20, 2020, at 6:37 AM, Michael Ellerman mpe@ellerman.id.au wrote:
> Currently if you build with O=... the rseq tests don't build:
>
> $ make O=$PWD/output -C tools/testing/selftests/ TARGETS=rseq
> make: Entering directory '/linux/tools/testing/selftests'
> ...
> make[1]: Entering directory '/linux/tools/testing/selftests/rseq'
> gcc -O2 -Wall -g -I./ -I../../../../usr/include/ -L./ -Wl,-rpath=./ -shared
> -fPIC rseq.c -lpthread -o /linux/output/rseq/librseq.so
> gcc -O2 -Wall -g -I./ -I../../../../usr/include/ -L./ -Wl,-rpath=./
> basic_test.c -lpthread -lrseq -o /linux/output/rseq/basic_test
> /usr/bin/ld: cannot find -lrseq
> collect2: error: ld returned 1 exit status
>
> This is because the library search path points to the source
> directory, not the output.
>
> We can fix it by changing the library search path to $(OUTPUT).
Good catch!
Acked-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Shuah, can you pick this up please ?
Thanks,
Mathieu
>
> Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
> ---
>
> This works in all cases.
>
> With O= set:
>
> $ make O=$PWD/output -C tools/testing/selftests/ TARGETS=rseq
> ...
> make[1]: Entering directory '/linux/tools/testing/selftests/rseq'
> gcc -O2 -Wall -g -I./ -I../../../../usr/include/ -L/linux/output/rseq
> -Wl,-rpath=./ basic_test.c -lpthread -lrseq -o /linux/output/rseq/basic_test
> gcc -O2 -Wall -g -I./ -I../../../../usr/include/ -L/linux/output/rseq
> -Wl,-rpath=./ basic_percpu_ops_test.c -lpthread -lrseq -o
> /linux/output/rseq/basic_percpu_ops_test
> gcc -O2 -Wall -g -I./ -I../../../../usr/include/ -L/linux/output/rseq
> -Wl,-rpath=./ param_test.c -lpthread -lrseq -o /linux/output/rseq/param_test
> gcc -O2 -Wall -g -I./ -I../../../../usr/include/ -L/linux/output/rseq
> -Wl,-rpath=./ -DBENCHMARK param_test.c -lpthread -lrseq -o
> /linux/output/rseq/param_test_benchmark
> gcc -O2 -Wall -g -I./ -I../../../../usr/include/ -L/linux/output/rseq
> -Wl,-rpath=./ -DRSEQ_COMPARE_TWICE param_test.c -lpthread -lrseq -o
> /linux/output/rseq/param_test_compare_twice
> make[1]: Leaving directory '/linux/tools/testing/selftests/rseq'
> make: Leaving directory '/linux/tools/testing/selftests'
>
> And also without, in which case the selftest makefiles set OUTPUT to
> the full path of the source directory:
>
> $ make -C tools/testing/selftests/ TARGETS=rseq
> ...
> make[1]: Entering directory '/linux/tools/testing/selftests/rseq'
> gcc -O2 -Wall -g -I./ -I../../../../usr/include/
> -L/linux/tools/testing/selftests/rseq -Wl,-rpath=./ -shared -fPIC rseq.c
> -lpthread -o /linux/tools/testing/selftests/rseq/librseq.so
> gcc -O2 -Wall -g -I./ -I../../../../usr/include/
> -L/linux/tools/testing/selftests/rseq -Wl,-rpath=./ basic_test.c -lpthread
> -lrseq -o /linux/tools/testing/selftests/rseq/basic_test
> gcc -O2 -Wall -g -I./ -I../../../../usr/include/
> -L/linux/tools/testing/selftests/rseq -Wl,-rpath=./ basic_percpu_ops_test.c
> -lpthread -lrseq -o /linux/tools/testing/selftests/rseq/basic_percpu_ops_test
> gcc -O2 -Wall -g -I./ -I../../../../usr/include/
> -L/linux/tools/testing/selftests/rseq -Wl,-rpath=./ param_test.c -lpthread
> -lrseq -o /linux/tools/testing/selftests/rseq/param_test
> gcc -O2 -Wall -g -I./ -I../../../../usr/include/
> -L/linux/tools/testing/selftests/rseq -Wl,-rpath=./ -DBENCHMARK param_test.c
> -lpthread -lrseq -o /linux/tools/testing/selftests/rseq/param_test_benchmark
> gcc -O2 -Wall -g -I./ -I../../../../usr/include/
> -L/linux/tools/testing/selftests/rseq -Wl,-rpath=./ -DRSEQ_COMPARE_TWICE
> param_test.c -lpthread -lrseq -o
> /linux/tools/testing/selftests/rseq/param_test_compare_twice
> make[1]: Leaving directory '/linux/tools/testing/selftests/rseq'
> make: Leaving directory '/linux/tools/testing/selftests'
>
> And finally, it also works if you build directly in the rseq
> directory, eg:
>
> $ cd tools/testing/selftests/rseq
> $ make
> gcc -O2 -Wall -g -I./ -I../../../../usr/include/
> -L/linux/tools/testing/selftests/rseq -Wl,-rpath=./ -shared -fPIC rseq.c
> -lpthread -o /linux/tools/testing/selftests/rseq/librseq.so
> gcc -O2 -Wall -g -I./ -I../../../../usr/include/
> -L/linux/tools/testing/selftests/rseq -Wl,-rpath=./ basic_test.c -lpthread
> -lrseq -o /linux/tools/testing/selftests/rseq/basic_test
> gcc -O2 -Wall -g -I./ -I../../../../usr/include/
> -L/linux/tools/testing/selftests/rseq -Wl,-rpath=./ basic_percpu_ops_test.c
> -lpthread -lrseq -o /linux/tools/testing/selftests/rseq/basic_percpu_ops_test
> gcc -O2 -Wall -g -I./ -I../../../../usr/include/
> -L/linux/tools/testing/selftests/rseq -Wl,-rpath=./ param_test.c -lpthread
> -lrseq -o /linux/tools/testing/selftests/rseq/param_test
> gcc -O2 -Wall -g -I./ -I../../../../usr/include/
> -L/linux/tools/testing/selftests/rseq -Wl,-rpath=./ -DBENCHMARK param_test.c
> -lpthread -lrseq -o /linux/tools/testing/selftests/rseq/param_test_benchmark
> gcc -O2 -Wall -g -I./ -I../../../../usr/include/
> -L/linux/tools/testing/selftests/rseq -Wl,-rpath=./ -DRSEQ_COMPARE_TWICE
> param_test.c -lpthread -lrseq -o
> /linux/tools/testing/selftests/rseq/param_test_compare_twice
> ---
> tools/testing/selftests/rseq/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/testing/selftests/rseq/Makefile
> b/tools/testing/selftests/rseq/Makefile
> index d6469535630a..708c1b345245 100644
> --- a/tools/testing/selftests/rseq/Makefile
> +++ b/tools/testing/selftests/rseq/Makefile
> @@ -4,7 +4,7 @@ ifneq ($(shell $(CC) --version 2>&1 | head -n 1 | grep clang),)
> CLANG_FLAGS += -no-integrated-as
> endif
>
> -CFLAGS += -O2 -Wall -g -I./ -I../../../../usr/include/ -L./ -Wl,-rpath=./ \
> +CFLAGS += -O2 -Wall -g -I./ -I../../../../usr/include/ -L$(OUTPUT)
> -Wl,-rpath=./ \
> $(CLANG_FLAGS)
> LDLIBS += -lpthread
>
>
> base-commit: 11a48a5a18c63fd7621bb050228cebf13566e4d8
> --
> 2.21.1
--
Mathieu Desnoyers
EfficiOS Inc.
http://www.efficios.com
next prev parent reply other threads:[~2020-02-20 16:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-20 11:37 [PATCH] selftests/rseq: Fix out-of-tree compilation Michael Ellerman
2020-02-20 16:16 ` Mathieu Desnoyers [this message]
2020-02-20 16:17 ` Shuah Khan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=763647628.2256.1582215383750.JavaMail.zimbra@efficios.com \
--to=mathieu.desnoyers@efficios.com \
--cc=boqun.feng@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=mpe@ellerman.id.au \
--cc=paulmck@kernel.org \
--cc=peterz@infradead.org \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.