From: Eric Blake <eblake@redhat.com>
To: "Michael S. Tsirkin" <mst@redhat.com>, qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org, Juan Quintela <quintela@redhat.com>,
"Dr. David Alan Gilbert" <dgilbert@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v2 04/20] migration: drop an unused include
Date: Fri, 25 May 2018 13:27:50 -0500 [thread overview]
Message-ID: <764a90d2-e7e2-e692-30fd-912fc0f24438@redhat.com> (raw)
In-Reply-To: <1527266793-301361-5-git-send-email-mst@redhat.com>
On 05/25/2018 11:47 AM, Michael S. Tsirkin wrote:
> we just need a struct name, let's add a forward
> declaration instead of an include.
>
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> ---
> include/migration/vmstate.h | 2 +-
> migration/savevm.c | 1 +
> 2 files changed, 2 insertions(+), 1 deletion(-)
I'm okay with the patch as-is, but the commit message could possibly be
improved:
In the vmstate.h file, we just need a struct name. Use a forward
declaration instead of an include, then adjust the one affected .c file
to include the file that is no longer implicit from the header.
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
next prev parent reply other threads:[~2018-05-25 18:27 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-25 16:47 [Qemu-devel] [PATCH v2 00/20] include cleanups Michael S. Tsirkin
2018-05-25 16:47 ` [Qemu-devel] [PATCH v2 01/20] block: use local path for local headers Michael S. Tsirkin
2018-05-25 18:25 ` Eric Blake
2018-05-25 21:41 ` Philippe Mathieu-Daudé
2018-05-25 16:47 ` [Qemu-devel] [PATCH v2 02/20] crypto: " Michael S. Tsirkin
2018-05-25 21:40 ` Philippe Mathieu-Daudé
2018-06-01 12:22 ` Daniel P. Berrangé
2018-05-25 16:47 ` [Qemu-devel] [PATCH v2 03/20] hppa: " Michael S. Tsirkin
2018-05-25 16:47 ` [Qemu-devel] [PATCH v2 04/20] migration: drop an unused include Michael S. Tsirkin
2018-05-25 18:27 ` Eric Blake [this message]
2018-05-25 16:47 ` [Qemu-devel] [PATCH v2 06/20] display: use local path for local headers Michael S. Tsirkin
2018-05-25 16:47 ` [Qemu-devel] [PATCH v2 05/20] trace: " Michael S. Tsirkin
2018-05-25 21:29 ` Philippe Mathieu-Daudé
2018-05-25 21:49 ` Michael S. Tsirkin
2018-05-25 16:47 ` [Qemu-devel] [PATCH v2 07/20] ide: " Michael S. Tsirkin
2018-05-25 21:39 ` Philippe Mathieu-Daudé
2018-05-25 16:47 ` [Qemu-devel] [PATCH v2 08/20] ioapic: fix up includes Michael S. Tsirkin
2018-05-25 21:37 ` Philippe Mathieu-Daudé
2018-05-25 16:47 ` [Qemu-devel] [PATCH v2 09/20] e1000e: use local path for local headers Michael S. Tsirkin
2018-05-25 21:36 ` Philippe Mathieu-Daudé
2018-05-25 16:47 ` [Qemu-devel] [PATCH v2 10/20] rocker: drop an unused include Michael S. Tsirkin
2018-05-25 21:34 ` Philippe Mathieu-Daudé
2018-05-25 16:47 ` [Qemu-devel] [PATCH v2 11/20] ppc: use local path for local headers Michael S. Tsirkin
2018-05-25 22:43 ` Philippe Mathieu-Daudé
2018-05-25 16:47 ` [Qemu-devel] [PATCH v2 12/20] vhost-scsi: drop an unused include Michael S. Tsirkin
2018-05-26 4:29 ` Philippe Mathieu-Daudé
2018-05-25 16:48 ` [Qemu-devel] [PATCH v2 14/20] usb: use local path for local headers Michael S. Tsirkin
2018-05-25 21:35 ` Philippe Mathieu-Daudé
2018-05-25 16:48 ` [Qemu-devel] [PATCH v2 13/20] sd: fix up include Michael S. Tsirkin
2018-05-25 21:31 ` Philippe Mathieu-Daudé
2018-05-25 16:48 ` [Qemu-devel] [PATCH v2 15/20] migration: use local path for local headers Michael S. Tsirkin
2018-05-25 18:24 ` Eric Blake
2018-05-25 20:56 ` Michael S. Tsirkin
2018-05-25 18:27 ` Juan Quintela
2018-05-25 20:57 ` Michael S. Tsirkin
2018-05-25 16:48 ` [Qemu-devel] [PATCH v2 16/20] colo: " Michael S. Tsirkin
2018-05-26 4:31 ` Philippe Mathieu-Daudé
2018-05-25 16:48 ` [Qemu-devel] [PATCH v2 17/20] qga: " Michael S. Tsirkin
2018-05-25 16:48 ` [Qemu-devel] [PATCH v2 18/20] trace: " Michael S. Tsirkin
2018-05-25 21:32 ` Philippe Mathieu-Daudé
2018-05-25 16:48 ` [Qemu-devel] [PATCH v2 19/20] ui: " Michael S. Tsirkin
2018-05-25 16:48 ` [Qemu-devel] [PATCH v2 20/20] arch_init: sort architectures Michael S. Tsirkin
2018-05-28 11:13 ` Laszlo Ersek
2018-05-25 18:32 ` [Qemu-devel] [PATCH v2 00/20] include cleanups Eric Blake
2018-05-25 21:54 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=764a90d2-e7e2-e692-30fd-912fc0f24438@redhat.com \
--to=eblake@redhat.com \
--cc=dgilbert@redhat.com \
--cc=mst@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.