From: Damien Le Moal <dlemoal@kernel.org>
To: Christoph Hellwig <hch@lst.de>, Jens Axboe <axboe@kernel.dk>
Cc: linux-block@vger.kernel.org
Subject: Re: [PATCH 4/5] null_blk: remove null_gendisk_register
Date: Wed, 14 Feb 2024 20:30:37 +0900 [thread overview]
Message-ID: <764c5522-6fe2-471f-aaa5-3dc43793b3d0@kernel.org> (raw)
In-Reply-To: <20240214095501.1883819-5-hch@lst.de>
On 2/14/24 18:55, Christoph Hellwig wrote:
> null_gendisk_register isn't a very useful abstraction given that it
> doesn't even allocate the gendisk. Merge it into the only caller
> instead.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
Looks good to me.
Reviewed-by: Damien Le Moal <dlemoal@kernel.org>
--
Damien Le Moal
Western Digital Research
next prev parent reply other threads:[~2024-02-14 11:30 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-14 9:54 drop bio mode from null_blk and convert it to atomic queue limits Christoph Hellwig
2024-02-14 9:54 ` [PATCH 1/5] null_blk: remove the bio based I/O path Christoph Hellwig
2024-02-14 11:25 ` Damien Le Moal
2024-02-14 17:25 ` Keith Busch
2024-02-14 23:16 ` Damien Le Moal
2024-02-14 23:34 ` Keith Busch
2024-02-15 8:05 ` Christoph Hellwig
2024-02-14 9:54 ` [PATCH 2/5] null_blk: initialize the tag_set timeout in null_init_tag_set Christoph Hellwig
2024-02-14 11:26 ` Damien Le Moal
2024-02-14 9:54 ` [PATCH 3/5] null_blk: refactor tag_set setup Christoph Hellwig
2024-02-14 11:29 ` Damien Le Moal
2024-02-14 9:55 ` [PATCH 4/5] null_blk: remove null_gendisk_register Christoph Hellwig
2024-02-14 11:30 ` Damien Le Moal [this message]
2024-02-14 9:55 ` [PATCH 5/5] null_blk: pass queue_limits to blk_mq_alloc_disk Christoph Hellwig
2024-02-14 11:32 ` Damien Le Moal
2024-02-14 14:08 ` drop bio mode from null_blk and convert it to atomic queue limits Johannes Thumshirn
-- strict thread matches above, loose matches on Subject: below --
2024-02-19 6:29 drop bio mode from null_blk and convert it to atomic queue limits v2 Christoph Hellwig
2024-02-19 6:29 ` [PATCH 4/5] null_blk: remove null_gendisk_register Christoph Hellwig
2024-02-20 5:32 drop bio mode from null_blk and convert it to atomic queue limits v3 Christoph Hellwig
2024-02-20 5:33 ` [PATCH 4/5] null_blk: remove null_gendisk_register Christoph Hellwig
2024-02-20 7:22 ` Hannes Reinecke
2024-02-20 9:32 drop bio mode from null_blk and convert it to atomic queue limits v4 Christoph Hellwig
2024-02-20 9:32 ` [PATCH 4/5] null_blk: remove null_gendisk_register Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=764c5522-6fe2-471f-aaa5-3dc43793b3d0@kernel.org \
--to=dlemoal@kernel.org \
--cc=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.