From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by gabe.freedesktop.org (Postfix) with ESMTPS id F1F7010E699 for ; Tue, 6 Sep 2022 14:18:10 +0000 (UTC) Message-ID: <764ca94c-1be9-71a1-bf2d-f494c1da1382@intel.com> Date: Tue, 6 Sep 2022 17:18:03 +0300 Content-Language: en-US To: Umesh Nerlige Ramappa , References: <20220823183036.5270-1-umesh.nerlige.ramappa@intel.com> <20220823183036.5270-20-umesh.nerlige.ramappa@intel.com> From: Lionel Landwerlin In-Reply-To: <20220823183036.5270-20-umesh.nerlige.ramappa@intel.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Subject: Re: [igt-dev] [PATCH i-g-t 19/23] i915/perf: Wait longer for rc6 residency in DG2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" List-ID: On 23/08/2022 21:30, Umesh Nerlige Ramappa wrote: > igt@perf@rc6-disable waits for 50ms to check if we entered rc6. One some > failures this seems to take longer to enter rc6, about 100ms. Tweak the > test for DG2 to use a longer wait time. > > Signed-off-by: Umesh Nerlige Ramappa Acked-by: Lionel Landwerlin > --- > tests/i915/perf.c | 9 ++++++--- > 1 file changed, 6 insertions(+), 3 deletions(-) > > diff --git a/tests/i915/perf.c b/tests/i915/perf.c > index 6951735b..3ddfe587 100644 > --- a/tests/i915/perf.c > +++ b/tests/i915/perf.c > @@ -4441,7 +4441,10 @@ test_rc6_disable(void) > .properties_ptr = to_user_pointer(properties), > }; > unsigned long rc6_start, rc6_end, rc6_enabled; > + uint32_t rc6_duration; > > + /* On DG2, we wait longer to enter rc6 */ > + rc6_duration = IS_DG2(devid) ? 100000 : 50000; > rc6_enabled = 0; > igt_sysfs_rps_scanf(sysfs, RC6_ENABLE, "%lu", &rc6_enabled); > igt_require(rc6_enabled); > @@ -4449,7 +4452,7 @@ test_rc6_disable(void) > /* Verify rc6 is functional by measuring residency while idle */ > gem_quiescent_gpu(drm_fd); > rc6_start = rc6_residency_ms(); > - usleep(50000); > + usleep(rc6_duration); > rc6_end = rc6_residency_ms(); > igt_require(rc6_end != rc6_start); > > @@ -4457,7 +4460,7 @@ test_rc6_disable(void) > stream_fd = __perf_open(drm_fd, ¶m, false); > > rc6_start = rc6_residency_ms(); > - usleep(50000); > + usleep(rc6_duration); > rc6_end = rc6_residency_ms(); > igt_assert_eq(rc6_end - rc6_start, 0); > > @@ -4466,7 +4469,7 @@ test_rc6_disable(void) > > /* But once OA is closed, we expect the device to sleep again */ > rc6_start = rc6_residency_ms(); > - usleep(50000); > + usleep(rc6_duration); > rc6_end = rc6_residency_ms(); > igt_assert_neq(rc6_end - rc6_start, 0); > }