From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 54F3CC4338F for ; Thu, 29 Jul 2021 18:55:55 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1C1BE601FF for ; Thu, 29 Jul 2021 18:55:55 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 1C1BE601FF Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 53FFE6EE23; Thu, 29 Jul 2021 18:55:54 +0000 (UTC) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by gabe.freedesktop.org (Postfix) with ESMTPS id 34C606EE23 for ; Thu, 29 Jul 2021 18:55:52 +0000 (UTC) X-IronPort-AV: E=McAfee;i="6200,9189,10060"; a="212990844" X-IronPort-AV: E=Sophos;i="5.84,279,1620716400"; d="scan'208";a="212990844" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Jul 2021 11:55:51 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.84,279,1620716400"; d="scan'208";a="518396928" Received: from orsmsx605.amr.corp.intel.com ([10.22.229.18]) by fmsmga002.fm.intel.com with ESMTP; 29 Jul 2021 11:55:50 -0700 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX605.amr.corp.intel.com (10.22.229.18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.4; Thu, 29 Jul 2021 11:55:50 -0700 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10; Thu, 29 Jul 2021 11:55:50 -0700 Received: from orsmsx611.amr.corp.intel.com ([10.22.229.24]) by ORSMSX611.amr.corp.intel.com ([10.22.229.24]) with mapi id 15.01.2242.010; Thu, 29 Jul 2021 11:55:50 -0700 From: "Kasireddy, Vivek" To: Gerd Hoffmann Subject: RE: [RFC v1 4/4] drm/virtio: Probe and implement VIRTIO_GPU_F_OUT_FENCE feature Thread-Topic: [RFC v1 4/4] drm/virtio: Probe and implement VIRTIO_GPU_F_OUT_FENCE feature Thread-Index: AQHXhFPnf4WPYuIB7UWJ+g+lFyoJ86taK4OAgAAh95A= Date: Thu, 29 Jul 2021 18:55:50 +0000 Message-ID: <764ddf2671c847e4b571bebbadf144c1@intel.com> References: <20210729081659.2255499-1-vivek.kasireddy@intel.com> <20210729081659.2255499-5-vivek.kasireddy@intel.com> <20210729095215.ojuojvherbossnhj@sirius.home.kraxel.org> In-Reply-To: <20210729095215.ojuojvherbossnhj@sirius.home.kraxel.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.5.1.3 dlp-reaction: no-action x-originating-ip: [10.1.200.100] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "dri-devel@lists.freedesktop.org" Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi Gerd, >=20 > Hi, >=20 > > + bool has_out_fence; >=20 > > + if (virtio_has_feature(vgdev->vdev, VIRTIO_GPU_F_OUT_FENCE)) { > > + vgdev->has_out_fence =3D true; > > + vgdev->ddev->mode_config.deferred_out_fence =3D true; >=20 > Looks like you don't need has_out_fence, you can just use > vgdev->ddev->mode_config.deferred_out_fence instead. [Kasireddy, Vivek] Right, I don't need has_out_fence; will fix it. Thanks, Vivek >=20 > take care, > Gerd