From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753619AbbBYWZ6 (ORCPT <rfc822;w@1wt.eu>);
	Wed, 25 Feb 2015 17:25:58 -0500
Received: from galahad.ideasonboard.com ([185.26.127.97]:52127 "EHLO
	galahad.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752761AbbBYWZz (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Wed, 25 Feb 2015 17:25:55 -0500
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Sudeep Holla <sudeep.holla@arm.com>
Cc: Felipe Balbi <balbi@ti.com>, linux-kernel@vger.kernel.org,
        linux-usb@vger.kernel.org,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: Re: [PATCH] usb: isp1760: fix peripheral/device controller chip id
Date: Thu, 26 Feb 2015 00:27 +0200
Message-ID: <7662882.E4UNjpCumE@avalon>
User-Agent: KMail/4.14.3 (Linux/3.18.7-gentoo; KDE/4.14.3; x86_64; ; )
In-Reply-To: <1424800422-25332-1-git-send-email-sudeep.holla@arm.com>
References: <1424800422-25332-1-git-send-email-sudeep.holla@arm.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Sudeep,

Thank you for the patch.

On Tuesday 24 February 2015 17:53:42 Sudeep Holla wrote:
> As per the ISP1761 data sheet, the DcChipID register represents
> the hardware version number (0015h) and the chip ID (8210h) for the
> Peripheral Controller.
> 
> This patch fixes the chip ID value used to verify the controller.
> 
> Cc: Felipe Balbi <balbi@ti.com>
> Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
> ---
>  drivers/usb/isp1760/isp1760-udc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> Hi Laurent,
> 
> I found that the chip ID is wrong when I tried testing OTG on vexpress
> platforms. As per Section 10.8.2 DcChipID register in [1], it should be
> 0x00158210.

On the other hand, http://www.nxp.com/documents/data_sheet/SAF1761.pdf#120 
uses 0x00011582. It looks like we need to accept both.

> It's still not functional, I will follow up with the logs separately.
> 
> Regards,
> Sudeep
> [1]
> http://ridl.cfd.rit.edu/products/manuals/Altera/DE3_v.1.7_CDROM/Datasheet/U
> SB/ISP1761.pdf#G2148521
> 
> diff --git a/drivers/usb/isp1760/isp1760-udc.c
> b/drivers/usb/isp1760/isp1760-udc.c index 9612d7990565..87a8dc044fce 100644
> --- a/drivers/usb/isp1760/isp1760-udc.c
> +++ b/drivers/usb/isp1760/isp1760-udc.c
> @@ -1411,7 +1411,7 @@ static int isp1760_udc_init(struct isp1760_udc *udc)
>  		return -ENODEV;
>  	}
> 
> -	if (chipid != 0x00011582) {
> +	if (chipid != 0x00158210) {
>  		dev_err(udc->isp->dev, "udc: invalid chip ID 0x%08x\n", chipid);
>  		return -ENODEV;
>  	}

-- 
Regards,

Laurent Pinchart