From: Paolo Bonzini <pbonzini@redhat.com>
To: raspl@linux.vnet.ibm.com
Cc: kvm@vger.kernel.org, rkrcmar@redhat.com, frankja@linux.vnet.ibm.com
Subject: Re: [PATCH 04/17] tools/kvm_stat: fix misc glitches
Date: Fri, 10 Mar 2017 03:14:17 -0500 (EST) [thread overview]
Message-ID: <766744941.327830.1489133657474.JavaMail.zimbra@redhat.com> (raw)
In-Reply-To: <4929cf77-378b-7183-9b69-7f6cfeecb077@linux.vnet.ibm.com>
----- Original Message -----
> From: "Stefan Raspl" <raspl@linux.vnet.ibm.com>
> To: "Paolo Bonzini" <pbonzini@redhat.com>, kvm@vger.kernel.org
> Cc: rkrcmar@redhat.com, frankja@linux.vnet.ibm.com
> Sent: Friday, March 10, 2017 7:04:46 AM
> Subject: Re: [PATCH 04/17] tools/kvm_stat: fix misc glitches
>
> On 09.03.2017 17:51, Paolo Bonzini wrote:
> >
> >
> > On 20/02/2017 16:41, Stefan Raspl wrote:
> >> @@ -339,8 +338,7 @@ def get_filters():
> >> filters['kvm_exit'] = ('exit_reason', ARCH.exit_reasons)
> >> return filters
> >>
> >> -libc = ctypes.CDLL('libc.so.6', use_errno=True)
> >> -syscall = libc.syscall
> >> +syscall = ctypes.CDLL('libc.so.6', use_errno=True).syscall
> >>
> >> class perf_event_attr(ctypes.Structure):
> >> """Struct that holds the necessary data to set up a trace event.
> >> @@ -950,11 +948,10 @@ class Tui(object):
> >> while True:
> >> self.refresh(sleeptime)
> >> curses.halfdelay(int(sleeptime * 10))
> >> - sleeptime = 3
> >> + sleeptime = 3.
> >> try:
> >> char = self.screen.getkey()
> >> if char == 'x':
> >> - self.drilldown = not self.drilldown
> >> self.update_drilldown()
> >> if char == 'q':
> >> break
> >
> > I'm not sure I understand the point of these; the rest is fine.
>
> 'sleeptime' starts out as a float (sleeptime = 0.25), but is here
> re-defined to an int - so we make it float all the way.
> The variable 'drilldown' is never used, so we remove its
> initialization in __init__() and the sole place where it is ever
> used, which is the line above.
Yes, I was referring to libc and sleeptime. I don't like the
"3.", especially since Python 3 has "3/2" return a float. Is
this a PEP8 complaint? Does it still complain if you do
"from __future__ import division"?
Paolo
next prev parent reply other threads:[~2017-03-10 8:14 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-20 15:41 [PATCH 00/17] tools/kvm_stat: Misc Patches Stefan Raspl
2017-02-20 15:41 ` [PATCH 01/17] tools/kvm_stat: hide cursor Stefan Raspl
2017-02-20 15:41 ` [PATCH 02/17] tools/kvm_stat: catch curses exceptions only Stefan Raspl
2017-02-20 15:41 ` [PATCH 03/17] tools/kvm_stat: handle SIGINT in log and batch modes Stefan Raspl
2017-02-20 15:41 ` [PATCH 04/17] tools/kvm_stat: fix misc glitches Stefan Raspl
2017-03-09 16:51 ` Paolo Bonzini
2017-03-10 6:04 ` Stefan Raspl
2017-03-10 8:14 ` Paolo Bonzini [this message]
2017-03-10 8:33 ` Stefan Raspl
2017-03-10 8:38 ` Paolo Bonzini
2017-03-10 9:42 ` Stefan Raspl
2017-03-10 10:05 ` Paolo Bonzini
2017-02-20 15:41 ` [PATCH 05/17] tools/kvm_stat: fix trace setup glitch on field updates in TracepointProvider Stefan Raspl
2017-02-20 15:42 ` [PATCH 06/17] tools/kvm_stat: full PEP8 compliance Stefan Raspl
2017-02-20 15:42 ` [PATCH 07/17] tools/kvm_stat: reduce perceived idle time on filter updates Stefan Raspl
2017-03-09 16:54 ` Paolo Bonzini
2017-02-20 15:42 ` [PATCH 08/17] tools/kvm_stat: document list of interactive commands Stefan Raspl
2017-02-20 15:42 ` [PATCH 09/17] tools/kvm_stat: display guest name when using pid filter Stefan Raspl
2017-03-09 16:54 ` Paolo Bonzini
2017-03-10 6:08 ` Stefan Raspl
2017-02-20 15:42 ` [PATCH 10/17] tools/kvm_stat: remove pid filter on empty input Stefan Raspl
2017-02-20 15:42 ` [PATCH 11/17] tools/kvm_stat: print error messages on faulty pid filter input Stefan Raspl
2017-02-20 15:42 ` [PATCH 12/17] tools/kvm_stat: display regex when set to non-default Stefan Raspl
2017-02-20 15:42 ` [PATCH 13/17] tools/kvm_stat: remove regex filter on empty input Stefan Raspl
2017-02-20 15:42 ` [PATCH 14/17] tools/kvm_stat: add option '--guest' Stefan Raspl
2017-03-10 11:52 ` Janosch Frank
2017-02-20 15:42 ` [PATCH 15/17] tools/kvm_stat: add interactive command 'c' Stefan Raspl
2017-02-20 15:42 ` [PATCH 16/17] tools/kvm_stat: add interactive command 'r' Stefan Raspl
2017-03-10 11:37 ` Janosch Frank
2017-03-10 12:32 ` Stefan Raspl
2017-02-20 15:42 ` [PATCH 17/17] tools/kvm_stat: add '%Total' column Stefan Raspl
2017-03-06 8:08 ` [PATCH 00/17] tools/kvm_stat: Misc Patches Stefan Raspl
2017-03-06 16:05 ` Paolo Bonzini
2017-03-09 17:00 ` Paolo Bonzini
2017-03-10 6:13 ` Stefan Raspl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=766744941.327830.1489133657474.JavaMail.zimbra@redhat.com \
--to=pbonzini@redhat.com \
--cc=frankja@linux.vnet.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=raspl@linux.vnet.ibm.com \
--cc=rkrcmar@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.