From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon@6wind.com>
Subject: Re: [PATCH] drivers: make driver names consistent
Date: Fri, 16 Sep 2016 11:58:09 +0200
Message-ID: <7677934.dvmb0F7Vh7@xps13>
References: <1472077494-164532-1-git-send-email-pablo.de.lara.guarch@intel.com>
 <B27915DBBA3421428155699D51E4CFE2025CE4E8@IRSMSX103.ger.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org, "Mcnamara, John" <john.mcnamara@intel.com>
To: "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wm0-f41.google.com (mail-wm0-f41.google.com [74.125.82.41])
 by dpdk.org (Postfix) with ESMTP id 3BB60592A
 for <dev@dpdk.org>; Fri, 16 Sep 2016 11:58:11 +0200 (CEST)
Received: by mail-wm0-f41.google.com with SMTP id 1so31476204wmz.1
 for <dev@dpdk.org>; Fri, 16 Sep 2016 02:58:11 -0700 (PDT)
In-Reply-To: <B27915DBBA3421428155699D51E4CFE2025CE4E8@IRSMSX103.ger.corp.intel.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

2016-08-24 22:37, Mcnamara, John:
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Pablo de Lara
> >
> > ...
> >
> > -    $RTE_TARGET/app/testpmd -c '0xf' -n 4 --vdev 'eth_pcap0,rx_pcap=/path/to/ file_rx.pcap,tx_pcap=/path/to/file_tx.pcap' -- --port-topology=chained
> > +    $RTE_TARGET/app/testpmd -c '0xf' -n 4 --vdev 'net_pcap0,rx_pcap=/path/to/ file_rx.pcap,tx_pcap=/path/to/file_tx.pcap' -- --port-topology=chained
> 
> 
> I know that this is an existing issue but there shouldn't be a space in
> "/path/to/ file". Perhaps you could fix that (in a number of places) as part
> of this patch. You could probably leave out the "/path/to/" part altogether as 
> it may be clearer, see below.
> 
> Also, could you wrap the long code lines in the sections that you change at 
> 80 chars using "\" to keep them on the page in the PDF docs, like:
> 
>     $RTE_TARGET/app/testpmd -c '0xf' -n 4 \
>         --vdev 'net_pcap0,rx_pcap=/path/to/file_rx.pcap,tx_pcap=/path/to/file_tx.pcap' \
>         -- --port-topology=chained
> 
> Or without the path part:
> 
>     $RTE_TARGET/app/testpmd -c '0xf' -n 4 \
>         --vdev 'net_pcap0,rx_pcap=file_rx.pcap,tx_pcap=file_tx.pcap' \
>         -- --port-topology=chained

Applied with above comments fixed and release notes updated, thanks.