From mboxrd@z Thu Jan 1 00:00:00 1970 From: frowand.list at gmail.com (Frank Rowand) Date: Thu, 21 Mar 2019 18:34:21 -0700 Subject: [RFC v3 18/19] of: unittest: split out a couple of test cases from unittest In-Reply-To: References: <20181128193636.254378-1-brendanhiggins@google.com> <20181128193636.254378-19-brendanhiggins@google.com> <990bfc7d-dc5e-d8d3-c151-9b321ff2ac10@gmail.com> <88fe0546-7850-5bb4-9673-b1aef2dccb3e@gmail.com> <0e311e88-c4d4-e98d-1720-53a04bd526fc@gmail.com> <72cd1c5b-6f68-73ad-c8fd-f3a3268a0529@gmail.com> Message-ID: <767d14bf-3429-58b7-dcbf-c8ef86133265@gmail.com> On 3/21/19 5:22 PM, Frank Rowand wrote: > On 2/27/19 7:52 PM, Brendan Higgins wrote: < snip > >> Now I know that, hermeticity especially, but other features as well >> (test suite summary, error on unused test case function, etc) are not >> actually in KUnit as it is under consideration here. Maybe it would be >> best to save these last two patches (18/19, and 19/19) until I have >> these other features checked in and reconsider them then? > > Thanks for leaving 18/19 and 19/19 off in v4. Oops, they got into v4 but as 16/17 and 17/17, I think. But it sounds like you are planning to leave them out of v5. > > -Frank From mboxrd@z Thu Jan 1 00:00:00 1970 From: frowand.list@gmail.com (Frank Rowand) Date: Thu, 21 Mar 2019 18:34:21 -0700 Subject: [RFC v3 18/19] of: unittest: split out a couple of test cases from unittest In-Reply-To: References: <20181128193636.254378-1-brendanhiggins@google.com> <20181128193636.254378-19-brendanhiggins@google.com> <990bfc7d-dc5e-d8d3-c151-9b321ff2ac10@gmail.com> <88fe0546-7850-5bb4-9673-b1aef2dccb3e@gmail.com> <0e311e88-c4d4-e98d-1720-53a04bd526fc@gmail.com> <72cd1c5b-6f68-73ad-c8fd-f3a3268a0529@gmail.com> Message-ID: <767d14bf-3429-58b7-dcbf-c8ef86133265@gmail.com> Content-Type: text/plain; charset="UTF-8" Message-ID: <20190322013421.L0koTVPzNk8IOGFc1MrYjvf4bK0v5MIjzCV2WqVygxw@z> On 3/21/19 5:22 PM, Frank Rowand wrote: > On 2/27/19 7:52 PM, Brendan Higgins wrote: < snip > >> Now I know that, hermeticity especially, but other features as well >> (test suite summary, error on unused test case function, etc) are not >> actually in KUnit as it is under consideration here. Maybe it would be >> best to save these last two patches (18/19, and 19/19) until I have >> these other features checked in and reconsider them then? > > Thanks for leaving 18/19 and 19/19 off in v4. Oops, they got into v4 but as 16/17 and 17/17, I think. But it sounds like you are planning to leave them out of v5. > > -Frank From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg1-x535.google.com (mail-pg1-x535.google.com [IPv6:2607:f8b0:4864:20::535]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id B2EB4211E2F0F for ; Thu, 21 Mar 2019 18:34:24 -0700 (PDT) Received: by mail-pg1-x535.google.com with SMTP id y3so294783pgk.12 for ; Thu, 21 Mar 2019 18:34:24 -0700 (PDT) Subject: Re: [RFC v3 18/19] of: unittest: split out a couple of test cases from unittest From: Frank Rowand References: <20181128193636.254378-1-brendanhiggins@google.com> <20181128193636.254378-19-brendanhiggins@google.com> <990bfc7d-dc5e-d8d3-c151-9b321ff2ac10@gmail.com> <88fe0546-7850-5bb4-9673-b1aef2dccb3e@gmail.com> <0e311e88-c4d4-e98d-1720-53a04bd526fc@gmail.com> <72cd1c5b-6f68-73ad-c8fd-f3a3268a0529@gmail.com> Message-ID: <767d14bf-3429-58b7-dcbf-c8ef86133265@gmail.com> Date: Thu, 21 Mar 2019 18:34:21 -0700 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-nvdimm-bounces@lists.01.org Sender: "Linux-nvdimm" To: Brendan Higgins Cc: brakmo@fb.com, dri-devel , linux-kselftest@vger.kernel.org, shuah@kernel.org, Rob Herring , linux-nvdimm , Richard Weinberger , Knut Omang , Kieran Bingham , Joel Stanley , Jeff Dike , "Bird," Timothy" , Kees Cook ," linux-um@lists.infradead.org, Steven Rostedt , Julia Lawall , kunit-dev@googlegroups.com, Greg KH , Linux Kernel Mailing List , Luis Chamberlain , Daniel Vetter , Michael Ellerman , Joe Perches , Kevin Hilman List-ID: On 3/21/19 5:22 PM, Frank Rowand wrote: > On 2/27/19 7:52 PM, Brendan Higgins wrote: < snip > >> Now I know that, hermeticity especially, but other features as well >> (test suite summary, error on unused test case function, etc) are not >> actually in KUnit as it is under consideration here. Maybe it would be >> best to save these last two patches (18/19, and 19/19) until I have >> these other features checked in and reconsider them then? > > Thanks for leaving 18/19 and 19/19 off in v4. Oops, they got into v4 but as 16/17 and 17/17, I think. But it sounds like you are planning to leave them out of v5. > > -Frank _______________________________________________ Linux-nvdimm mailing list Linux-nvdimm@lists.01.org https://lists.01.org/mailman/listinfo/linux-nvdimm From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg1-x52c.google.com ([2607:f8b0:4864:20::52c]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1h794k-0003AQ-CK for linux-um@lists.infradead.org; Fri, 22 Mar 2019 01:34:27 +0000 Received: by mail-pg1-x52c.google.com with SMTP id i2so298916pgj.11 for ; Thu, 21 Mar 2019 18:34:25 -0700 (PDT) Subject: Re: [RFC v3 18/19] of: unittest: split out a couple of test cases from unittest From: Frank Rowand References: <20181128193636.254378-1-brendanhiggins@google.com> <20181128193636.254378-19-brendanhiggins@google.com> <990bfc7d-dc5e-d8d3-c151-9b321ff2ac10@gmail.com> <88fe0546-7850-5bb4-9673-b1aef2dccb3e@gmail.com> <0e311e88-c4d4-e98d-1720-53a04bd526fc@gmail.com> <72cd1c5b-6f68-73ad-c8fd-f3a3268a0529@gmail.com> Message-ID: <767d14bf-3429-58b7-dcbf-c8ef86133265@gmail.com> Date: Thu, 21 Mar 2019 18:34:21 -0700 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-um" Errors-To: linux-um-bounces+geert=linux-m68k.org@lists.infradead.org To: Brendan Higgins Cc: brakmo@fb.com, dri-devel , linux-kselftest@vger.kernel.org, shuah@kernel.org, Rob Herring , linux-nvdimm , Richard Weinberger , Knut Omang , Kieran Bingham , Joel Stanley , Jeff Dike , "Bird," Timothy" , Kees Cook ," linux-um@lists.infradead.org, Steven Rostedt , Julia Lawall , Dan Williams , kunit-dev@googlegroups.com, Greg KH , Linux Kernel Mailing List , Luis Chamberlain , Daniel Vetter , Michael Ellerman , Joe Perches , Kevin Hilman On 3/21/19 5:22 PM, Frank Rowand wrote: > On 2/27/19 7:52 PM, Brendan Higgins wrote: < snip > >> Now I know that, hermeticity especially, but other features as well >> (test suite summary, error on unused test case function, etc) are not >> actually in KUnit as it is under consideration here. Maybe it would be >> best to save these last two patches (18/19, and 19/19) until I have >> these other features checked in and reconsider them then? > > Thanks for leaving 18/19 and 19/19 off in v4. Oops, they got into v4 but as 16/17 and 17/17, I think. But it sounds like you are planning to leave them out of v5. > > -Frank _______________________________________________ linux-um mailing list linux-um@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-um From mboxrd@z Thu Jan 1 00:00:00 1970 From: Frank Rowand Subject: Re: [RFC v3 18/19] of: unittest: split out a couple of test cases from unittest Date: Thu, 21 Mar 2019 18:34:21 -0700 Message-ID: <767d14bf-3429-58b7-dcbf-c8ef86133265@gmail.com> References: <20181128193636.254378-1-brendanhiggins@google.com> <20181128193636.254378-19-brendanhiggins@google.com> <990bfc7d-dc5e-d8d3-c151-9b321ff2ac10@gmail.com> <88fe0546-7850-5bb4-9673-b1aef2dccb3e@gmail.com> <0e311e88-c4d4-e98d-1720-53a04bd526fc@gmail.com> <72cd1c5b-6f68-73ad-c8fd-f3a3268a0529@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: linux-nvdimm-bounces-hn68Rpc1hR1g9hUCZPvPmw@public.gmane.org Sender: "Linux-nvdimm" To: Brendan Higgins Cc: brakmo-b10kYP2dOMg@public.gmane.org, dri-devel , linux-kselftest-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, shuah-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, Rob Herring , linux-nvdimm , Richard Weinberger , Knut Omang , Kieran Bingham , Joel Stanley , Jeff Dike , "Bird, Timothy" , Kees Cook , linux-um-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Steven Rostedt , Julia Lawall , kunit-dev-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org, Greg KH , Linux Kernel Mailing List , Luis Chamberlain , Daniel Vetter , Michael Ellerman , Joe Perches , Kevin Hilman List-Id: dri-devel@lists.freedesktop.org On 3/21/19 5:22 PM, Frank Rowand wrote: > On 2/27/19 7:52 PM, Brendan Higgins wrote: < snip > >> Now I know that, hermeticity especially, but other features as well >> (test suite summary, error on unused test case function, etc) are not >> actually in KUnit as it is under consideration here. Maybe it would be >> best to save these last two patches (18/19, and 19/19) until I have >> these other features checked in and reconsider them then? > > Thanks for leaving 18/19 and 19/19 off in v4. Oops, they got into v4 but as 16/17 and 17/17, I think. But it sounds like you are planning to leave them out of v5. > > -Frank From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7E9D2C43381 for ; Fri, 22 Mar 2019 01:34:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4A51A20850 for ; Fri, 22 Mar 2019 01:34:27 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="KWwbDMl9" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727564AbfCVBeZ (ORCPT ); Thu, 21 Mar 2019 21:34:25 -0400 Received: from mail-pg1-f176.google.com ([209.85.215.176]:40682 "EHLO mail-pg1-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727451AbfCVBeZ (ORCPT ); Thu, 21 Mar 2019 21:34:25 -0400 Received: by mail-pg1-f176.google.com with SMTP id u9so310956pgo.7; Thu, 21 Mar 2019 18:34:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:from:to:cc:references:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=8aqHsW8JcapCofl+YH/dCzbvTqp7scjhme0ZJfomfWU=; b=KWwbDMl9Qe+BPtbJbX8KxquzN0eCieYViNZemNQw1CJvLGys81uUIuaX+pexvstUju 344us/BEQUaKlgY4slS6CYAvWXjwrH4ilyMOUMvujcO2Hzo2a9rgjnjUS1VAeHT+AP1X dfoCDk2F4/QWKbyNE9dR9FUoju7gWuZKUFekjIO7NuCQy4+la/NLJ6HloY05ZIt8QJMi Dg/wdh5z25HJACEaIrwwg8UAJJpt6qll/gKEkIJlbEI9X5Xo7lXBXIu9rvPcb6aRVns6 Y0Y/rk4KeOAbDw6w9p+FjVMyRkkmUy+JP9P+lviveZx6I81xrkXOY/aRmUHN3QwbBaZE nldg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:from:to:cc:references:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=8aqHsW8JcapCofl+YH/dCzbvTqp7scjhme0ZJfomfWU=; b=iDqjVkGD7x32Znlp2k2aUIAQnVmX3GEbWLNIN6gYTYCw4PZnWjIw/pXnEiBSoti+fK jGhE5wR3T/AaePhBwpjpEZQ8KGVG0tw+4dab+pFCsJphCyGM7lAf7qRYnKKx7Dy6GfBF YrmWLnBwH4Iy/8Zkuet3hfSG78VX9RC3HLixxDbQg7tmCnMsDlmnsmfya6d8F931a1GK M1Tnlanq2D7UBDORXsrsrwarRwGWgySkX5X1ry1yKzKJCuVq1pMPwGDOBIpnjrk8ZAIe gYCEhCqPYaa8Qpwo9t5VJ9DDeyLYBSBoXQ8HEF0WvWAJ1mOTyhOe+lX/BqR4bUqYpBfP tl3w== X-Gm-Message-State: APjAAAUd36GkN4FvBnoVVSVbh1DSIZiQnnky0kf21sAAYG/M5stgMx+I XeYel0YGXn01MJkZgDosyEM= X-Google-Smtp-Source: APXvYqw7chzlfzrE4CPh7ZUlr4HOfmFJgsZ0XPQxSeMpRfMeW6COrLrwoGJrEwZ+O0IiR43xvv/Rdg== X-Received: by 2002:a63:2bd5:: with SMTP id r204mr6447768pgr.48.1553218463898; Thu, 21 Mar 2019 18:34:23 -0700 (PDT) Received: from [192.168.1.70] (c-24-6-192-50.hsd1.ca.comcast.net. [24.6.192.50]) by smtp.gmail.com with ESMTPSA id w67sm10634754pfw.173.2019.03.21.18.34.21 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 21 Mar 2019 18:34:23 -0700 (PDT) Subject: Re: [RFC v3 18/19] of: unittest: split out a couple of test cases from unittest From: Frank Rowand To: Brendan Higgins Cc: Greg KH , Kees Cook , Luis Chamberlain , shuah@kernel.org, Joel Stanley , Michael Ellerman , Joe Perches , brakmo@fb.com, Steven Rostedt , "Bird, Timothy" , Kevin Hilman , Julia Lawall , linux-kselftest@vger.kernel.org, kunit-dev@googlegroups.com, Linux Kernel Mailing List , Jeff Dike , Richard Weinberger , linux-um@lists.infradead.org, Daniel Vetter , dri-devel , Rob Herring , Dan Williams , linux-nvdimm , Kieran Bingham , Knut Omang References: <20181128193636.254378-1-brendanhiggins@google.com> <20181128193636.254378-19-brendanhiggins@google.com> <990bfc7d-dc5e-d8d3-c151-9b321ff2ac10@gmail.com> <88fe0546-7850-5bb4-9673-b1aef2dccb3e@gmail.com> <0e311e88-c4d4-e98d-1720-53a04bd526fc@gmail.com> <72cd1c5b-6f68-73ad-c8fd-f3a3268a0529@gmail.com> Message-ID: <767d14bf-3429-58b7-dcbf-c8ef86133265@gmail.com> Date: Thu, 21 Mar 2019 18:34:21 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.5.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 3/21/19 5:22 PM, Frank Rowand wrote: > On 2/27/19 7:52 PM, Brendan Higgins wrote: < snip > >> Now I know that, hermeticity especially, but other features as well >> (test suite summary, error on unused test case function, etc) are not >> actually in KUnit as it is under consideration here. Maybe it would be >> best to save these last two patches (18/19, and 19/19) until I have >> these other features checked in and reconsider them then? > > Thanks for leaving 18/19 and 19/19 off in v4. Oops, they got into v4 but as 16/17 and 17/17, I think. But it sounds like you are planning to leave them out of v5. > > -Frank