From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Marvin Liu <yong.liu@intel.com>
Cc: dev@dpdk.org
Subject: Re: [PATCH] examples/vm_power_manager: fix build with libvirt version < 0.9.3
Date: Mon, 11 Apr 2016 09:24:24 +0200 [thread overview]
Message-ID: <76861959.Vz3qnGk6Ag@xps13> (raw)
In-Reply-To: <1460346357-26592-1-git-send-email-yong.liu@intel.com>
2016-04-11 11:45, Marvin Liu:
> vm_power_manager utilize libvirt API virDomainGetVcpuPinInfo for
> retrieve domU vcpu information. This API implemented from version 0.9.3.
> Suse11 SP3 32bit default libvirt version is 0.8.8, so there'll be build
> error. Add judgement in sample Makefile to skip unsupport environment.
>
> examples/vm_power_manager/channel_manager.c: In function
> ‘update_pcpus_mask’:
> channel_manager.c:117:3: error: implicit declaration of function
> ‘virDomainGetVcpuPinInfo’
>
> Fixes: 2e099bc5d104 ("fix split of compiler and linker options")
I think the issue has always been there:
Fixes: e8ae9b662506 ("examples/vm_power: channel manager and monitor in host")
> +LIBVIRT_COMMON = libvirt-common.h
> +LIBVIRT_HEADER = libvirt.h
> +INCLUDE_PATH = /usr/include/libvirt/
You cannot assume it will be installed in this directory.
Please check the version with the standard pkg-config:
pkg-config --atleast-version=0.9.3 libvirt
It can work even in cross compilation environment thanks to PKG_CONFIG_PATH.
next prev parent reply other threads:[~2016-04-11 7:24 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-11 3:45 [PATCH] examples/vm_power_manager: fix build with libvirt version < 0.9.3 Marvin Liu
2016-04-11 7:24 ` Thomas Monjalon [this message]
2016-04-11 8:48 ` Liu, Yong
2016-04-11 8:50 ` [PATCH v2] " Marvin Liu
2016-04-11 9:26 ` Thomas Monjalon
2016-04-11 9:32 ` Thomas Monjalon
2016-04-11 9:46 ` Liu, Yong
2016-04-11 10:06 ` [PATCH v3] " Marvin Liu
2016-04-11 10:32 ` [PATCH v4] examples/vm_power_manager: fix libvirt dependency check Thomas Monjalon
2016-04-11 10:37 ` Bruce Richardson
2016-04-11 10:43 ` [PATCH v5] " Thomas Monjalon
2016-04-11 12:30 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=76861959.Vz3qnGk6Ag@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=dev@dpdk.org \
--cc=yong.liu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.