From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-178.mta1.migadu.com (out-178.mta1.migadu.com [95.215.58.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DA3B32E7365 for ; Fri, 24 Jul 2026 02:27:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=95.215.58.178 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784860059; cv=none; b=l5Mz/fiFhP1TebEMWeoCIlpVCZGq/3qDh+KvyDmWrl63HaTOiqSLCnTHjaxPXJKUxMNidn1KikrltxXaQG8uOtT6mew6f3z7vMLHsDX7VXN0wnBcJH9HI2j8nXcCqgva3j23E7qJmZAe9bflXOwDwsydTUuxOa18jossoBlgxh4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784860059; c=relaxed/simple; bh=fF0i0FAVg7pFFdgGMgSvT9rzj/ilXN9dMGldzf7jZQw=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=i6m0SCq7W1tTQ377iV04toHfgtMSi7P6KHbfJbJIrl01lpnWSiCrQLyUhw3hiVCUCOfvL162LWS94SmqptYBIykzhUdOw2xrQqN8UqfyhqkyuYCk5EPUPPwc+Z/9W6XaawiXc7avnyXHNZj+QalDaBIA+A3UHuCGnfaJ9BxY2KY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=LF6mDkow; arc=none smtp.client-ip=95.215.58.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="LF6mDkow" Message-ID: <76a3a049-fbe4-434b-b4da-0b8cdd154141@linux.dev> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1784860055; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=FShZWoUeiR8yaTtWAzmWYXgtRV6e+45cRzM/BkLtoQI=; b=LF6mDkowv1vF7N4G2MH4TZH4n1BPDHc8Ace0C+zzJUTppm6NTA+vElOa64uZWamdA9+09O 5SPw4EM06Q8u7Ww4HhcH0HtFwLcSbypqkY22VyU5tKWveJvjf0av4+lVX5xjUv3QFsCwkr Xv9fmX2K8+pHkAVXikdm8yO/kV6Gvwg= Date: Fri, 24 Jul 2026 10:27:24 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Subject: Re: [PATCH v3 0/4] mm/vmscan: fix swappiness=max and clean up per-node proactive reclaim To: Andrew Morton Cc: Johannes Weiner , David Hildenbrand , Michal Hocko , Qi Zheng , Shakeel Butt , Lorenzo Stoakes , Kairui Song , Barry Song , Axel Rasmussen , Yuanchu Xie , Wei Xu , Zhongkun He , Muchun Song , Davidlohr Bueso , Roman Gushchin , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Ridong Chen References: <20260723045718.2052070-1-ridong.chen@linux.dev> <20260723171842.137e45eb36b21b3b45245da0@linux-foundation.org> X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Ridong Chen In-Reply-To: <20260723171842.137e45eb36b21b3b45245da0@linux-foundation.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_OUT On 7/24/2026 8:18 AM, Andrew Morton wrote: > On Thu, 23 Jul 2026 12:57:14 +0800 Ridong wrote: > >> Fixes and one cleanup. >> >> Patch 1 fixes "swappiness=max": the anon-only test in get_scan_count() >> sat after the "cannot reclaim anon" check, so when no anon was >> reclaimable the request fell back to SCAN_FILE and evicted page cache >> instead. >> >> Patch 2 fixes reclaim_store() collapsing every error into -EAGAIN, so >> callers can no longer tell an invalid argument from a busy interface; >> propagate the real error code, matching the memcg path. >> >> Patch 3 drops the now-unused gfp_mask parameter from __node_reclaim(). >> >> Patch 4 fixes the same "swappiness=max" issue for MGLRU. > > Thanks. AI review might have found several pre-existing issues which > might interest the maintainers. Also a suggestion against your [4/4]: > > https://sashiko.dev/#/patchset/20260723045718.2052070-1-ridong.chen@linux.dev Thanks. I will update patch 4/4 as suggested. -- Best regards Ridong