From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.0 required=3.0 tests=BAYES_00,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D4E15C433E0 for ; Tue, 5 Jan 2021 09:25:19 +0000 (UTC) Received: from mm01.cs.columbia.edu (mm01.cs.columbia.edu [128.59.11.253]) by mail.kernel.org (Postfix) with ESMTP id 49364225AB for ; Tue, 5 Jan 2021 09:25:18 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 49364225AB Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvmarm-bounces@lists.cs.columbia.edu Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 9B54F4B23A; Tue, 5 Jan 2021 04:25:18 -0500 (EST) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id XTENIz++quHm; Tue, 5 Jan 2021 04:25:17 -0500 (EST) Received: from mm01.cs.columbia.edu (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 7B4054B2D3; Tue, 5 Jan 2021 04:25:17 -0500 (EST) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 44AEC4B23A for ; Tue, 5 Jan 2021 04:25:16 -0500 (EST) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id hVmbcvh+cYeT for ; Tue, 5 Jan 2021 04:25:15 -0500 (EST) Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by mm01.cs.columbia.edu (Postfix) with ESMTPS id 4E6F94B214 for ; Tue, 5 Jan 2021 04:25:15 -0500 (EST) Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id E3B9620756; Tue, 5 Jan 2021 09:25:13 +0000 (UTC) Received: from disco-boy.misterjones.org ([51.254.78.96] helo=www.loen.fr) by disco-boy.misterjones.org with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94) (envelope-from ) id 1kwiaV-005Oa8-O2; Tue, 05 Jan 2021 09:25:11 +0000 MIME-Version: 1.0 Date: Tue, 05 Jan 2021 09:25:11 +0000 From: Marc Zyngier To: Shenming Lu Subject: Re: [RFC PATCH v2 3/4] KVM: arm64: GICv4.1: Restore VLPI's pending state to physical side In-Reply-To: <20210104081613.100-4-lushenming@huawei.com> References: <20210104081613.100-1-lushenming@huawei.com> <20210104081613.100-4-lushenming@huawei.com> User-Agent: Roundcube Webmail/1.4.9 Message-ID: <76a7b9cca485dc8157d3be53189eac69@kernel.org> X-Sender: maz@kernel.org X-SA-Exim-Connect-IP: 51.254.78.96 X-SA-Exim-Rcpt-To: lushenming@huawei.com, eric.auger@redhat.com, will@kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, alex.williamson@redhat.com, cohuck@redhat.com, lorenzo.pieralisi@arm.com, wanghaibin.wang@huawei.com, yuzenghui@huawei.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Cc: Lorenzo Pieralisi , kvm@vger.kernel.org, Cornelia Huck , linux-kernel@vger.kernel.org, Alex Williamson , Will Deacon , kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org X-BeenThere: kvmarm@lists.cs.columbia.edu X-Mailman-Version: 2.1.14 Precedence: list List-Id: Where KVM/ARM decisions are made List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Errors-To: kvmarm-bounces@lists.cs.columbia.edu Sender: kvmarm-bounces@lists.cs.columbia.edu T24gMjAyMS0wMS0wNCAwODoxNiwgU2hlbm1pbmcgTHUgd3JvdGU6Cj4gRnJvbTogWmVuZ2h1aSBZ dSA8eXV6ZW5naHVpQGh1YXdlaS5jb20+Cj4gCj4gV2hlbiBzZXR0aW5nIHRoZSBmb3J3YXJkaW5n IHBhdGggb2YgYSBWTFBJIChzd2l0Y2ggdG8gdGhlIEhXIG1vZGUpLAo+IHdlIGNvdWxkIGFsc28g dHJhbnNmZXIgdGhlIHBlbmRpbmcgc3RhdGUgZnJvbSBpcnEtPnBlbmRpbmdfbGF0Y2ggdG8KPiBW UFQgKGVzcGVjaWFsbHkgaW4gbWlncmF0aW9uLCB0aGUgcGVuZGluZyBzdGF0ZXMgb2YgVkxQSXMg YXJlIHJlc3RvcmVkCj4gaW50byBrdm3igJlzIHZnaWMgZmlyc3QpLiBBbmQgd2UgY3VycmVudGx5 IHNlbmQgIklOVCtWU1lOQyIgdG8gdHJpZ2dlcgo+IGEgVkxQSSB0byBwZW5kaW5nLgo+IAo+IFNp Z25lZC1vZmYtYnk6IFplbmdodWkgWXUgPHl1emVuZ2h1aUBodWF3ZWkuY29tPgo+IFNpZ25lZC1v ZmYtYnk6IFNoZW5taW5nIEx1IDxsdXNoZW5taW5nQGh1YXdlaS5jb20+Cj4gLS0tCj4gIGFyY2gv YXJtNjQva3ZtL3ZnaWMvdmdpYy12NC5jIHwgMTIgKysrKysrKysrKysrCj4gIDEgZmlsZSBjaGFu Z2VkLCAxMiBpbnNlcnRpb25zKCspCj4gCj4gZGlmZiAtLWdpdCBhL2FyY2gvYXJtNjQva3ZtL3Zn aWMvdmdpYy12NC5jIAo+IGIvYXJjaC9hcm02NC9rdm0vdmdpYy92Z2ljLXY0LmMKPiBpbmRleCBm MjExYTdjMzI3MDQuLjc5NDVkNmQwOWNkZCAxMDA2NDQKPiAtLS0gYS9hcmNoL2FybTY0L2t2bS92 Z2ljL3ZnaWMtdjQuYwo+ICsrKyBiL2FyY2gvYXJtNjQva3ZtL3ZnaWMvdmdpYy12NC5jCj4gQEAg LTQ1NCw2ICs0NTQsMTggQEAgaW50IGt2bV92Z2ljX3Y0X3NldF9mb3J3YXJkaW5nKHN0cnVjdCBr dm0gKmt2bSwgCj4gaW50IHZpcnEsCj4gIAlpcnEtPmhvc3RfaXJxCT0gdmlycTsKPiAgCWF0b21p Y19pbmMoJm1hcC52cGUtPnZscGlfY291bnQpOwo+IAo+ICsJLyogVHJhbnNmZXIgcGVuZGluZyBz dGF0ZSAqLwo+ICsJcmV0ID0gaXJxX3NldF9pcnFjaGlwX3N0YXRlKGlycS0+aG9zdF9pcnEsCj4g KwkJCQkgICAgSVJRQ0hJUF9TVEFURV9QRU5ESU5HLAo+ICsJCQkJICAgIGlycS0+cGVuZGluZ19s YXRjaCk7Cj4gKwlXQVJOX1JBVEVMSU1JVChyZXQsICJJUlEgJWQiLCBpcnEtPmhvc3RfaXJxKTsK CldoeSBkbyB0aGlzIGlmIHBlbmRpbmdfbGF0Y2ggaXMgMCwgd2hpY2ggaXMgbGlrZWx5IHRvIGJl CnRoZSBvdmVyd2hlbG1pbmcgY2FzZT8KCj4gKwo+ICsJLyoKPiArCSAqIExldCBpdCBiZSBwcnVu ZWQgZnJvbSBhcF9saXN0IGxhdGVyIGFuZCBkb24ndCBib3RoZXIKPiArCSAqIHRoZSBMaXN0IFJl Z2lzdGVyLgo+ICsJICovCj4gKwlpcnEtPnBlbmRpbmdfbGF0Y2ggPSBmYWxzZTsKCldoYXQgZ3Vh cmFudGVlcyB0aGUgcHJ1bmluZz8gUHJ1bmluZyBvbmx5IGhhcHBlbnMgb24gdmNwdSBleGl0LAp3 aGljaCBtZWFucyB3ZSBtYXkgaGF2ZSB0aGUgc2FtZSBpbnRlcnJ1cHQgdmlhIGJvdGggdGhlIExS IGFuZAp0aGUgc3RyZWFtIGludGVyZmFjZSwgd2hpY2ggSSBkb24ndCBiZWxpZXZlIGlzIGxlZ2Fs IChpdCBpcwpsaWtlIGhhdmluZyB0d28gTFJzIGhvbGRpbmcgdGhlIHNhbWUgaW50ZXJydXB0KS4K Cj4gKwo+ICBvdXQ6Cj4gIAltdXRleF91bmxvY2soJml0cy0+aXRzX2xvY2spOwo+ICAJcmV0dXJu IHJldDsKClRoYW5rcywKCiAgICAgICAgIE0uCi0tIApKYXp6IGlzIG5vdCBkZWFkLiBJdCBqdXN0 IHNtZWxscyBmdW5ueS4uLgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fXwprdm1hcm0gbWFpbGluZyBsaXN0Cmt2bWFybUBsaXN0cy5jcy5jb2x1bWJpYS5lZHUK aHR0cHM6Ly9saXN0cy5jcy5jb2x1bWJpYS5lZHUvbWFpbG1hbi9saXN0aW5mby9rdm1hcm0K From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1219AC433DB for ; Tue, 5 Jan 2021 09:26:33 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B8D3420756 for ; Tue, 5 Jan 2021 09:26:32 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B8D3420756 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Message-ID:References:In-Reply-To:Subject:To:From: Date:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=qZoyWiqpRECHUC8Iai7Y132Wa/qeRDny8qwl7RtntA0=; b=yhfCMjXqz4N2HGYPCC7rSIgph FtydT/ifDxiqH6qfJUWmdlJyDWLgI9Kfeu/iePPKP9L5q00MipwKxKKcIuKMhVj9eI/8bviPkyo1B pzqoN+iXVDdD4Kw94TfzZpbW1Rw9qnTVM1gw47u/bpbz8jOdqgzHOcxa7mIjTmyaa5K7HZIr7XAYp aWKq+94BDXg8eTsRlv0ufAXW1mDKjtkCf5T8Q/C63ZzunXauDNrQgcLA2ScSsOfGSfBM+YnfRpXFp y2S89uUh42ZIsICqLwiUtNJHqxGC7TAXID6/TFAJJhWuc3BqSOr05xXo/arDfVQUcgmQrOeipG73l ky3bfnm8A==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kwiac-0008C3-Ow; Tue, 05 Jan 2021 09:25:18 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kwiaZ-0008BA-Ba for linux-arm-kernel@lists.infradead.org; Tue, 05 Jan 2021 09:25:16 +0000 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id E3B9620756; Tue, 5 Jan 2021 09:25:13 +0000 (UTC) Received: from disco-boy.misterjones.org ([51.254.78.96] helo=www.loen.fr) by disco-boy.misterjones.org with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94) (envelope-from ) id 1kwiaV-005Oa8-O2; Tue, 05 Jan 2021 09:25:11 +0000 MIME-Version: 1.0 Date: Tue, 05 Jan 2021 09:25:11 +0000 From: Marc Zyngier To: Shenming Lu Subject: Re: [RFC PATCH v2 3/4] KVM: arm64: GICv4.1: Restore VLPI's pending state to physical side In-Reply-To: <20210104081613.100-4-lushenming@huawei.com> References: <20210104081613.100-1-lushenming@huawei.com> <20210104081613.100-4-lushenming@huawei.com> User-Agent: Roundcube Webmail/1.4.9 Message-ID: <76a7b9cca485dc8157d3be53189eac69@kernel.org> X-Sender: maz@kernel.org X-SA-Exim-Connect-IP: 51.254.78.96 X-SA-Exim-Rcpt-To: lushenming@huawei.com, eric.auger@redhat.com, will@kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, alex.williamson@redhat.com, cohuck@redhat.com, lorenzo.pieralisi@arm.com, wanghaibin.wang@huawei.com, yuzenghui@huawei.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210105_042515_473848_79924EEB X-CRM114-Status: GOOD ( 18.22 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Lorenzo Pieralisi , kvm@vger.kernel.org, Cornelia Huck , linux-kernel@vger.kernel.org, Eric Auger , Alex Williamson , yuzenghui@huawei.com, wanghaibin.wang@huawei.com, Will Deacon , kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gMjAyMS0wMS0wNCAwODoxNiwgU2hlbm1pbmcgTHUgd3JvdGU6Cj4gRnJvbTogWmVuZ2h1aSBZ dSA8eXV6ZW5naHVpQGh1YXdlaS5jb20+Cj4gCj4gV2hlbiBzZXR0aW5nIHRoZSBmb3J3YXJkaW5n IHBhdGggb2YgYSBWTFBJIChzd2l0Y2ggdG8gdGhlIEhXIG1vZGUpLAo+IHdlIGNvdWxkIGFsc28g dHJhbnNmZXIgdGhlIHBlbmRpbmcgc3RhdGUgZnJvbSBpcnEtPnBlbmRpbmdfbGF0Y2ggdG8KPiBW UFQgKGVzcGVjaWFsbHkgaW4gbWlncmF0aW9uLCB0aGUgcGVuZGluZyBzdGF0ZXMgb2YgVkxQSXMg YXJlIHJlc3RvcmVkCj4gaW50byBrdm3igJlzIHZnaWMgZmlyc3QpLiBBbmQgd2UgY3VycmVudGx5 IHNlbmQgIklOVCtWU1lOQyIgdG8gdHJpZ2dlcgo+IGEgVkxQSSB0byBwZW5kaW5nLgo+IAo+IFNp Z25lZC1vZmYtYnk6IFplbmdodWkgWXUgPHl1emVuZ2h1aUBodWF3ZWkuY29tPgo+IFNpZ25lZC1v ZmYtYnk6IFNoZW5taW5nIEx1IDxsdXNoZW5taW5nQGh1YXdlaS5jb20+Cj4gLS0tCj4gIGFyY2gv YXJtNjQva3ZtL3ZnaWMvdmdpYy12NC5jIHwgMTIgKysrKysrKysrKysrCj4gIDEgZmlsZSBjaGFu Z2VkLCAxMiBpbnNlcnRpb25zKCspCj4gCj4gZGlmZiAtLWdpdCBhL2FyY2gvYXJtNjQva3ZtL3Zn aWMvdmdpYy12NC5jIAo+IGIvYXJjaC9hcm02NC9rdm0vdmdpYy92Z2ljLXY0LmMKPiBpbmRleCBm MjExYTdjMzI3MDQuLjc5NDVkNmQwOWNkZCAxMDA2NDQKPiAtLS0gYS9hcmNoL2FybTY0L2t2bS92 Z2ljL3ZnaWMtdjQuYwo+ICsrKyBiL2FyY2gvYXJtNjQva3ZtL3ZnaWMvdmdpYy12NC5jCj4gQEAg LTQ1NCw2ICs0NTQsMTggQEAgaW50IGt2bV92Z2ljX3Y0X3NldF9mb3J3YXJkaW5nKHN0cnVjdCBr dm0gKmt2bSwgCj4gaW50IHZpcnEsCj4gIAlpcnEtPmhvc3RfaXJxCT0gdmlycTsKPiAgCWF0b21p Y19pbmMoJm1hcC52cGUtPnZscGlfY291bnQpOwo+IAo+ICsJLyogVHJhbnNmZXIgcGVuZGluZyBz dGF0ZSAqLwo+ICsJcmV0ID0gaXJxX3NldF9pcnFjaGlwX3N0YXRlKGlycS0+aG9zdF9pcnEsCj4g KwkJCQkgICAgSVJRQ0hJUF9TVEFURV9QRU5ESU5HLAo+ICsJCQkJICAgIGlycS0+cGVuZGluZ19s YXRjaCk7Cj4gKwlXQVJOX1JBVEVMSU1JVChyZXQsICJJUlEgJWQiLCBpcnEtPmhvc3RfaXJxKTsK CldoeSBkbyB0aGlzIGlmIHBlbmRpbmdfbGF0Y2ggaXMgMCwgd2hpY2ggaXMgbGlrZWx5IHRvIGJl CnRoZSBvdmVyd2hlbG1pbmcgY2FzZT8KCj4gKwo+ICsJLyoKPiArCSAqIExldCBpdCBiZSBwcnVu ZWQgZnJvbSBhcF9saXN0IGxhdGVyIGFuZCBkb24ndCBib3RoZXIKPiArCSAqIHRoZSBMaXN0IFJl Z2lzdGVyLgo+ICsJICovCj4gKwlpcnEtPnBlbmRpbmdfbGF0Y2ggPSBmYWxzZTsKCldoYXQgZ3Vh cmFudGVlcyB0aGUgcHJ1bmluZz8gUHJ1bmluZyBvbmx5IGhhcHBlbnMgb24gdmNwdSBleGl0LAp3 aGljaCBtZWFucyB3ZSBtYXkgaGF2ZSB0aGUgc2FtZSBpbnRlcnJ1cHQgdmlhIGJvdGggdGhlIExS IGFuZAp0aGUgc3RyZWFtIGludGVyZmFjZSwgd2hpY2ggSSBkb24ndCBiZWxpZXZlIGlzIGxlZ2Fs IChpdCBpcwpsaWtlIGhhdmluZyB0d28gTFJzIGhvbGRpbmcgdGhlIHNhbWUgaW50ZXJydXB0KS4K Cj4gKwo+ICBvdXQ6Cj4gIAltdXRleF91bmxvY2soJml0cy0+aXRzX2xvY2spOwo+ICAJcmV0dXJu IHJldDsKClRoYW5rcywKCiAgICAgICAgIE0uCi0tIApKYXp6IGlzIG5vdCBkZWFkLiBJdCBqdXN0 IHNtZWxscyBmdW5ueS4uLgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBs aXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlz dGluZm8vbGludXgtYXJtLWtlcm5lbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.0 required=3.0 tests=BAYES_00,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D5EACC433E6 for ; Tue, 5 Jan 2021 09:26:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8BEE222582 for ; Tue, 5 Jan 2021 09:26:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727752AbhAEJZ4 (ORCPT ); Tue, 5 Jan 2021 04:25:56 -0500 Received: from mail.kernel.org ([198.145.29.99]:48224 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726394AbhAEJZz (ORCPT ); Tue, 5 Jan 2021 04:25:55 -0500 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id E3B9620756; Tue, 5 Jan 2021 09:25:13 +0000 (UTC) Received: from disco-boy.misterjones.org ([51.254.78.96] helo=www.loen.fr) by disco-boy.misterjones.org with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94) (envelope-from ) id 1kwiaV-005Oa8-O2; Tue, 05 Jan 2021 09:25:11 +0000 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Date: Tue, 05 Jan 2021 09:25:11 +0000 From: Marc Zyngier To: Shenming Lu Cc: Eric Auger , Will Deacon , linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, Alex Williamson , Cornelia Huck , Lorenzo Pieralisi , wanghaibin.wang@huawei.com, yuzenghui@huawei.com Subject: Re: [RFC PATCH v2 3/4] KVM: arm64: GICv4.1: Restore VLPI's pending state to physical side In-Reply-To: <20210104081613.100-4-lushenming@huawei.com> References: <20210104081613.100-1-lushenming@huawei.com> <20210104081613.100-4-lushenming@huawei.com> User-Agent: Roundcube Webmail/1.4.9 Message-ID: <76a7b9cca485dc8157d3be53189eac69@kernel.org> X-Sender: maz@kernel.org X-SA-Exim-Connect-IP: 51.254.78.96 X-SA-Exim-Rcpt-To: lushenming@huawei.com, eric.auger@redhat.com, will@kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, alex.williamson@redhat.com, cohuck@redhat.com, lorenzo.pieralisi@arm.com, wanghaibin.wang@huawei.com, yuzenghui@huawei.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On 2021-01-04 08:16, Shenming Lu wrote: > From: Zenghui Yu > > When setting the forwarding path of a VLPI (switch to the HW mode), > we could also transfer the pending state from irq->pending_latch to > VPT (especially in migration, the pending states of VLPIs are restored > into kvm’s vgic first). And we currently send "INT+VSYNC" to trigger > a VLPI to pending. > > Signed-off-by: Zenghui Yu > Signed-off-by: Shenming Lu > --- > arch/arm64/kvm/vgic/vgic-v4.c | 12 ++++++++++++ > 1 file changed, 12 insertions(+) > > diff --git a/arch/arm64/kvm/vgic/vgic-v4.c > b/arch/arm64/kvm/vgic/vgic-v4.c > index f211a7c32704..7945d6d09cdd 100644 > --- a/arch/arm64/kvm/vgic/vgic-v4.c > +++ b/arch/arm64/kvm/vgic/vgic-v4.c > @@ -454,6 +454,18 @@ int kvm_vgic_v4_set_forwarding(struct kvm *kvm, > int virq, > irq->host_irq = virq; > atomic_inc(&map.vpe->vlpi_count); > > + /* Transfer pending state */ > + ret = irq_set_irqchip_state(irq->host_irq, > + IRQCHIP_STATE_PENDING, > + irq->pending_latch); > + WARN_RATELIMIT(ret, "IRQ %d", irq->host_irq); Why do this if pending_latch is 0, which is likely to be the overwhelming case? > + > + /* > + * Let it be pruned from ap_list later and don't bother > + * the List Register. > + */ > + irq->pending_latch = false; What guarantees the pruning? Pruning only happens on vcpu exit, which means we may have the same interrupt via both the LR and the stream interface, which I don't believe is legal (it is like having two LRs holding the same interrupt). > + > out: > mutex_unlock(&its->its_lock); > return ret; Thanks, M. -- Jazz is not dead. It just smells funny...