From: Karthik B S <karthik.b.s@intel.com>
To: Krzysztof Karas <krzysztof.karas@intel.com>
Cc: <igt-dev@lists.freedesktop.org>, <pranay.samala@intel.com>,
S Sebinraj <s.sebinraj@intel.com>
Subject: Re: [PATCH i-g-t] tests/kms_explicit_fence: Replace fixed sleep with vblank wait
Date: Thu, 14 May 2026 11:42:57 +0530 [thread overview]
Message-ID: <76a8a114-392f-414c-b9c8-437f1479f551@intel.com> (raw)
In-Reply-To: <h5mztj3fvrf3rjiikxq5uzk2xojmpwnbhwcgmzxznhwbpbejgi@hahdvd2v3g7u>
Hi Krzysztof,
On 5/14/2026 11:35 AM, Krzysztof Karas wrote:
> Hi Karthik,
>
>> The premature-update detection window between the NONBLOCK atomic
>> commit and the CRC sample used a fixed 100ms sleep. On
>> high-refresh-rate panels this 100ms wait covers many vblank
>> intervals (~24 at 240 Hz vs ~6 at 60 Hz) and is long enough to let
>> the display engine enter PSR/DC5. A subsequent CRC read then comes
>> back as 0xffffffff (read from a powered-down well), causing the
>> test to fail spuriously on these panels.
>>
>> Replace the fixed sleep with 2-vblank wait:
>>
>> - It is the minimum wait that guarantees one full vblank boundary
>> has elapsed past the commit, so a same-vblank-latch bug in the
>> driver still has a deterministic window to manifest before the
>> CRC is sampled.
>> - It scales with the panel refresh rate, keeping the wait short
>> on high-refresh panels (~8 ms at 240 Hz, ~33 ms at 60 Hz).
>>
>> Cc: S Sebinraj <s.sebinraj@intel.com>
>> Cc: Krzysztof Karas <krzysztof.karas@intel.com>
>> Signed-off-by: Karthik B S <karthik.b.s@intel.com>
>> ---
> How did you find this issue? Should there be a "Closes" tag
> somewhere if that was reported by CI or community?
High refresh rate panel not present on CI execution so no bug on gitlab.
But able to see it consistently on my local runs on multiple HRR panels.
Thanks and Regards,
Karthik.B.S
>
next prev parent reply other threads:[~2026-05-14 6:13 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-11 8:11 [PATCH i-g-t] tests/kms_explicit_fence: Replace fixed sleep with vblank wait Karthik B S
2026-05-11 13:23 ` Samala, Pranay
2026-05-12 1:46 ` ✓ i915.CI.BAT: success for " Patchwork
2026-05-12 3:03 ` ✓ Xe.CI.BAT: " Patchwork
2026-05-12 7:06 ` ✗ Xe.CI.FULL: failure " Patchwork
2026-05-12 13:00 ` ✗ i915.CI.Full: " Patchwork
2026-05-15 4:12 ` Karthik B S
2026-05-14 6:05 ` [PATCH i-g-t] " Krzysztof Karas
2026-05-14 6:12 ` Karthik B S [this message]
2026-05-14 6:24 ` Krzysztof Karas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=76a8a114-392f-414c-b9c8-437f1479f551@intel.com \
--to=karthik.b.s@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=krzysztof.karas@intel.com \
--cc=pranay.samala@intel.com \
--cc=s.sebinraj@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.