All of lore.kernel.org
 help / color / mirror / Atom feed
From: Wadim Egorov <w.egorov@phytec.de>
To: John Ma <jma@phytec.com>,
	trini@konsulko.com, d.schultz@phytec.de, michal.simek@amd.com,
	ilias.apalodimas@linaro.org, j-humphreys@ti.com
Cc: u-boot@lists.denx.de, upstream@lists.phytec.de
Subject: Re: [PATCH] board: phytec: common: k3: Making setup_mac_from_eeprom optional
Date: Thu, 14 Aug 2025 09:16:58 +0300	[thread overview]
Message-ID: <76ab1570-bf8b-4463-9aca-84aef37b9e79@phytec.de> (raw)
In-Reply-To: <20250813213116.3076551-1-jma@phytec.com>



On 8/14/25 12:31 AM, John Ma wrote:
> Making the setup_mac_from_eeprom optional for boards without
> CONFIG_PHYTEC_SOM_DETECTION_BLOCKS.
> 
> Signed-off-by: John Ma <jma@phytec.com>

Reviewed-by: Wadim Egorov <w.egorov@phytec.de>

> ---
>   board/phytec/common/k3/board.c | 7 +++++--
>   1 file changed, 5 insertions(+), 2 deletions(-)
> 
> diff --git a/board/phytec/common/k3/board.c b/board/phytec/common/k3/board.c
> index 7f34d71d530..647f93a1d7a 100644
> --- a/board/phytec/common/k3/board.c
> +++ b/board/phytec/common/k3/board.c
> @@ -176,6 +176,7 @@ static void boot_targets_setup(void)
>   	env_set("boot_targets", boot_targets);
>   }
>   
> +#if IS_ENABLED(CONFIG_PHYTEC_SOM_DETECTION_BLOCKS)
>   static void setup_mac_from_eeprom(void)
>   {
>   	struct phytec_api3_element *block_element;
> @@ -197,13 +198,15 @@ static void setup_mac_from_eeprom(void)
>   		}
>   	}
>   }
> +#endif
>   
>   int board_late_init(void)
>   {
>   	boot_targets_setup();
>   
> -	if (IS_ENABLED(CONFIG_PHYTEC_SOM_DETECTION_BLOCKS))
> -		setup_mac_from_eeprom();
> +#if IS_ENABLED(CONFIG_PHYTEC_SOM_DETECTION_BLOCKS)
> +	setup_mac_from_eeprom();
> +#endif
>   
>   #if IS_ENABLED(CONFIG_EFI_HAVE_CAPSULE_SUPPORT)
>   	configure_capsule_updates();


  reply	other threads:[~2025-08-14  6:17 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-13 21:31 [PATCH] board: phytec: common: k3: Making setup_mac_from_eeprom optional John Ma
2025-08-14  6:16 ` Wadim Egorov [this message]
2025-08-21 17:16 ` Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=76ab1570-bf8b-4463-9aca-84aef37b9e79@phytec.de \
    --to=w.egorov@phytec.de \
    --cc=d.schultz@phytec.de \
    --cc=ilias.apalodimas@linaro.org \
    --cc=j-humphreys@ti.com \
    --cc=jma@phytec.com \
    --cc=michal.simek@amd.com \
    --cc=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    --cc=upstream@lists.phytec.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.