All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Niedermaier <cniedermaier@dh-electronics.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
	Marek Vasut <marex@denx.de>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>
Cc: Shawn Guo <shawnguo@kernel.org>,
	Fabio Estevam <festevam@gmail.com>,
	"NXP Linux Team" <linux-imx@nxp.com>,
	kernel <kernel@dh-electronics.com>
Subject: RE: [PATCH] ARM: dts: imx6qdl-dhcom: Move IPU iomux node from PDK2 to SoM file
Date: Tue, 16 Aug 2022 12:33:25 +0000	[thread overview]
Message-ID: <76d76020d72f4682b21e4c5c1cc50bed@dh-electronics.com> (raw)
In-Reply-To: <db2abc19-9e35-9280-e495-b3cc51a149d3@linaro.org>

From: Krzysztof Kozlowski [mailto:krzysztof.kozlowski@linaro.org]
Sent: Friday, August 12, 2022 7:41 PM
> On 12/08/2022 20:27, Marek Vasut wrote:
>> On 8/12/22 15:25, Krzysztof Kozlowski wrote:
>>> On 12/08/2022 15:03, Christoph Niedermaier wrote:
>>>> To have a variant (imx6dl/imx6q) independent access to the IPU
>>>> iomux node move them to the SoM file.
>>>
>>> There is no such variant using them, so the "possibility" is not a
>>> reason for such change. The change by itself, without proper users, does
>>> not make any sense.
>>
>> I think it does make sense to move the IPUv3 RGB/DPI interface pinmux
>> description from PDK2 carrier board DT into the common SoM DTSI, but for
>> a different reason entirely.
>>
>> The SoM specification states there is such an interface on the SoM pins:
>>
>> "
>> https://wiki.dh-electronics.com/images/2/2e/DOC_DHCOM-Standard-Specification_R01_2016-11-17.pdf
>>
>> Page 20
>>
>> 5.1.14 RGB Display
>> The DHCOM standard provides a parallel 24-bit RGB interface for driving
>> displays.
>> "
>>
>> And from what I can tell, for a carrier board to be compatible with the
>> SoM standard above, those pins have to be used as the RGB/DPI interface
>> or not used at all.
>>
>> So rather than duplicate the pinmux settings in every carrier board DT,
>> better move/deduplicate them into the SoM DTSI.
>>
>> But it seems the commit message should be updated to reflect that.
>>
>> btw. there are also downstream DTOs which do reference that pinmux
>> settings label, but maybe those DTOs are not really interesting with
>> regards to this specific change.
> 
> That's much better reasoning and it makes sense.

I will improve the commit message in V2.

Regards,
Christoph
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

      reply	other threads:[~2022-08-16 12:35 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-12 12:03 [PATCH] ARM: dts: imx6qdl-dhcom: Move IPU iomux node from PDK2 to SoM file Christoph Niedermaier
2022-08-12 13:25 ` Krzysztof Kozlowski
2022-08-12 17:27   ` Marek Vasut
2022-08-12 17:40     ` Krzysztof Kozlowski
2022-08-16 12:33       ` Christoph Niedermaier [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=76d76020d72f4682b21e4c5c1cc50bed@dh-electronics.com \
    --to=cniedermaier@dh-electronics.com \
    --cc=festevam@gmail.com \
    --cc=kernel@dh-electronics.com \
    --cc=krzysztof.kozlowski@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-imx@nxp.com \
    --cc=marex@denx.de \
    --cc=shawnguo@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.