From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CDF6015E80E for ; Thu, 18 Apr 2024 11:34:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713440089; cv=none; b=EBrHrxT3O08JuABai0X8wlFaoLloOa+wINcACUFPzN328Wg7uekpV2foAITpywr2z+aqHy16I7yG1SP+Jr9PBcnlTvmO9lz2ccpdOsEqJ7GDc8q/7bd0xloMMm7Oa89kK52ZY5hzeK1mreeOc6h+eTt+eW0JxGnR44ImzFYYXpE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713440089; c=relaxed/simple; bh=hHqENnGF5QmlzfYc/zlCjNf5/wf36TEQzNVQDbuhNz0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Tn3OvVkvadLU8sjmaEyhpdumA4SrA66kfdI0p9W79j8nJyEo/1Vs6EalTN5i1ICex/SLyhdTukc/9HrKy3QtB9okl+ILDb/SAzAkX+m8+Y67ZMeqg2bqlAnut9apwMhrP5PkASybTTQ41f8E17i5uip3NJHR9XzRAA+z0IaEaCg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=CrYnZI5q; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="CrYnZI5q" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1713440086; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=sxee1bwLiGmeojh/o1lDYTW0rtf42vjkZkESyKbCvc4=; b=CrYnZI5q+JUoWZS9pBBDe1D/TI4MDrLESd9kVaDqa/amMpatbHrpovBrJRXnq+h6WjxSZq ZCJgD+d6E+7k8hBTLK5rb3/DEt7ZXJvg0fqnHi7TbBE6NQSZtOhBeB2YBgFiugeAK0p+V1 7Dx/2vk6qDeToxC9RL5TB3+HiYgfpho= Received: from mail-ej1-f69.google.com (mail-ej1-f69.google.com [209.85.218.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-299-SkJv013MMUKcMxWMDrXybw-1; Thu, 18 Apr 2024 07:34:43 -0400 X-MC-Unique: SkJv013MMUKcMxWMDrXybw-1 Received: by mail-ej1-f69.google.com with SMTP id a640c23a62f3a-a5564a2e3a5so49740066b.1 for ; Thu, 18 Apr 2024 04:34:43 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713440082; x=1714044882; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=sxee1bwLiGmeojh/o1lDYTW0rtf42vjkZkESyKbCvc4=; b=nida9Z5cBVYeSxLXJ4auSMyeKdPjl2PnpdV0dUGy3smzLV33SSzvvbLOR41l+viOu4 uL58CzYX/dZEOuTVl0uk+dO26wLC4g4m01HwhpItMHi9axDiAl276x2jiwBAWtlVttiP 2VjfJZg1HxnpCzzLTXLulEEH7M/G0htPbkAtaxSz8D4i4OnFr5cE6MAk3IKviPGyv5I2 AOW7NgsU/BE/pSRPABpk5OLOOzI8w8BngODfHPSFQ5w9wjBfidD9vXv7bVZ67CD/WSdd 6WcvmyxPhoUV05N2Gs9d3vgHKZpu/I/BPf5/HPD3ZTupbksJkOW2HgTnMrrSTpzbklw3 CeGQ== X-Forwarded-Encrypted: i=1; AJvYcCVQSAjvNSpHwP9jXh3t/tyQPFT0VorHXDfgBgqQ6PyU2OHSBJyPAeowKyumsdPYxB21riNb6MArGLq7bz5YUbWDAJayr5FF0bIfTTNc6nKfwWswUw== X-Gm-Message-State: AOJu0YyzF8XYnhvk6vqEP60i0fK4ZEOMHj82MLMnFAKXnjY9U2oujZij xTQNEIO8dIzkLQ001Fd/Pi8aHGgdLL3OUzkoXX/bNCykt4GOJy+WYSUkSJenX6ePuC+X7kM6Cu3 IMs51Te5aSeifkMpcHyFJ5T2pgwLv9ZZQGCT17IbQBSC3ghTMFXDryUzmm6j3Mxu9L8A+d/s= X-Received: by 2002:a17:906:1e07:b0:a55:67b9:dadc with SMTP id g7-20020a1709061e0700b00a5567b9dadcmr1474935ejj.73.1713440082447; Thu, 18 Apr 2024 04:34:42 -0700 (PDT) X-Google-Smtp-Source: AGHT+IG7rx4TILRxr4Gn9I0O7SjoE9LCwDvo3Xt0PfzcannkK2g3ls6y2EAszGA/8YJzhO3HTPqwZA== X-Received: by 2002:a17:906:1e07:b0:a55:67b9:dadc with SMTP id g7-20020a1709061e0700b00a5567b9dadcmr1474922ejj.73.1713440082069; Thu, 18 Apr 2024 04:34:42 -0700 (PDT) Received: from ?IPV6:2001:1c00:c32:7800:5bfa:a036:83f0:f9ec? (2001-1c00-0c32-7800-5bfa-a036-83f0-f9ec.cable.dynamic.v6.ziggo.nl. [2001:1c00:c32:7800:5bfa:a036:83f0:f9ec]) by smtp.gmail.com with ESMTPSA id a24-20020a1709065f9800b00a526fcac8aesm763366eju.208.2024.04.18.04.34.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 18 Apr 2024 04:34:41 -0700 (PDT) Message-ID: <76d92fdc-ad0a-40a2-9e1b-d550f8e07267@redhat.com> Date: Thu, 18 Apr 2024 13:34:40 +0200 Precedence: bulk X-Mailing-List: platform-driver-x86@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 2/4] platform/x86: thinkpad_acpi: Support for trackpoint doubletap To: Mark Pearson Cc: =?UTF-8?Q?Ilpo_J=C3=A4rvinen?= , Henrique de Moraes Holschuh , ibm-acpi-devel@lists.sourceforge.net, "platform-driver-x86@vger.kernel.org" , linux-kernel@vger.kernel.org, Nitin Joshi1 , Vishnu Sankar , Peter Hutterer , Vishnu Sankar References: <20240417173124.9953-1-mpearson-lenovo@squebb.ca> <20240417173124.9953-2-mpearson-lenovo@squebb.ca> <98082080-0fcf-470f-afa5-76ec2bbffee7@redhat.com> <55ded7c3-fbc5-4fa5-8b63-da4d7aa4966c@redhat.com> Content-Language: en-US, nl From: Hans de Goede In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Hi Mark, On 4/18/24 1:57 AM, Mark Pearson wrote: > Hi Hans, > > On Wed, Apr 17, 2024, at 4:06 PM, Hans de Goede wrote: >> Hi Mark, >> >> On 4/17/24 9:39 PM, Hans de Goede wrote: >>> Hi Mark, >>> >>> Thank you for the new version of this series, overall this looks good, >>> one small remark below. >>> >>> On 4/17/24 7:31 PM, Mark Pearson wrote: >>>> Lenovo trackpoints are adding the ability to generate a doubletap event. >>>> This handles the doubletap event and sends the KEY_PROG1 event to >>>> userspace. >>>> >>>> Signed-off-by: Mark Pearson >>>> Signed-off-by: Vishnu Sankar >>>> --- >>>> Changes in v2: >>>> - Use KEY_PROG1 instead of KEY_DOUBLETAP as input maintainer doesn't >>>> want new un-specific key codes added. >>>> - Add doubletap to hotkey scan code table and use existing hotkey >>>> functionality. >>>> - Tested using evtest, and then gnome settings to configure a custom shortcut >>>> to launch an application. >>>> >>>> drivers/platform/x86/thinkpad_acpi.c | 18 ++++++++++++++++++ >>>> 1 file changed, 18 insertions(+) >>>> >>>> diff --git a/drivers/platform/x86/thinkpad_acpi.c b/drivers/platform/x86/thinkpad_acpi.c >>>> index 3b48d893280f..6d04d45e8d45 100644 >>>> --- a/drivers/platform/x86/thinkpad_acpi.c >>>> +++ b/drivers/platform/x86/thinkpad_acpi.c >>>> @@ -232,6 +232,9 @@ enum tpacpi_hkey_event_t { >>>> >>>> /* Misc */ >>>> TP_HKEY_EV_RFKILL_CHANGED = 0x7000, /* rfkill switch changed */ >>>> + >>>> + /* Misc2 */ >>>> + TP_HKEY_EV_TRACK_DOUBLETAP = 0x8036, /* trackpoint doubletap */ >>>> }; >>>> >>>> /**************************************************************************** >>>> @@ -1786,6 +1789,7 @@ enum { /* hot key scan codes (derived from ACPI DSDT) */ >>>> TP_ACPI_HOTKEYSCAN_NOTIFICATION_CENTER, >>>> TP_ACPI_HOTKEYSCAN_PICKUP_PHONE, >>>> TP_ACPI_HOTKEYSCAN_HANGUP_PHONE, >>> >>> I understand why you've done this but I think this needs a comment, >>> something like: >>> >>> /* >>> * For TP_HKEY_EV_TRACK_DOUBLETAP, unlike the codes above which map to: >>> * (hkey_event - 0x1300) + TP_ACPI_HOTKEYSCAN_EXTENDED_START, this is >>> * hardcoded for TP_HKEY_EV_TRACK_DOUBLETAP handling. Therefor this must >>> * always be the last entry (after any 0x1300-0x13ff entries). >>> */ >>> + TP_ACPI_HOTKEYSCAN_DOUBLETAP, >> >> Ugh, actually this will not work becuuse we want hotkeyscancodes to be stable >> because these are userspace API since they can be remapped using hwdb so we >> cannot have the hotkeyscancode changing when new 0x1300-0x13ff range entries >> get added. >> >> So we need to either grow the table a lot and reserve a whole bunch of space >> for future 0x13xx - 0x13ff codes or maybe something like this: >> >> diff --git a/drivers/platform/x86/thinkpad_acpi.c >> b/drivers/platform/x86/thinkpad_acpi.c >> index 771aaa7ae4cf..af3279889ecc 100644 >> --- a/drivers/platform/x86/thinkpad_acpi.c >> +++ b/drivers/platform/x86/thinkpad_acpi.c >> @@ -1742,7 +1742,12 @@ enum { /* hot key scan codes (derived from ACPI >> DSDT) */ >> TP_ACPI_HOTKEYSCAN_VOLUMEDOWN, >> TP_ACPI_HOTKEYSCAN_MUTE, >> TP_ACPI_HOTKEYSCAN_THINKPAD, >> - TP_ACPI_HOTKEYSCAN_UNK1, >> + /* >> + * Note this gets send both on 0x1019 and on >> TP_HKEY_EV_TRACK_DOUBLETAP >> + * hotkey-events. 0x1019 events have never been seen on any actual hw >> + * and a scancode is needed for the special 0x8036 doubletap >> hotkey-event. >> + */ >> + TP_ACPI_HOTKEYSCAN_DOUBLETAP, >> TP_ACPI_HOTKEYSCAN_UNK2, >> TP_ACPI_HOTKEYSCAN_UNK3, >> TP_ACPI_HOTKEYSCAN_UNK4, >> >> or just hardcode KEY_PROG1 like your previous patch does, but I'm not >> a fan of that because of loosing hwdb remapping functionality for this >> "key" then. >> >> Note I'm open to other suggestions. >> > Oh...I hadn't thought of that impact. That's not great :( > > I have an idea, but want to prototype it to see if it works out or not. Will update once I've had a chance to play with it. Thinking more about this I just realized that the input subsystem already has a mechanism for dealing with scancode ranges with (big) holes in them in the form of linux/input/sparse-keymap.h . I think that what needs to be done is convert the existing code to use sparse-keymap, keeping the mapping of the "MHKP" returned hkey codes to internal TP_ACPI_HOTKEYSCAN_* values for currently supported "MHKP" hkey codes for compatibility and then for new codes just directly map them in the sparse map aka the struct key_entry table. After converting the existing code to use sparse-keymap, then for the new events we would simply add: { KE_KEY, 0x131d, { KEY_VENDOR} }, /* Fn + N, system debug info */ { KE_KEY, 0x8036, { KEY_PROG1 } }, /* Trackpoint doubletap */ entries to the table without needing to define intermediate TP_ACPI_HOTKEYSCAN_* values for these. I already have somewhat of a design for this in my head and I really believe this is the way forward as it uses existing kernel infra and it will avoid hitting this problem again when some other new "MHKP" hkey codes show up. I plan to start working on implementing conversion of the existing code to use sparse-keymap, which should result in a nice cleanup after lunch and I hope to have something for you to test no later then next Tuesday. Regards, Hans