From: John Garry <john.g.garry@oracle.com>
To: Luis Chamberlain <mcgrof@kernel.org>,
Vincent Fu <vincent.fu@samsung.com>
Cc: fio@vger.kernel.org, axboe@kernel.dk, martin.petersen@oracle.com,
djwong@kernel.org, Pankaj Raghav <p.raghav@samsung.com>,
Daniel Gomez <da.gomez@samsung.com>,
Dan Helmick <dan.helmick@samsung.com>
Subject: Re: [PATCH 0/7] fio: atomic write support
Date: Mon, 9 Sep 2024 09:12:22 +0100 [thread overview]
Message-ID: <76e0cf08-e0ac-4443-b107-86e7d2e4c23d@oracle.com> (raw)
In-Reply-To: <ZtuQVTC4MwdzRDsy@bombadil.infradead.org>
On 07/09/2024 00:29, Luis Chamberlain wrote:
> On Fri, Sep 06, 2024 at 04:22:24PM +0100, John Garry wrote:
>> However, if we have multiple jobs, they may overwrite blocks from other jobs
>> - fio warns us about that. As such, in verify mode, the read sequence number
>> may not match was we were expecting with multiple jobs running.
> Is that a generic bug in fio?
I wouldn't say so. That is just how the verify mode works.
Fundamentally verify mode is to verify that we read back the contents of
the file as expected after each iteration. If some other job comes along
and overwrites that data, then that cannot be helped.
However maybe I should just create a new verify mode for atomic writes,
so it is clear what the verify operation constraints are.
Thanks,
John
next prev parent reply other threads:[~2024-09-09 8:12 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-29 12:31 [PATCH 0/7] fio: atomic write support John Garry
2024-08-29 12:31 ` [PATCH 1/7] os-linux: Renumber RWF_UNCACHED John Garry
2024-08-29 13:16 ` Jens Axboe
2024-08-29 12:31 ` [PATCH 2/7] os-linux: Define RWF_ATOMIC John Garry
2024-08-29 12:31 ` [PATCH 3/7] os: Reintroduce atomic write support John Garry
2024-08-29 12:31 ` [PATCH 4/7] verify: Ignore sequence number errors for atomic writes John Garry
2024-08-29 12:31 ` [PATCH 5/7] pvsync2: Support RWF_ATOMIC John Garry
2024-08-29 12:31 ` [PATCH 6/7] libaio: " John Garry
2024-08-29 12:31 ` [PATCH 7/7] io_uring: " John Garry
2024-09-05 9:37 ` [PATCH 0/7] fio: atomic write support Luis Chamberlain
2024-09-06 15:22 ` John Garry
2024-09-06 23:29 ` Luis Chamberlain
2024-09-09 8:12 ` John Garry [this message]
2024-09-09 19:48 ` Jens Axboe
2024-09-09 20:20 ` John Garry
2024-09-09 21:03 ` Luis Chamberlain
2024-09-09 19:53 ` Jens Axboe
2024-09-09 20:28 ` John Garry
2024-09-10 1:01 ` Jens Axboe
2024-09-10 10:03 ` John Garry
2024-09-10 15:56 ` Jens Axboe
2024-09-10 16:38 ` John Garry
2024-09-10 16:56 ` Jens Axboe
2024-09-10 17:17 ` John Garry
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=76e0cf08-e0ac-4443-b107-86e7d2e4c23d@oracle.com \
--to=john.g.garry@oracle.com \
--cc=axboe@kernel.dk \
--cc=da.gomez@samsung.com \
--cc=dan.helmick@samsung.com \
--cc=djwong@kernel.org \
--cc=fio@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=mcgrof@kernel.org \
--cc=p.raghav@samsung.com \
--cc=vincent.fu@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.