From: Alan Maguire <alan.maguire@oracle.com>
To: Ihor Solodrai <ihor.solodrai@pm.me>, acme@kernel.org
Cc: dwarves@vger.kernel.org, bpf <bpf@vger.kernel.org>,
andrii@kernel.org, eddyz87@gmail.com
Subject: Re: [PATCH v3 dwarves 4/5] btf_encoder: store a list of elf_function per function name
Date: Thu, 7 Nov 2024 15:45:27 +0000 [thread overview]
Message-ID: <76fdeb12-6025-40c0-85d7-b701bdd026ba@oracle.com> (raw)
In-Reply-To: <L5Bv7su_qwLNpU42pyqsvF4rfjyR8BjHgb0u2aVPUdf4Cy1lkVpWzHyLvqdca1E4d6TLot2HQK6n-YLaE5utKSjap2aQB6LkWtNhgAFZtPs=@pm.me>
On 06/11/2024 23:28, Ihor Solodrai wrote:
> On Wednesday, October 30th, 2024 at 5:14 PM, Ihor Solodrai <ihor.solodrai@pm.me> wrote:
>
>>
>> Hi Alan.
>>
>> Finally got time to try your changes. Apologies for delay, was busy
>> with other things.
>>
>> TL;DR Here is my patchset rebased on top of your commits:
>> * https://github.com/theihor/dwarves/pull/7
>>
>> Please take a look, and let's sync on how do we plan to merge it
>> in. Your commits seem to have debug code in them, so maybe you'd want
>> to submit a clean version first.
>
> Alan, Arnaldo,
>
> Did you get a chance to review the changes rebased on Alan's work?
>
> I think the state of commits in the branch is good enough as is, so
> I am inclined to send them as v4 of the patchset, assuming Alan
> doesn't mind me including his patches.
>
I need to clean up my patches and verify they generate identical BTF
from the same vmlinux, so there's a bit of work to do there first. I
should have something ready early next week. Hopefully won't look much
different, just with debug stuff removed.
Thanks
Alan
next prev parent reply other threads:[~2024-11-07 15:45 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-16 0:10 [PATCH v3 dwarves 0/5] btf_encoder: implement shared elf_functions table Ihor Solodrai
2024-10-16 0:10 ` [PATCH v3 dwarves 1/5] dwarf_loader: introduce pre_load_module hook to conf_load Ihor Solodrai
2024-10-17 10:44 ` Alan Maguire
2024-10-16 0:10 ` [PATCH v3 dwarves 2/5] btf_encoder: introduce elf_functions struct type Ihor Solodrai
2024-10-17 10:29 ` Alan Maguire
2024-10-16 0:10 ` [PATCH v3 dwarves 3/5] btf_encoder: collect elf_functions in btf_encoder__pre_load_module Ihor Solodrai
2024-10-17 10:56 ` Alan Maguire
2024-10-17 20:13 ` Arnaldo Carvalho de Melo
2024-10-18 20:17 ` Ihor Solodrai
2024-10-16 0:10 ` [PATCH v3 dwarves 4/5] btf_encoder: store a list of elf_function per function name Ihor Solodrai
2024-10-21 17:51 ` Alan Maguire
2024-10-31 0:14 ` Ihor Solodrai
2024-11-06 23:28 ` Ihor Solodrai
2024-11-07 15:45 ` Alan Maguire [this message]
2024-10-16 0:10 ` [PATCH v3 dwarves 5/5] btf_encoder: switch to shared elf_functions table Ihor Solodrai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=76fdeb12-6025-40c0-85d7-b701bdd026ba@oracle.com \
--to=alan.maguire@oracle.com \
--cc=acme@kernel.org \
--cc=andrii@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=dwarves@vger.kernel.org \
--cc=eddyz87@gmail.com \
--cc=ihor.solodrai@pm.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.