From: heiko@sntech.de (Heiko Stübner)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] dmaengine: s3c24xx-dma: Process whole SG chain
Date: Mon, 19 May 2014 00:50:43 +0200 [thread overview]
Message-ID: <7709063.rGYXWZ9fzc@phil> (raw)
In-Reply-To: <1400445779-17365-1-git-send-email-anarsoul@gmail.com>
Am Sonntag, 18. Mai 2014, 23:42:58 schrieb Vasily Khoruzhick:
> Due to redundant 'break' in a loop the driver processed only the first
> chunk.
>
> Signed-off-by: Vasily Khoruzhick <anarsoul@gmail.com>
Looks like a forgotten remnant of the time when the driver only supported sg-
lists with one element, thanks for catching this.
Reviewed-by: Heiko Stuebner <heiko@sntech.de>
> ---
> drivers/dma/s3c24xx-dma.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/dma/s3c24xx-dma.c b/drivers/dma/s3c24xx-dma.c
> index 4eddedb..2167608 100644
> --- a/drivers/dma/s3c24xx-dma.c
> +++ b/drivers/dma/s3c24xx-dma.c
> @@ -961,7 +961,6 @@ static struct dma_async_tx_descriptor
> *s3c24xx_dma_prep_slave_sg( dsg->src_addr = slave_addr;
> dsg->dst_addr = sg_dma_address(sg);
> }
> - break;
> }
>
> return vchan_tx_prep(&s3cchan->vc, &txd->vd, flags);
prev parent reply other threads:[~2014-05-18 22:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-18 20:42 [PATCH 1/2] dmaengine: s3c24xx-dma: Process whole SG chain Vasily Khoruzhick
2014-05-18 20:44 ` [PATCH 2/2] dmaengine: s3c24xx-dma: Add cyclic transfer support Vasily Khoruzhick
2014-05-18 23:03 ` Heiko Stübner
2014-05-19 8:40 ` Andy Shevchenko
2014-05-19 15:34 ` Vasily Khoruzhick
2014-05-18 22:50 ` Heiko Stübner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7709063.rGYXWZ9fzc@phil \
--to=heiko@sntech.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.