From: "Tiezhu Yang" <kernelpatch@126.com>
To: James Bottomley <James.Bottomley@HansenPartnership.com>
Cc: martin.petersen@oracle.com, linux-scsi@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] scsi: ufs: fix potential memory leak
Date: Wed, 8 Jun 2016 06:49:48 +0800 (CST) [thread overview]
Message-ID: <770e1f6d.59f.1552d0ebd55.Coremail.kernelpatch@126.com> (raw)
In-Reply-To: <1465326728.2310.39.camel@HansenPartnership.com>
At 2016-06-08 03:12:08, "James Bottomley" <James.Bottomley@HansenPartnership.com> wrote:
>On Wed, 2016-06-08 at 02:00 +0800, Tiezhu Yang wrote:
>> There exists potential memory leak in ufshcd_parse_clock_info(),
>> this patch fixes it.
>
>What makes you think there's a leak here? These are all devm_
>allocations, so they're all freed when the device is. If an error is
>returned, the device is released and the memory freed.
>
>You can argue that on successful initialization, there's no need to
>keep the clkfreq array but this patch isn't the way you'd change that.
>
>James
>
OK, thanks. I will send a v2 patch.
prev parent reply other threads:[~2016-06-07 22:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-07 18:00 [PATCH] scsi: ufs: fix potential memory leak Tiezhu Yang
2016-06-07 19:12 ` James Bottomley
2016-06-07 22:49 ` Tiezhu Yang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=770e1f6d.59f.1552d0ebd55.Coremail.kernelpatch@126.com \
--to=kernelpatch@126.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.