From: Thomas Monjalon <thomas@monjalon.net>
To: wangyunjian <wangyunjian@huawei.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
"ferruh.yigit@intel.com" <ferruh.yigit@intel.com>,
"andrew.rybchenko@oktetlabs.ru" <andrew.rybchenko@oktetlabs.ru>,
"Lilijun (Jerry)" <jerry.lilijun@huawei.com>,
xudingke <xudingke@huawei.com>,
"stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v2] ethdev: fix data type for port id
Date: Thu, 29 Oct 2020 13:43:05 +0100 [thread overview]
Message-ID: <7712554.Tb5vVfulvr@thomas> (raw)
In-Reply-To: <34EFBCA9F01B0748BEB6B629CE643AE60DADDBEB@DGGEMM533-MBX.china.huawei.com>
29/10/2020 13:18, wangyunjian:
> What about following:
>
> --- a/lib/librte_eal/freebsd/eal.c
> +++ b/lib/librte_eal/freebsd/eal.c
> @@ -672,6 +672,8 @@ rte_eal_init(int argc, char **argv)
> struct internal_config *internal_conf =
> eal_get_internal_configuration();
>
> + RTE_BUILD_BUG_ON(RTE_MAX_ETHPORTS >= UINT16_MAX);
> +
This is an ethdev value, so I would prefer having this test
inside librte_ethdev.
next prev parent reply other threads:[~2020-10-29 12:43 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-26 12:24 [dpdk-dev] [PATCH] ethdev: fix data type for port id wangyunjian
2020-10-26 12:29 ` Thomas Monjalon
2020-10-26 12:33 ` Andrew Rybchenko
2020-10-26 12:34 ` Thomas Monjalon
2020-10-27 2:46 ` wangyunjian
2020-10-27 8:47 ` Thomas Monjalon
2020-10-26 12:29 ` Andrew Rybchenko
2020-10-27 13:41 ` [dpdk-dev] [PATCH v2] " wangyunjian
2020-10-27 14:29 ` Thomas Monjalon
2020-10-29 12:18 ` wangyunjian
2020-10-29 12:40 ` Andrew Rybchenko
2020-10-29 12:43 ` Thomas Monjalon [this message]
2020-11-02 9:18 ` [dpdk-dev] [PATCH v3] " wangyunjian
2020-11-03 18:44 ` [dpdk-dev] [dpdk-stable] " Thomas Monjalon
2020-11-03 23:42 ` Stephen Hemminger
2020-11-04 1:57 ` wangyunjian
2020-11-04 2:57 ` [dpdk-dev] [PATCH v4] " wangyunjian
2020-11-04 3:26 ` Ajit Khaparde
2020-11-04 11:46 ` Ferruh Yigit
2020-11-04 13:49 ` [dpdk-dev] [dpdk-stable] " Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7712554.Tb5vVfulvr@thomas \
--to=thomas@monjalon.net \
--cc=andrew.rybchenko@oktetlabs.ru \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=jerry.lilijun@huawei.com \
--cc=stable@dpdk.org \
--cc=wangyunjian@huawei.com \
--cc=xudingke@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.