From: "Christian König" <christian.koenig@amd.com>
To: Sunil Khatri <sunil.khatri@amd.com>,
Alex Deucher <alexander.deucher@amd.com>
Cc: amd-gfx@lists.freedesktop.org
Subject: Re: [PATCH v1 1/2] drm/amdgpu: fix amdgpu_vm_bo_insert_map to let bo gets update
Date: Fri, 16 Oct 2026 14:13:55 +0200 [thread overview]
Message-ID: <7717333c-e2e1-4d50-9fee-1bcafdad067e@amd.com> (raw)
In-Reply-To: <20261016120935.1348285-1-sunil.khatri@amd.com>
On 10/16/26 14:09, Sunil Khatri wrote:
> In function amdgpu_vm_bo_insert_map, amdgpu_vm_bo_needs_update is
> skipped due to amdgpu_vm_is_bo_always_valid but it should not skip
> for bo's which are allocate have it's own dma_resv object or NULL.
>
> Signed-off-by: Sunil Khatri <sunil.khatri@amd.com>
Reviewed-by: Christian König <christian.koenig@amd.com> for both.
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
> index de992405ed718..3eb778add39be 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
> @@ -1798,7 +1798,7 @@ static void amdgpu_vm_bo_insert_map(struct amdgpu_device *adev,
> if (mapping->flags & AMDGPU_VM_PAGE_PRT)
> amdgpu_vm_prt_get(adev);
>
> - if (amdgpu_vm_is_bo_always_valid(vm, bo) && !bo_va->base.moved)
> + if (!bo_va->base.moved)
> amdgpu_vm_bo_needs_update(&bo_va->base);
>
> trace_amdgpu_vm_bo_map(bo_va, mapping);
prev parent reply other threads:[~2026-10-16 12:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-16 12:09 [PATCH v1 1/2] drm/amdgpu: fix amdgpu_vm_bo_insert_map to let bo gets update Sunil Khatri
2026-10-16 12:09 ` [PATCH v1 2/2] drm/amdgpu: identify the root PD by pointer in amdgpu_vm_bo_needs_update Sunil Khatri
2026-10-16 12:13 ` Christian König [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7717333c-e2e1-4d50-9fee-1bcafdad067e@amd.com \
--to=christian.koenig@amd.com \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=sunil.khatri@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.