From: Bob Peterson <rpeterso@redhat.com>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [PATCH 5/5] libgfs2: Remove logging API
Date: Wed, 7 May 2014 10:55:33 -0400 (EDT) [thread overview]
Message-ID: <772013598.2096444.1399474533829.JavaMail.zimbra@redhat.com> (raw)
In-Reply-To: <1399473221-28521-5-git-send-email-anprice@redhat.com>
----- Original Message -----
> libgfs2 was exposing a logging API (log_info, etc.) but wasn't using it
> itself. Remove the logging bits and move them into
> gfs2/include/logging.h
>
> Signed-off-by: Andrew Price <anprice@redhat.com>
All five patches look okay to me.
I'm a little apprehensive about removing some of the debug capabilities,
like having gfs2_grow show details about the new rgrps, but we can
likely get the same information from gfs2_edit.
Regards,
Bob Peterson
Red Hat File Systems
next prev parent reply other threads:[~2014-05-07 14:55 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-07 14:33 [Cluster-devel] [PATCH 1/5] fsck.gfs2: Log to syslog on start and exit Andrew Price
2014-05-07 14:33 ` [Cluster-devel] [PATCH 2/5] gfs2-utils: Expressly expunge 'expert mode' Andrew Price
2014-05-07 14:48 ` Bob Peterson
2014-05-07 15:01 ` Andrew Price
2014-05-07 14:33 ` [Cluster-devel] [PATCH 3/5] libgfs2: Remove UI fields from struct gfs2_sbd Andrew Price
2014-05-07 14:33 ` [Cluster-devel] [PATCH 4/5] libgfs2: Remove debug field from gfs2_sbd Andrew Price
2014-05-07 14:33 ` [Cluster-devel] [PATCH 5/5] libgfs2: Remove logging API Andrew Price
2014-05-07 14:48 ` Steven Whitehouse
2014-05-07 14:55 ` Bob Peterson [this message]
2014-05-07 15:07 ` Andrew Price
2014-05-07 15:17 ` Andrew Price
2014-05-07 14:39 ` [Cluster-devel] [PATCH 1/5] fsck.gfs2: Log to syslog on start and exit Steven Whitehouse
2014-05-07 15:15 ` Andrew Price
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=772013598.2096444.1399474533829.JavaMail.zimbra@redhat.com \
--to=rpeterso@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.