From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bob Peterson Date: Wed, 7 May 2014 10:55:33 -0400 (EDT) Subject: [Cluster-devel] [PATCH 5/5] libgfs2: Remove logging API In-Reply-To: <1399473221-28521-5-git-send-email-anprice@redhat.com> References: <1399473221-28521-1-git-send-email-anprice@redhat.com> <1399473221-28521-5-git-send-email-anprice@redhat.com> Message-ID: <772013598.2096444.1399474533829.JavaMail.zimbra@redhat.com> List-Id: To: cluster-devel.redhat.com MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit ----- Original Message ----- > libgfs2 was exposing a logging API (log_info, etc.) but wasn't using it > itself. Remove the logging bits and move them into > gfs2/include/logging.h > > Signed-off-by: Andrew Price All five patches look okay to me. I'm a little apprehensive about removing some of the debug capabilities, like having gfs2_grow show details about the new rgrps, but we can likely get the same information from gfs2_edit. Regards, Bob Peterson Red Hat File Systems