From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH 3/3] scripts: check headline of drivers commits Date: Wed, 06 Jul 2016 14:36:05 +0200 Message-ID: <7726346.NchXjSRV1Y@xps13> References: <1467801530-20800-1-git-send-email-thomas.monjalon@6wind.com> <1467801530-20800-4-git-send-email-thomas.monjalon@6wind.com> <20160706110922.GB29480@bricha3-MOBL3> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org, Nelio Laranjeiro To: Bruce Richardson Return-path: Received: from mail-wm0-f53.google.com (mail-wm0-f53.google.com [74.125.82.53]) by dpdk.org (Postfix) with ESMTP id 7D85B6CD3 for ; Wed, 6 Jul 2016 14:36:07 +0200 (CEST) Received: by mail-wm0-f53.google.com with SMTP id z126so110020462wme.0 for ; Wed, 06 Jul 2016 05:36:07 -0700 (PDT) In-Reply-To: <20160706110922.GB29480@bricha3-MOBL3> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2016-07-06 12:09, Bruce Richardson: > On Wed, Jul 06, 2016 at 12:38:50PM +0200, Thomas Monjalon wrote: > > From: Nelio Laranjeiro > > +# check headline prefix when touching only drivers/, e.g. net/ > > +bad=$(for commit in $commits ; do > > + headline=$(git log --format='%s' -1 $commit) > > + files=$(git diff-tree --no-commit-id --name-only -r $commit) > > + [ -z "$(echo "$files" | grep -v '^drivers/')" ] || continue > > Given the preference for including documentation in with the code changes, > we should perhaps exclude any doc changes when making this check. Yes we can exclude doc/ and config/. Thanks