Re: SPARC32: forced setting of mode of SUN4M per-cpu timers

[Kirill Tkhai <tkhai@yandex.ru>]

Thanks, Julian!

Kirill

05.01.2012, 05:53, "Julian Calaby" <julian.calaby@gmail.com>:
> Hi Kirill,
>
> I'll leave others to comment on the actual contents of the patch, but
> you've made a couple of rookie mistakes in submitting this patch.
>
> Firstly, make sure you put [PATCH] at the start of the subject of the
> patch as it makes it easier for people to spot patches as opposed to
> general discussion.
>
> On Thu, Jan 5, 2012 at 12:42, Kirill Tkhai <tkhai@yandex.ru> wrote:
>
>> šSPARC32: forced setting of mode of SUN4M per-cpu timers
>>
>> šSUN4M per-cpu timers have two modes of work. These are timer mode and
>> šcounter mode. SPARC32 doesn't write anything to the register, which is
>> šconnected with mode choice. So, the mode is chosen by bootloader. This
>> špatch forces to use timer mode from the kernel and to be independent of
>> šbootloader.
>>
>> šI had this problem with OpenBIOS. Timers don't tick and kernel fails on
>> šQEMU, when it's compiled with SMP support. The path fixes problem.
>
> Spelling mistake: "patch" not "path"
>
> You're missing your Signed-off-by: line. You must have a line at the
> bottom of your patch summary like the following:
>
> Signed-off-by: J Random Developer <jrdeveloper@example.com>
>
> Thanks,
>
> --
> Julian Calaby
>
> Email: julian.calaby@gmail.com
> Profile: http://www.google.com/profiles/julian.calaby/
> .Plan: http://sites.google.com/site/juliancalaby/