From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?Q?Christian_K=c3=b6nig?= Subject: Re: [PATCH 1/2] Revert "drm/amdgpu/vg20:Restruct uvd.idle_work to support multiple instance (v2)" Date: Fri, 18 May 2018 11:57:21 +0200 Message-ID: <772b92ee-e538-148d-ce62-2d497caefe52@gmail.com> References: <20180517173842.28122-1-alexander.deucher@amd.com> Reply-To: christian.koenig-5C7GfCeVMHo@public.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20180517173842.28122-1-alexander.deucher-5C7GfCeVMHo@public.gmane.org> Content-Language: en-US List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "amd-gfx" To: Alex Deucher , amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Cc: Alex Deucher QW0gMTcuMDUuMjAxOCB1bSAxOTozOCBzY2hyaWViIEFsZXggRGV1Y2hlcjoKPiBUaGlzIHJldmVy dHMgY29tbWl0IDRmN2I4NTA3YmI0YmExOWY5OTRlMGQ3MmVlZGQ2MDI5OTYxYmU0MDIuCj4KPiBX ZSBkb24ndCBuZWVkIHNlcGFyYXRlIGlkbGUgd29yayBoYW5kbGVzIGZvciBVVkQgNy4yLiAgQm90 aCBpbnN0YW5jZXMgYXJlCj4gZHJpdmVuIGJ5IHRoZSBzYW1lIGNsb2NrIGFuZCBwb3dlci4KPgo+ IFNpZ25lZC1vZmYtYnk6IEFsZXggRGV1Y2hlciA8YWxleGFuZGVyLmRldWNoZXJAYW1kLmNvbT4K ClJldmlld2VkLWJ5OiBDaHJpc3RpYW4gS8O2bmlnIDxjaHJpc3RpYW4ua29lbmlnQGFtZC5jb20+ Cgo+IC0tLQo+ICAgZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvYW1kZ3B1X3V2ZC5jIHwgMTcg KysrKysrKystLS0tLS0tLS0KPiAgIGRyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdwdV91 dmQuaCB8ICA3ICstLS0tLS0KPiAgIDIgZmlsZXMgY2hhbmdlZCwgOSBpbnNlcnRpb25zKCspLCAx NSBkZWxldGlvbnMoLSkKPgo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdw dS9hbWRncHVfdXZkLmMgYi9kcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9hbWRncHVfdXZkLmMK PiBpbmRleCBjMDE2YzQwN2FiMDkuLjA3NzI2ODAzNzFhMSAxMDA2NDQKPiAtLS0gYS9kcml2ZXJz L2dwdS9kcm0vYW1kL2FtZGdwdS9hbWRncHVfdXZkLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0v YW1kL2FtZGdwdS9hbWRncHVfdXZkLmMKPiBAQCAtMTMwLDYgKzEzMCw4IEBAIGludCBhbWRncHVf dXZkX3N3X2luaXQoc3RydWN0IGFtZGdwdV9kZXZpY2UgKmFkZXYpCj4gICAJdW5zaWduZWQgdmVy c2lvbl9tYWpvciwgdmVyc2lvbl9taW5vciwgZmFtaWx5X2lkOwo+ICAgCWludCBpLCBqLCByOwo+ ICAgCj4gKwlJTklUX0RFTEFZRURfV09SSygmYWRldi0+dXZkLmluc3QtPmlkbGVfd29yaywgYW1k Z3B1X3V2ZF9pZGxlX3dvcmtfaGFuZGxlcik7Cj4gKwo+ICAgCXN3aXRjaCAoYWRldi0+YXNpY190 eXBlKSB7Cj4gICAjaWZkZWYgQ09ORklHX0RSTV9BTURHUFVfQ0lLCj4gICAJY2FzZSBDSElQX0JP TkFJUkU6Cj4gQEAgLTIzNiw4ICsyMzgsNiBAQCBpbnQgYW1kZ3B1X3V2ZF9zd19pbml0KHN0cnVj dCBhbWRncHVfZGV2aWNlICphZGV2KQo+ICAgCQlib19zaXplICs9IEFNREdQVV9HUFVfUEFHRV9B TElHTihsZTMyX3RvX2NwdShoZHItPnVjb2RlX3NpemVfYnl0ZXMpICsgOCk7Cj4gICAKPiAgIAlm b3IgKGogPSAwOyBqIDwgYWRldi0+dXZkLm51bV91dmRfaW5zdDsgaisrKSB7Cj4gLQkJYWRldi0+ dXZkLmluc3Rbal0uZGVsYXllZF93b3JrLmlwX2luc3RhbmNlID0gajsKPiAtCQlJTklUX0RFTEFZ RURfV09SSygmYWRldi0+dXZkLmluc3Rbal0uZGVsYXllZF93b3JrLmlkbGVfd29yaywgYW1kZ3B1 X3V2ZF9pZGxlX3dvcmtfaGFuZGxlcik7Cj4gICAKPiAgIAkJciA9IGFtZGdwdV9ib19jcmVhdGVf a2VybmVsKGFkZXYsIGJvX3NpemUsIFBBR0VfU0laRSwKPiAgIAkJCQkJICAgIEFNREdQVV9HRU1f RE9NQUlOX1ZSQU0sICZhZGV2LT51dmQuaW5zdFtqXS52Y3B1X2JvLAo+IEBAIC0zMTgsNyArMzE4 LDcgQEAgaW50IGFtZGdwdV91dmRfc3VzcGVuZChzdHJ1Y3QgYW1kZ3B1X2RldmljZSAqYWRldikK PiAgIAkJaWYgKGFkZXYtPnV2ZC5pbnN0W2pdLnZjcHVfYm8gPT0gTlVMTCkKPiAgIAkJCWNvbnRp bnVlOwo+ICAgCj4gLQkJY2FuY2VsX2RlbGF5ZWRfd29ya19zeW5jKCZhZGV2LT51dmQuaW5zdFtq XS5kZWxheWVkX3dvcmsuaWRsZV93b3JrKTsKPiArCQljYW5jZWxfZGVsYXllZF93b3JrX3N5bmMo JmFkZXYtPnV2ZC5pbnN0W2pdLmlkbGVfd29yayk7Cj4gICAKPiAgIAkJLyogb25seSB2YWxpZCBm b3IgcGh5c2ljYWwgbW9kZSAqLwo+ICAgCQlpZiAoYWRldi0+YXNpY190eXBlIDwgQ0hJUF9QT0xB UklTMTApIHsKPiBAQCAtMTE0NCwxMCArMTE0NCw5IEBAIGludCBhbWRncHVfdXZkX2dldF9kZXN0 cm95X21zZyhzdHJ1Y3QgYW1kZ3B1X3JpbmcgKnJpbmcsIHVpbnQzMl90IGhhbmRsZSwKPiAgIAo+ ICAgc3RhdGljIHZvaWQgYW1kZ3B1X3V2ZF9pZGxlX3dvcmtfaGFuZGxlcihzdHJ1Y3Qgd29ya19z dHJ1Y3QgKndvcmspCj4gICB7Cj4gLQlzdHJ1Y3QgYW1kZ3B1X2RlbGF5ZWRfd29yayAqbXlfd29y ayA9IChzdHJ1Y3QgYW1kZ3B1X2RlbGF5ZWRfd29yayAqKXdvcms7Cj4gICAJc3RydWN0IGFtZGdw dV9kZXZpY2UgKmFkZXYgPQo+IC0JCWNvbnRhaW5lcl9vZih3b3JrLCBzdHJ1Y3QgYW1kZ3B1X2Rl dmljZSwgdXZkLmluc3RbbXlfd29yay0+aXBfaW5zdGFuY2VdLmRlbGF5ZWRfd29yay5pZGxlX3dv cmsud29yayk7Cj4gLQl1bnNpZ25lZCBmZW5jZXMgPSBhbWRncHVfZmVuY2VfY291bnRfZW1pdHRl ZCgmYWRldi0+dXZkLmluc3RbbXlfd29yay0+aXBfaW5zdGFuY2VdLnJpbmcpOwo+ICsJCWNvbnRh aW5lcl9vZih3b3JrLCBzdHJ1Y3QgYW1kZ3B1X2RldmljZSwgdXZkLmluc3QtPmlkbGVfd29yay53 b3JrKTsKPiArCXVuc2lnbmVkIGZlbmNlcyA9IGFtZGdwdV9mZW5jZV9jb3VudF9lbWl0dGVkKCZh ZGV2LT51dmQuaW5zdC0+cmluZyk7Cj4gICAKPiAgIAlpZiAoZmVuY2VzID09IDApIHsKPiAgIAkJ aWYgKGFkZXYtPnBtLmRwbV9lbmFibGVkKSB7Cj4gQEAgLTExNjEsNyArMTE2MCw3IEBAIHN0YXRp YyB2b2lkIGFtZGdwdV91dmRfaWRsZV93b3JrX2hhbmRsZXIoc3RydWN0IHdvcmtfc3RydWN0ICp3 b3JrKQo+ICAgCQkJCQkJCSAgICAgICBBTURfQ0dfU1RBVEVfR0FURSk7Cj4gICAJCX0KPiAgIAl9 IGVsc2Ugewo+IC0JCXNjaGVkdWxlX2RlbGF5ZWRfd29yaygmYWRldi0+dXZkLmluc3RbbXlfd29y ay0+aXBfaW5zdGFuY2VdLmRlbGF5ZWRfd29yay5pZGxlX3dvcmssIFVWRF9JRExFX1RJTUVPVVQp Owo+ICsJCXNjaGVkdWxlX2RlbGF5ZWRfd29yaygmYWRldi0+dXZkLmluc3QtPmlkbGVfd29yaywg VVZEX0lETEVfVElNRU9VVCk7Cj4gICAJfQo+ICAgfQo+ICAgCj4gQEAgLTExNzMsNyArMTE3Miw3 IEBAIHZvaWQgYW1kZ3B1X3V2ZF9yaW5nX2JlZ2luX3VzZShzdHJ1Y3QgYW1kZ3B1X3JpbmcgKnJp bmcpCj4gICAJaWYgKGFtZGdwdV9zcmlvdl92ZihhZGV2KSkKPiAgIAkJcmV0dXJuOwo+ICAgCj4g LQlzZXRfY2xvY2tzID0gIWNhbmNlbF9kZWxheWVkX3dvcmtfc3luYygmYWRldi0+dXZkLmluc3Rb cmluZy0+bWVdLmRlbGF5ZWRfd29yay5pZGxlX3dvcmspOwo+ICsJc2V0X2Nsb2NrcyA9ICFjYW5j ZWxfZGVsYXllZF93b3JrX3N5bmMoJmFkZXYtPnV2ZC5pbnN0LT5pZGxlX3dvcmspOwo+ICAgCWlm IChzZXRfY2xvY2tzKSB7Cj4gICAJCWlmIChhZGV2LT5wbS5kcG1fZW5hYmxlZCkgewo+ICAgCQkJ YW1kZ3B1X2RwbV9lbmFibGVfdXZkKGFkZXYsIHRydWUpOwo+IEBAIC0xMTkwLDcgKzExODksNyBA QCB2b2lkIGFtZGdwdV91dmRfcmluZ19iZWdpbl91c2Uoc3RydWN0IGFtZGdwdV9yaW5nICpyaW5n KQo+ICAgdm9pZCBhbWRncHVfdXZkX3JpbmdfZW5kX3VzZShzdHJ1Y3QgYW1kZ3B1X3JpbmcgKnJp bmcpCj4gICB7Cj4gICAJaWYgKCFhbWRncHVfc3Jpb3ZfdmYocmluZy0+YWRldikpCj4gLQkJc2No ZWR1bGVfZGVsYXllZF93b3JrKCZyaW5nLT5hZGV2LT51dmQuaW5zdFtyaW5nLT5tZV0uZGVsYXll ZF93b3JrLmlkbGVfd29yaywgVVZEX0lETEVfVElNRU9VVCk7Cj4gKwkJc2NoZWR1bGVfZGVsYXll ZF93b3JrKCZyaW5nLT5hZGV2LT51dmQuaW5zdC0+aWRsZV93b3JrLCBVVkRfSURMRV9USU1FT1VU KTsKPiAgIH0KPiAgIAo+ICAgLyoqCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9hbWQv YW1kZ3B1L2FtZGdwdV91dmQuaCBiL2RyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdwdV91 dmQuaAo+IGluZGV4IDc4MDFlYjhkNDE5OS4uYjE1NzlmYmExMzRjIDEwMDY0NAo+IC0tLSBhL2Ry aXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdwdV91dmQuaAo+ICsrKyBiL2RyaXZlcnMvZ3B1 L2RybS9hbWQvYW1kZ3B1L2FtZGdwdV91dmQuaAo+IEBAIC0zNywxMSArMzcsNiBAQAo+ICAgCShB TURHUFVfR1BVX1BBR0VfQUxJR04obGUzMl90b19jcHUoKChjb25zdCBzdHJ1Y3QgY29tbW9uX2Zp cm13YXJlX2hlYWRlciAqKShhZGV2KS0+dXZkLmZ3LT5kYXRhKS0+dWNvZGVfc2l6ZV9ieXRlcykg KyBcCj4gICAJCQkgICAgICAgOCkgLSBBTURHUFVfVVZEX0ZJUk1XQVJFX09GRlNFVCkKPiAgIAo+ IC1zdHJ1Y3QgYW1kZ3B1X2RlbGF5ZWRfd29ya3sKPiAtCXN0cnVjdCBkZWxheWVkX3dvcmsgaWRs ZV93b3JrOwo+IC0JdW5zaWduZWQgaXBfaW5zdGFuY2U7Cj4gLX07Cj4gLQo+ICAgc3RydWN0IGFt ZGdwdV91dmRfaW5zdCB7Cj4gICAJc3RydWN0IGFtZGdwdV9ibwkqdmNwdV9ibzsKPiAgIAl2b2lk CQkJKmNwdV9hZGRyOwo+IEBAIC00OSwxMiArNDQsMTIgQEAgc3RydWN0IGFtZGdwdV91dmRfaW5z dCB7Cj4gICAJdm9pZAkJCSpzYXZlZF9ibzsKPiAgIAlhdG9taWNfdAkJaGFuZGxlc1tBTURHUFVf TUFYX1VWRF9IQU5ETEVTXTsKPiAgIAlzdHJ1Y3QgZHJtX2ZpbGUJCSpmaWxwW0FNREdQVV9NQVhf VVZEX0hBTkRMRVNdOwo+ICsJc3RydWN0IGRlbGF5ZWRfd29yawlpZGxlX3dvcms7Cj4gICAJc3Ry dWN0IGFtZGdwdV9yaW5nCXJpbmc7Cj4gICAJc3RydWN0IGFtZGdwdV9yaW5nCXJpbmdfZW5jW0FN REdQVV9NQVhfVVZEX0VOQ19SSU5HU107Cj4gICAJc3RydWN0IGFtZGdwdV9pcnFfc3JjCWlycTsK PiAgIAlzdHJ1Y3QgZHJtX3NjaGVkX2VudGl0eSBlbnRpdHk7Cj4gICAJc3RydWN0IGRybV9zY2hl ZF9lbnRpdHkgZW50aXR5X2VuYzsKPiAtCXN0cnVjdCBhbWRncHVfZGVsYXllZF93b3JrCWRlbGF5 ZWRfd29yazsKPiAgIAl1aW50MzJfdCAgICAgICAgICAgICAgICBzcmJtX3NvZnRfcmVzZXQ7Cj4g ICB9Owo+ICAgCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f XwphbWQtZ2Z4IG1haWxpbmcgbGlzdAphbWQtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRw czovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2FtZC1nZngK