From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2801FC83F1A for ; Fri, 18 Jul 2025 10:55:41 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.1048466.1418691 (Exim 4.92) (envelope-from ) id 1ucikW-0007jj-QD; Fri, 18 Jul 2025 10:55:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1048466.1418691; Fri, 18 Jul 2025 10:55:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ucikW-0007jc-N9; Fri, 18 Jul 2025 10:55:32 +0000 Received: by outflank-mailman (input) for mailman id 1048466; Fri, 18 Jul 2025 10:55:31 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ucikV-0007EW-Gg for xen-devel@lists.xenproject.org; Fri, 18 Jul 2025 10:55:31 +0000 Received: from mail-wr1-x42a.google.com (mail-wr1-x42a.google.com [2a00:1450:4864:20::42a]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id b8e571dc-63c5-11f0-a319-13f23c93f187; Fri, 18 Jul 2025 12:55:31 +0200 (CEST) Received: by mail-wr1-x42a.google.com with SMTP id ffacd0b85a97d-3a6e2d85705so962432f8f.0 for ; Fri, 18 Jul 2025 03:55:31 -0700 (PDT) Received: from [192.168.1.183] (host-195-149-20-212.as13285.net. [195.149.20.212]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3b61ca5c8besm1485206f8f.81.2025.07.18.03.55.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 18 Jul 2025 03:55:30 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b8e571dc-63c5-11f0-a319-13f23c93f187 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.com; s=google; t=1752836130; x=1753440930; darn=lists.xenproject.org; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :references:cc:to:from:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=nenEj50t2AxHlce25v5gypGHM2miv7+I/R1SXQVAizk=; b=SchNxD6g12i4iXhBTZlRwjSjQN0YRbLQ5VDnFuXUnr/dtfRWXo0bpRMGJ01e1NuWiR 12Lm5I3Sntnd2pEZwjnAe8Cksx/7z95dE5pOUrQjhxgiCpRk5njHjZfC69MQVvo4MJ4+ Zku+qz+l/sMfByOuEt8P/LGOdTPp5RytNJFbo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752836130; x=1753440930; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :references:cc:to:from:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=nenEj50t2AxHlce25v5gypGHM2miv7+I/R1SXQVAizk=; b=dSTBkOb8setAhcJwa3TAh3pH/biyKmbRHSRbRZeftyg/90QYtriThyHhS6WWhuj9pc G08yuitimABb7MoZumCkkLUO7/b1ObcUdCpK+DTyD3N3TBg7Eucnh5JmHq8+xYueGiSO 05I/GYZKbGObo1GqR/ZHzTz7JlnP0JdjN/ukPrWeWDpGlAu1O9iJsOH3TD/Nkj2b+VYd +kE+DtbubL5VVLm6OEnyQzmVbBGB19W4g4fRuYFbGHfOwO4bRj6EiIzEVxAfRYJMkt5d F8ieXANsLpsUx4Qp8BIP1BD3OxEbuChWTFVoblUPJOn4EKglr1Vgq6dtaIOUyDK8AK77 w9wg== X-Forwarded-Encrypted: i=1; AJvYcCUXbozSoz3AAK8YkbSwxO7pAGBLOphF8DsIX/RO0fP//V+R/k0RS+8pw7N/rfrIFyWroBlqEfmkvJQ=@lists.xenproject.org X-Gm-Message-State: AOJu0YwjSi4hnzu9CIxIqa/3Lvv7vO11n/xJlqHuRwo6fZw2tAVoJX1c n3Sq9imbO2CrUobVC9/6LHAmG8cwiYEIIoY3v4JnlkyChH9pz9lsa9AX07EQKnALcSU= X-Gm-Gg: ASbGnct8OmXdyNYUyPvn3DRpyg/HlI/yEGqH6MP7LloqQcGvLEUaT7U/B3bRIoMfSbB C/hmxFgyMjLsCkSW/4sItcjA+KxClEyr7Ob1jtGylcUbNPzlyeDKjgO8m5tLHtwfM8RN4pU1CWT A5cK7CuCDfBvgNR4ktKUabvS4nRls7OTUOS2jj4Im6It4Rjuq3NEnFPozoNilpcyFc2+7ArAArZ zy60X81ghKVlMF78/lExFE9zwSpKkfpxKnoFtJIorPU2YoBcJ81GHOsseAkYmSQFcmMKuqfU1/N cICYwkIZyw7bFfpfpSFjjNNfB5MsnBQ+cjq8Fl286UwjbgkAPCHzXk7Is0yS8iGOjrkoEvKMVWg Fc1cKuGJdhCJwYYSgnDo/7/m2TRayWLS6FwQTDpyrmnNR3TrNWdHcyoI82B/xjYeEo0+l X-Google-Smtp-Source: AGHT+IEWifPwkUWsK17ZvWdp2j9X3XTH6GoTJIuSJs1lO0sp6QWT7LitgaeHDXVN/3Tu1a6AwxWNyg== X-Received: by 2002:a5d:5d0c:0:b0:3a8:30b8:cb93 with SMTP id ffacd0b85a97d-3b60dd95a75mr8812262f8f.32.1752836130390; Fri, 18 Jul 2025 03:55:30 -0700 (PDT) Message-ID: <772fd747-199c-4635-9f35-91468b0d12e9@citrix.com> Date: Fri, 18 Jul 2025 11:55:29 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1.1 6/6] x86/apic: Convert the TSC deadline errata table to X86_MATCH_*() From: Andrew Cooper To: Jan Beulich Cc: =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Xen-devel References: <20250716173132.2213891-7-andrew.cooper3@citrix.com> <20250718100739.2369750-1-andrew.cooper3@citrix.com> <4de09b8d-d71d-439e-be1c-78044a3cad31@suse.com> <9c820057-3e36-45dc-b71a-95c9d2dc4398@citrix.com> Content-Language: en-GB Autocrypt: addr=andrew.cooper3@citrix.com; keydata= xsFNBFLhNn8BEADVhE+Hb8i0GV6mihnnr/uiQQdPF8kUoFzCOPXkf7jQ5sLYeJa0cQi6Penp VtiFYznTairnVsN5J+ujSTIb+OlMSJUWV4opS7WVNnxHbFTPYZVQ3erv7NKc2iVizCRZ2Kxn srM1oPXWRic8BIAdYOKOloF2300SL/bIpeD+x7h3w9B/qez7nOin5NzkxgFoaUeIal12pXSR Q354FKFoy6Vh96gc4VRqte3jw8mPuJQpfws+Pb+swvSf/i1q1+1I4jsRQQh2m6OTADHIqg2E ofTYAEh7R5HfPx0EXoEDMdRjOeKn8+vvkAwhviWXTHlG3R1QkbE5M/oywnZ83udJmi+lxjJ5 YhQ5IzomvJ16H0Bq+TLyVLO/VRksp1VR9HxCzItLNCS8PdpYYz5TC204ViycobYU65WMpzWe LFAGn8jSS25XIpqv0Y9k87dLbctKKA14Ifw2kq5OIVu2FuX+3i446JOa2vpCI9GcjCzi3oHV e00bzYiHMIl0FICrNJU0Kjho8pdo0m2uxkn6SYEpogAy9pnatUlO+erL4LqFUO7GXSdBRbw5 gNt25XTLdSFuZtMxkY3tq8MFss5QnjhehCVPEpE6y9ZjI4XB8ad1G4oBHVGK5LMsvg22PfMJ ISWFSHoF/B5+lHkCKWkFxZ0gZn33ju5n6/FOdEx4B8cMJt+cWwARAQABzSlBbmRyZXcgQ29v cGVyIDxhbmRyZXcuY29vcGVyM0BjaXRyaXguY29tPsLBegQTAQgAJAIbAwULCQgHAwUVCgkI CwUWAgMBAAIeAQIXgAUCWKD95wIZAQAKCRBlw/kGpdefoHbdD/9AIoR3k6fKl+RFiFpyAhvO 59ttDFI7nIAnlYngev2XUR3acFElJATHSDO0ju+hqWqAb8kVijXLops0gOfqt3VPZq9cuHlh IMDquatGLzAadfFx2eQYIYT+FYuMoPZy/aTUazmJIDVxP7L383grjIkn+7tAv+qeDfE+txL4 SAm1UHNvmdfgL2/lcmL3xRh7sub3nJilM93RWX1Pe5LBSDXO45uzCGEdst6uSlzYR/MEr+5Z JQQ32JV64zwvf/aKaagSQSQMYNX9JFgfZ3TKWC1KJQbX5ssoX/5hNLqxMcZV3TN7kU8I3kjK mPec9+1nECOjjJSO/h4P0sBZyIUGfguwzhEeGf4sMCuSEM4xjCnwiBwftR17sr0spYcOpqET ZGcAmyYcNjy6CYadNCnfR40vhhWuCfNCBzWnUW0lFoo12wb0YnzoOLjvfD6OL3JjIUJNOmJy RCsJ5IA/Iz33RhSVRmROu+TztwuThClw63g7+hoyewv7BemKyuU6FTVhjjW+XUWmS/FzknSi dAG+insr0746cTPpSkGl3KAXeWDGJzve7/SBBfyznWCMGaf8E2P1oOdIZRxHgWj0zNr1+ooF /PzgLPiCI4OMUttTlEKChgbUTQ+5o0P080JojqfXwbPAyumbaYcQNiH1/xYbJdOFSiBv9rpt TQTBLzDKXok86M7BTQRS4TZ/ARAAkgqudHsp+hd82UVkvgnlqZjzz2vyrYfz7bkPtXaGb9H4 Rfo7mQsEQavEBdWWjbga6eMnDqtu+FC+qeTGYebToxEyp2lKDSoAsvt8w82tIlP/EbmRbDVn 7bhjBlfRcFjVYw8uVDPptT0TV47vpoCVkTwcyb6OltJrvg/QzV9f07DJswuda1JH3/qvYu0p vjPnYvCq4NsqY2XSdAJ02HrdYPFtNyPEntu1n1KK+gJrstjtw7KsZ4ygXYrsm/oCBiVW/OgU g/XIlGErkrxe4vQvJyVwg6YH653YTX5hLLUEL1NS4TCo47RP+wi6y+TnuAL36UtK/uFyEuPy wwrDVcC4cIFhYSfsO0BumEI65yu7a8aHbGfq2lW251UcoU48Z27ZUUZd2Dr6O/n8poQHbaTd 6bJJSjzGGHZVbRP9UQ3lkmkmc0+XCHmj5WhwNNYjgbbmML7y0fsJT5RgvefAIFfHBg7fTY/i kBEimoUsTEQz+N4hbKwo1hULfVxDJStE4sbPhjbsPCrlXf6W9CxSyQ0qmZ2bXsLQYRj2xqd1 bpA+1o1j2N4/au1R/uSiUFjewJdT/LX1EklKDcQwpk06Af/N7VZtSfEJeRV04unbsKVXWZAk uAJyDDKN99ziC0Wz5kcPyVD1HNf8bgaqGDzrv3TfYjwqayRFcMf7xJaL9xXedMcAEQEAAcLB XwQYAQgACQUCUuE2fwIbDAAKCRBlw/kGpdefoG4XEACD1Qf/er8EA7g23HMxYWd3FXHThrVQ HgiGdk5Yh632vjOm9L4sd/GCEACVQKjsu98e8o3ysitFlznEns5EAAXEbITrgKWXDDUWGYxd pnjj2u+GkVdsOAGk0kxczX6s+VRBhpbBI2PWnOsRJgU2n10PZ3mZD4Xu9kU2IXYmuW+e5KCA vTArRUdCrAtIa1k01sPipPPw6dfxx2e5asy21YOytzxuWFfJTGnVxZZSCyLUO83sh6OZhJkk b9rxL9wPmpN/t2IPaEKoAc0FTQZS36wAMOXkBh24PQ9gaLJvfPKpNzGD8XWR5HHF0NLIJhgg 4ZlEXQ2fVp3XrtocHqhu4UZR4koCijgB8sB7Tb0GCpwK+C4UePdFLfhKyRdSXuvY3AHJd4CP 4JzW0Bzq/WXY3XMOzUTYApGQpnUpdOmuQSfpV9MQO+/jo7r6yPbxT7CwRS5dcQPzUiuHLK9i nvjREdh84qycnx0/6dDroYhp0DFv4udxuAvt1h4wGwTPRQZerSm4xaYegEFusyhbZrI0U9tJ B8WrhBLXDiYlyJT6zOV2yZFuW47VrLsjYnHwn27hmxTC/7tvG3euCklmkn9Sl9IAKFu29RSo d5bD8kMSCYsTqtTfT6W4A3qHGvIDta3ptLYpIAOD2sY3GYq2nf3Bbzx81wZK14JdDDHUX2Rs 6+ahAA== In-Reply-To: <9c820057-3e36-45dc-b71a-95c9d2dc4398@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 18/07/2025 11:23 am, Andrew Cooper wrote: > On 18/07/2025 11:19 am, Jan Beulich wrote: >> On 18.07.2025 12:07, Andrew Cooper wrote: >>> With the ability to match on steppings, introduce a new X86_MATCH_VFMS() >>> helper to match a specific stepping, and use it to rework deadline_match[]. >>> >>> Notably this removes the overloading of driver_data possibly being a function >>> pointer, and removes the latent bug where the target functions are missing >>> ENDBR instructions owing to the lack of the cf_check attribute. >>> >>> No functional change. >>> >>> Signed-off-by: Andrew Cooper >> Reviewed-by: Jan Beulich > Thanks. Actually, this isn't as no-functional-change as I thought. X86_FEATURE_TSC_DEADLINE has been swapped for X86_FEATURE_ANY in the table. check_deadline_errata() is called unconditionally, without checking for TSC_DEADLINE, yet the rows in the table are the CPUs for which an erratum is known, so they all have the feature. It does make a difference if e.g. one were to boot with cpuid=no-tsc-deadline.  Previously we'd have exited early, while now we'll emit the warning. We could switch back to using TSC_DEADLINE (requiring a more complicated X86_MATCH_*() wrapper), although a better option would be to predicate the call to check_deadline_errata() with a feature check, because it's a much more recent addition to AMD CPUs, and there's no point searching the errata list on CPUs which lack the feature. Thoughts? ~Andrew