From mboxrd@z Thu Jan 1 00:00:00 1970 From: Heiko Stuebner Subject: Re: [PATCH v6 7/7] drm/rockchip: vop: rk3328: fix overlay abnormal Date: Fri, 28 Jul 2017 15:06:39 +0200 Message-ID: <7730838.UedTk5eOxO@phil> References: <1501049930-5794-1-git-send-email-mark.yao@rock-chips.com> <1501049980-6239-1-git-send-email-mark.yao@rock-chips.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1501049980-6239-1-git-send-email-mark.yao@rock-chips.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Mark Yao Cc: linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org List-Id: linux-rockchip.vger.kernel.org QW0gTWl0dHdvY2gsIDI2LiBKdWxpIDIwMTcsIDE0OjE5OjM5IENFU1Qgc2NocmllYiBNYXJrIFlh bzoKPiBJdCdzIGEgaGFyZHdhcmUgYnVnLCBhbGwgd2luZG93J3Mgb3ZlcmxheSBjaGFubmVsIHJl c2V0Cj4gdmFsdWUgaXMgc2FtZSwgaGFyZHdhcmUgb3ZlcmxheSB3b3VsZCBiZSBkaWUuCj4gCj4g c28gd2UgbXVzdCBpbml0aWFsIGRpZmZlcmVuY2UgaWQgZm9yIGVhY2ggb3ZlcmxheSBjaGFubmVs Lgo+IAo+IFRoZSBDaGFubmVsIHJlZ2lzdGVyIGlzIHN1cHBvcnRlZCBvbiBhbGwgdm9wIHdpbGwg ZnVsbCBkZXNpZ24uCj4gRm9sbG93aW5nIGlzIHRoZSBkZXRhaWxzIGZvciB0aGlzIHJlZ2lzdGVy Cj4gVk9QX1dJTjBfQ1RSTDIKPiAgIGJpdFs3OjRdIHdpbl9yaWRfd2luMF9jYnIKPiAgICAgICAg YXhpIHJlYWQgaWQgb2Ygd2luMCBjYnIgY2hhbm5lbAo+ICAgYml0WzM6MF0gd2luX3JpZF93aW4w X3lyZ2IKPiAgICAgICAgYXhpIHJlYWQgaWQgb2Ygd2luMCB5cmdiIGNoYW5uZWwKPiAKPiBTaWdu ZWQtb2ZmLWJ5OiBNYXJrIFlhbyA8bWFyay55YW9Acm9jay1jaGlwcy5jb20+CgpyazMwMzYgYW5k IHJrMzI4OCBhcmUgbm90IG5lZ2F0aXZlbHkgYWZmZWN0ZWQgYnkgdGhpcywgc28Kb24gcmszMDM2 IGFuZCByazMyODgKVGVzdGVkLWJ5OiBIZWlrbyBTdHVlYm5lciA8aGVpa29Ac250ZWNoLmRlPgpf X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwg bWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0 cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 From: heiko@sntech.de (Heiko Stuebner) Date: Fri, 28 Jul 2017 15:06:39 +0200 Subject: [PATCH v6 7/7] drm/rockchip: vop: rk3328: fix overlay abnormal In-Reply-To: <1501049980-6239-1-git-send-email-mark.yao@rock-chips.com> References: <1501049930-5794-1-git-send-email-mark.yao@rock-chips.com> <1501049980-6239-1-git-send-email-mark.yao@rock-chips.com> Message-ID: <7730838.UedTk5eOxO@phil> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Am Mittwoch, 26. Juli 2017, 14:19:39 CEST schrieb Mark Yao: > It's a hardware bug, all window's overlay channel reset > value is same, hardware overlay would be die. > > so we must initial difference id for each overlay channel. > > The Channel register is supported on all vop will full design. > Following is the details for this register > VOP_WIN0_CTRL2 > bit[7:4] win_rid_win0_cbr > axi read id of win0 cbr channel > bit[3:0] win_rid_win0_yrgb > axi read id of win0 yrgb channel > > Signed-off-by: Mark Yao rk3036 and rk3288 are not negatively affected by this, so on rk3036 and rk3288 Tested-by: Heiko Stuebner From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752013AbdG1NGs (ORCPT ); Fri, 28 Jul 2017 09:06:48 -0400 Received: from gloria.sntech.de ([95.129.55.99]:52178 "EHLO gloria.sntech.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751725AbdG1NGr (ORCPT ); Fri, 28 Jul 2017 09:06:47 -0400 From: Heiko Stuebner To: Mark Yao Cc: David Airlie , dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v6 7/7] drm/rockchip: vop: rk3328: fix overlay abnormal Date: Fri, 28 Jul 2017 15:06:39 +0200 Message-ID: <7730838.UedTk5eOxO@phil> User-Agent: KMail/5.2.3 (Linux/4.9.0-2-amd64; KDE/5.28.0; x86_64; ; ) In-Reply-To: <1501049980-6239-1-git-send-email-mark.yao@rock-chips.com> References: <1501049930-5794-1-git-send-email-mark.yao@rock-chips.com> <1501049980-6239-1-git-send-email-mark.yao@rock-chips.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am Mittwoch, 26. Juli 2017, 14:19:39 CEST schrieb Mark Yao: > It's a hardware bug, all window's overlay channel reset > value is same, hardware overlay would be die. > > so we must initial difference id for each overlay channel. > > The Channel register is supported on all vop will full design. > Following is the details for this register > VOP_WIN0_CTRL2 > bit[7:4] win_rid_win0_cbr > axi read id of win0 cbr channel > bit[3:0] win_rid_win0_yrgb > axi read id of win0 yrgb channel > > Signed-off-by: Mark Yao rk3036 and rk3288 are not negatively affected by this, so on rk3036 and rk3288 Tested-by: Heiko Stuebner