Re: [dpdk-dev] [PATCH] devtools: reduce examples in static builds

[Thomas Monjalon <thomas@monjalon.net>]

19/04/2020 16:29, Thomas Monjalon:
> 19/04/2020 09:08, David Marchand:
> > On Sat, Apr 18, 2020 at 3:20 PM Thomas Monjalon <thomas@monjalon.net> wrote:
> > > --- a/devtools/test-meson-builds.sh
> > > +++ b/devtools/test-meson-builds.sh
> > > -       options="$options --werror -Dexamples=all"
> > > +       options="$options --werror"
> > > +       if echo $* | grep -qw -- '--default-library=static' ; then
> > > +               options="$options -Dexamples=l3fwd"
> > > +       else
> > > +               options="$options -Dexamples=all"
> > > +       fi
> > 
> > Ok, this is hypothetical, but this would not work when no
> > default-library option is passed (static is the default value).
> 
> No, with meson, shared is the default:
> 	https://mesonbuild.com/Builtin-options.html#core-options

Thanks to an offline explanation, it appears I'm wrong.
The default value is changed in our root meson.build file:
	default_options: ['buildtype=release', 'default_library=static'],

> > How about inverting the check and look for default-library=shared ?

Yes I will invert the check in v2.

> > Besides, you won't catch already configured directories.
> > While for make environments, this change will have an effect right away.
> 
> Yes, I think it is OK to keep old configuration in meson builds
> until the build directories are trashed.