From: Arend Van Spriel <arend.vanspriel@broadcom.com>
To: "Toke Høiland-Jørgensen" <toke@redhat.com>,
"Felix Fietkau" <nbd@nbd.name>,
linux-wireless@vger.kernel.org
Cc: johannes@sipsolutions.net, Herbert Xu <herbert@gondor.apana.org.au>
Subject: Re: [PATCH 5/5] mac80211: set NETIF_F_LLTX when using intermediate tx queues
Date: Sun, 14 Apr 2019 11:44:17 +0200 [thread overview]
Message-ID: <773e4dff-29fd-22b4-e4bc-cd5a94c66dc2@broadcom.com> (raw)
In-Reply-To: <87sgvmvg9g.fsf@toke.dk>
+ Herbert
On 3/16/2019 7:14 PM, Toke Høiland-Jørgensen wrote:
> Felix Fietkau <nbd@nbd.name> writes:
>
>> When using iTXQ, tx sequence number allocation and statistics are run at
>> dequeue time. Because of that, it is safe to enable NETIF_F_LLTX, which
>> allows tx handlers to run on multiple CPUs in parallel.
>
> Cool, didn't know about that flag.
It is water under the bridge as this patch got applied already, but I
stumbled upon it just recently and didn't know about that flag either.
So I looked for more information about it and found the definition [1],
but the comment seemed important enough to send this reply.
NETIF_F_LLTX_BIT, /* LockLess TX - deprecated. Please */
/* do not use LLTX in new drivers */
Here is the commit that marked it deprecated:
commit e24eb521fbf2a350ce879dfc1d8e56d4ffa2aa22
Author: Christian Borntraeger <borntraeger@de.ibm.com>
Date: Tue Sep 25 19:42:02 2007 -0700
[NET]: note that NETIF_F_LLTX is deprecated
So I am not sure we should really do this in mac80211. Maybe Herbert can
comment although it has been over a decade ago.
Regards,
Arend
[1]
https://elixir.bootlin.com/linux/latest/source/include/linux/netdev_features.h#L32
next prev parent reply other threads:[~2019-04-14 9:44 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-16 17:06 [PATCH 1/5] mac80211: mesh: drop redundant rcu_read_lock/unlock calls Felix Fietkau
2019-03-16 17:06 ` [PATCH 2/5] mac80211: fix memory accounting with A-MSDU aggregation Felix Fietkau
2019-03-16 18:12 ` Toke Høiland-Jørgensen
2019-03-16 17:06 ` [PATCH 3/5] mac80211: calculate hash for fq without holding fq->lock in itxq enqueue Felix Fietkau
2019-03-16 18:13 ` Toke Høiland-Jørgensen
2019-03-16 17:06 ` [PATCH 4/5] mac80211: run late dequeue late tx handlers without holding fq->lock Felix Fietkau
2019-03-16 18:13 ` Toke Høiland-Jørgensen
2022-12-05 9:46 ` Wen Gong
2022-12-05 9:46 ` Wen Gong
2022-12-07 6:30 ` Wen Gong
2022-12-07 6:30 ` Wen Gong
2022-12-12 8:31 ` Wen Gong
2022-12-12 8:31 ` Wen Gong
2019-03-16 17:06 ` [PATCH 5/5] mac80211: set NETIF_F_LLTX when using intermediate tx queues Felix Fietkau
2019-03-16 18:14 ` Toke Høiland-Jørgensen
2019-04-14 9:44 ` Arend Van Spriel [this message]
2019-04-14 11:19 ` Felix Fietkau
2019-04-14 12:34 ` Arend Van Spriel
2019-04-16 7:34 ` Arend Van Spriel
2019-04-16 7:44 ` Herbert Xu
2019-04-16 8:04 ` Arend Van Spriel
2019-04-16 8:36 ` Herbert Xu
2019-04-16 8:37 ` Johannes Berg
2019-04-16 9:17 ` Arend Van Spriel
2019-04-16 9:29 ` Herbert Xu
2019-04-16 9:33 ` Toke Høiland-Jørgensen
2019-04-16 9:33 ` Johannes Berg
2019-04-16 9:37 ` Herbert Xu
2019-04-16 9:39 ` Johannes Berg
2019-04-16 10:02 ` Toke Høiland-Jørgensen
2019-04-17 2:11 ` Herbert Xu
2019-04-17 8:28 ` Toke Høiland-Jørgensen
2019-04-16 13:13 ` Herbert Xu
2019-04-16 13:18 ` Toke Høiland-Jørgensen
2019-04-17 3:38 ` Herbert Xu
2019-04-17 9:09 ` Toke Høiland-Jørgensen
2019-04-17 9:16 ` Arend Van Spriel
2019-04-17 9:17 ` Toke Høiland-Jørgensen
2019-04-23 12:41 ` Johannes Berg
2019-04-25 8:35 ` Herbert Xu
2019-04-25 8:39 ` Johannes Berg
2019-04-25 8:44 ` Herbert Xu
2019-04-25 8:49 ` Johannes Berg
2019-04-16 19:13 ` Johannes Berg
2019-04-17 2:13 ` Herbert Xu
2019-04-16 9:38 ` Toke Høiland-Jørgensen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=773e4dff-29fd-22b4-e4bc-cd5a94c66dc2@broadcom.com \
--to=arend.vanspriel@broadcom.com \
--cc=herbert@gondor.apana.org.au \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=nbd@nbd.name \
--cc=toke@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.