From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7F18DC83F17 for ; Fri, 18 Jul 2025 17:25:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=hvQRsE2lG7WyIIQnwV/DeD9T4vuk4piXmEgdbjYc460=; b=jD6jzQ9YP/h96ljfZnOSjVXVKm MhFm8m1SG9kjoyJ1kcaUiHWhAiNDLhYIiAhJmDgzabd9LS3q8/vBq3n8NkZLIPPt+S7qyUSkT5KnB 5oPZ09y4HVlaQ7T5HcEXK+L4PfGnk8E+hbG8FJh04eig6Hx0rOIhJCL4Tyub5XZPGdSfyiVgkwy4j 65wICcl1HaxcMLTniEAZaCcasfqc9kHHAdX7sEuz7d4QYSfgstS6AYmmAVzh0h5SN+0Q7ag61VZSD uL4sGvHtp5BpPD1qxnryW01FVhGbuzN08+MXBV4PGrOqRORQgoxZO/H7Q01cHZX++pe2FHcrjQAHI aIytyEMw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1ucopy-0000000DDIu-2u8a; Fri, 18 Jul 2025 17:25:34 +0000 Received: from mx0b-0031df01.pphosted.com ([205.220.180.131]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1ucofZ-0000000DCGm-0QML for linux-arm-kernel@lists.infradead.org; Fri, 18 Jul 2025 17:14:50 +0000 Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 56I8tvJP021699 for ; Fri, 18 Jul 2025 17:14:48 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= hvQRsE2lG7WyIIQnwV/DeD9T4vuk4piXmEgdbjYc460=; b=G9HONGQ2Qa2uUbLZ VJY4Lqvyrv1n/8Lykdjk8ImdB8+wf9SYMMzho7gbPSwHGSDoxrUBE0CiNNwxX9tU eiuk2i03SYOOUMR/fzdvSMV4XqbJNDyDuvShdivyYxYc+NZo6O9pnZkJG20id4xH +GQ6CivijZWO/Yf86g+q8FR696sTRXmGqNM957Ntrk/wR/1dcjZG442XRPYcu9Dl 2t6TTIi6n2flM1t9PB5QfE+BihzXzRoIFag/A/QdGofEojZLvcAH6xsAgHzN8Kev m3Vck5j3SQIkQddI4fbh5TebcaUGQBnIOFC3p8FE571tDb26sN/rlJWab2c9WjXO d5BCRQ== Received: from mail-pj1-f69.google.com (mail-pj1-f69.google.com [209.85.216.69]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 47ufu8m79y-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Fri, 18 Jul 2025 17:14:47 +0000 (GMT) Received: by mail-pj1-f69.google.com with SMTP id 98e67ed59e1d1-311ef4fb5fdso2839580a91.1 for ; Fri, 18 Jul 2025 10:14:47 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752858887; x=1753463687; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=hvQRsE2lG7WyIIQnwV/DeD9T4vuk4piXmEgdbjYc460=; b=B815edIfryAlPHLBRmGn680nIEN1A/miJeFzQwTcAL3Wk5c5AEnEdXTB6C5aa5dJFc LXDrIW0OmfcuM6sLHFxpdkgMlukg01KMh4t8FbqTTSM1VnTxq+pHvtMwQclrZ19Ht33k GEWb6x7iAuA1mxGqrYqB+yZHpA3mKdxZmpjRD5OIPIcan9TL2I937oQJiHULVOiVamkG GGmpVg1FFQkoq7MqgCAKKWjr8zWtXqyRmn1qIXM95tpqeWvXN/mNwl4AdJaPEPqhgNmE vPLSzr0rUyAS9CJH/F/OTkcpB/jSPNKv9dtIgIlKgbBU6atDHOjMBY5+7icA6/3VMFmz CNgA== X-Forwarded-Encrypted: i=1; AJvYcCVa7rfPJUsSxspuD39Wjvcuxhq4uLcLD9wI2Dl4aV6fVJ+BWpUmuPj6SOgZGtoqW3qnWoGYzUY8wtpeAAz/qj62@lists.infradead.org X-Gm-Message-State: AOJu0YyKBTZUfaLiP3pFAL1EzLbaqY33WLVcbBxz8SLSBexzfsE3JVob WKmGEaicuiu6m/w9XftjQ3tVh/yP2kfaBnz5qJGJCVruEonXIGZ2wUmW0zeOYNW+rekIPx3n5j9 TKqIY3oMf8wPAiCUrdqHKC1cijIKspXxGiaAfRvjpynkNvIdO5ME4EjXIoojpMr/E3X+NKQmBr5 gxAQ== X-Gm-Gg: ASbGncueAEKzBcoCBPXP9pJTkAZdnV7M2Qtn5u+Y3yjMxB4hZ2lg6hVYmuBFhScobdV GEmIIyhLqlppsL5SzS7yq3PxwiRmVwAaEs5FvlTNzAYARZTW6ouunjs8CSc0QZKYQDNJuCc6+wO 07T8/on1pMKtaCZA+CC1dRkPXN5Fch4biSOq2MxTo/Syb+FmDvruzw2YEUmfoK3Fbnh8Aw0k7rn T0cabgonrQUrfGEFvQiG4j4zuXrDBg8b436bt0PXcbY6PCYszsOePKst4AVTud3gP+Tndrv+cI+ 9UUzB0lHT/3IcyG2zmJBt87JbVWfzkwMOQ4uR1anR34PDSd0R+qUukeu9zi4tgPIDubFDzNKeky SQiXdw1IbaXfEbA== X-Received: by 2002:a17:90b:48c8:b0:315:b07a:ac12 with SMTP id 98e67ed59e1d1-31c9e6f71b8mr18347605a91.14.1752858886434; Fri, 18 Jul 2025 10:14:46 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHAZ4uYoT0jpgwok+1LqJLQaSu3L2fEp1diUxE597ewVDpbjd87lEWbuWkSUsEweCpZR2VK2w== X-Received: by 2002:a17:90b:48c8:b0:315:b07a:ac12 with SMTP id 98e67ed59e1d1-31c9e6f71b8mr18347517a91.14.1752858885895; Fri, 18 Jul 2025 10:14:45 -0700 (PDT) Received: from [10.226.59.182] (i-global254.qualcomm.com. [199.106.103.254]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-31cc3e5b56fsm1593934a91.16.2025.07.18.10.14.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 18 Jul 2025 10:14:45 -0700 (PDT) Message-ID: <7753e1e8-5e2d-4d8b-8a46-a6fbc58a144d@oss.qualcomm.com> Date: Fri, 18 Jul 2025 11:14:42 -0600 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v8 02/10] accel/rocket: Add a new driver for Rockchip's NPU To: Tomeu Vizoso , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Heiko Stuebner , Oded Gabbay , Jonathan Corbet , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Sumit Semwal , =?UTF-8?Q?Christian_K=C3=B6nig?= , Sebastian Reichel , Nicolas Frattaroli , Kever Yang , Robin Murphy , Daniel Stone , Da Xue , Philipp Zabel Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-doc@vger.kernel.org, linux-media@vger.kernel.org, linaro-mm-sig@lists.linaro.org, Robert Foss References: <20250713-6-10-rocket-v8-0-64fa3115e910@tomeuvizoso.net> <20250713-6-10-rocket-v8-2-64fa3115e910@tomeuvizoso.net> Content-Language: en-US From: Jeff Hugo In-Reply-To: <20250713-6-10-rocket-v8-2-64fa3115e910@tomeuvizoso.net> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNzE4MDEzNiBTYWx0ZWRfXyDa6+hYn7G3M bOwMxo3F1x3R89qswYohXg/ozr/MHuCdcmU/Mkq/sAlMxXa+ygMQp8sdbp4pMZylU+YHRqt1DY/ K94S7Evw2W6qGYDrrPNEatq3pkXroz2G4MtReJx/6cHLP/fHrXJY29xWNrsXyKXQngJuFK+TOZg A9XbLGFqtqAasz6p722bT+51cJP2PyqFS9CBsavfzuZyOgmzh9cw6ZxEBW2de/u7fX/FZyqk9dl +GdTwvUHngwS5LkkuZiK0emQDkDz6jMGqPdwrps7UAHiXTlFP06FGZUIVym2fByoSaGndne2V5T cgPh0YBl5g2VwNFidtJtAyANq2oPpJVIrzj9+yt9prqePOITGBKf1bR9Hp7T48BMcUh218bLmGf EGiU9wbmBj0kcyhr98L9wDg+CBqh9z5bbPO7LWHh/7pcubkrm5wFe+UhPgFDsxZjgR0mJs8N X-Proofpoint-ORIG-GUID: iL1ACA_uitS38DWF6IWS5pqFl04ufBWd X-Proofpoint-GUID: iL1ACA_uitS38DWF6IWS5pqFl04ufBWd X-Authority-Analysis: v=2.4 cv=f59IBPyM c=1 sm=1 tr=0 ts=687a8107 cx=c_pps a=vVfyC5vLCtgYJKYeQD43oA==:117 a=JYp8KDb2vCoCEuGobkYCKw==:17 a=IkcTkHD0fZMA:10 a=Wb1JkmetP80A:10 a=VwQbUJbxAAAA:8 a=DISFzqtZAAAA:8 a=EUspDBNiAAAA:8 a=V6djkQ_TFPnTOxwyQKcA:9 a=QEXdDO2ut3YA:10 a=rl5im9kqc5Lf4LNbBjHf:22 a=aug85vrO5LANNmmtkfAW:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-07-18_04,2025-07-17_02,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 lowpriorityscore=0 malwarescore=0 spamscore=0 mlxscore=0 bulkscore=0 suspectscore=0 impostorscore=0 adultscore=0 priorityscore=1501 mlxlogscore=999 phishscore=0 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2505280000 definitions=main-2507180136 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250718_101449_253357_8829FC00 X-CRM114-Status: GOOD ( 19.86 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 7/13/2025 2:38 AM, Tomeu Vizoso wrote: > This initial version supports the NPU as shipped in the RK3588 SoC and > described in the first part of its TRM, in Chapter 36. > > This NPU contains 3 independent cores that the driver can submit jobs > to. > > This commit adds just hardware initialization and power management. > > v2: > - Split cores and IOMMUs as independent devices (Sebastian Reichel) > - Add some documentation (Jeffrey Hugo) > - Be more explicit in the Kconfig documentation (Jeffrey Hugo) > - Remove resets, as these haven't been found useful so far (Zenghui Yu) > - Repack structs (Jeffrey Hugo) > - Use DEFINE_DRM_ACCEL_FOPS (Jeffrey Hugo) > - Use devm_drm_dev_alloc (Jeffrey Hugo) > - Use probe log helper (Jeffrey Hugo) > - Introduce UABI header in a later patch (Jeffrey Hugo) > > v3: > - Adapt to a split of the register block in the DT bindings (Nicolas > Frattaroli) > - Move registers header to its own commit (Thomas Zimmermann) > - Misc. cleanups (Thomas Zimmermann and Jeff Hugo) > - Make use of GPL-2.0-only for the copyright notice (Jeff Hugo) > - PM improvements (Nicolas Frattaroli) > > v4: > - Use bulk clk API (Krzysztof Kozlowski) > > v6: > - Remove mention to NVDLA, as the hardware is only incidentally related > (Kever Yang) > - Use calloc instead of GFP_ZERO (Jeff Hugo) > - Explicitly include linux/container_of.h (Jeff Hugo) > - pclk and npu clocks are now needed by all cores (Rob Herring) > > v7: > - Assign its own IOMMU domain to each client, for isolation (Daniel > Stone and Robin Murphy) > > v8: > - Kconfig: fix depends to be more explicit about Rockchip, and remove > superfluous selects (Robin Murphy) > - Use reset lines to reset the cores (Robin Murphy) > - Reference count the module > - Set dma_set_max_seg_size > - Correctly acquire a reference to the IOMMU (Robin Murphy) > - Remove notion of top core (Robin Murphy) > > Reviewed-by: Robert Foss > Tested-by: Heiko Stuebner > Signed-off-by: Tomeu Vizoso Reviewed-by: Jeff Hugo From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 365B6C83F1A for ; Fri, 18 Jul 2025 17:23:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=HdHe1l/IMXAK/h+2Z9ph1YjepwLZTi315xQMdrgp7tM=; b=PHU7yh4egTAwQV sz2hDo2LuZ4uUKgQ+7nGuXX8zJMM8UvWKV9lOkXufZ/lKRn6frfIBdasZW6c7hOz4PFLxfIQKWhfY biBcio0osxRmlIlLZFDsE3aTQTc+TTqj5cMS2ZJ682IQFQYOla3RP2yvFbmuk4VUYi4D56Bejp87k psswM85foI+8wZZCN7PbA4g2U7HWzlpmv2KwaADrd9fK+yJTW9vMozB4jIfGQxdK+pbXY+wMxbkMG n5PHz1NEaLR+pB6cIQMr1782YoESL84RW2G50l0hg200yAdxLDdzF77ONTX/36gI5cc0LctZG/sk2 clcjBv9+jiWV0BC0wqZw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1uconb-0000000DD3b-0alE; Fri, 18 Jul 2025 17:23:07 +0000 Received: from mx0a-0031df01.pphosted.com ([205.220.168.131]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1ucofY-0000000DCGV-093y for linux-rockchip@lists.infradead.org; Fri, 18 Jul 2025 17:14:49 +0000 Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 56I9NiIs015963 for ; Fri, 18 Jul 2025 17:14:47 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= hvQRsE2lG7WyIIQnwV/DeD9T4vuk4piXmEgdbjYc460=; b=G9HONGQ2Qa2uUbLZ VJY4Lqvyrv1n/8Lykdjk8ImdB8+wf9SYMMzho7gbPSwHGSDoxrUBE0CiNNwxX9tU eiuk2i03SYOOUMR/fzdvSMV4XqbJNDyDuvShdivyYxYc+NZo6O9pnZkJG20id4xH +GQ6CivijZWO/Yf86g+q8FR696sTRXmGqNM957Ntrk/wR/1dcjZG442XRPYcu9Dl 2t6TTIi6n2flM1t9PB5QfE+BihzXzRoIFag/A/QdGofEojZLvcAH6xsAgHzN8Kev m3Vck5j3SQIkQddI4fbh5TebcaUGQBnIOFC3p8FE571tDb26sN/rlJWab2c9WjXO d5BCRQ== Received: from mail-pj1-f70.google.com (mail-pj1-f70.google.com [209.85.216.70]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 47y3tc49rw-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Fri, 18 Jul 2025 17:14:47 +0000 (GMT) Received: by mail-pj1-f70.google.com with SMTP id 98e67ed59e1d1-31332dc2b59so2007091a91.0 for ; Fri, 18 Jul 2025 10:14:47 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752858886; x=1753463686; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=hvQRsE2lG7WyIIQnwV/DeD9T4vuk4piXmEgdbjYc460=; b=K7O+dccLUci2b5hYyR7Y/qEMxyIs/bksXr+JTdiV4UPsxyTaGA5v3Y3p2zELPZdHdG 9WsVPNEAX5QwiqImUrHfwZU6DMceIaO2vFBU+hE3Y9OLCwgpD8wH4oXwFuXN3Akauaus LzlZmTBYUOenRs/jeNSGwM1gRn+WuCDNkD9jSxysRXNxu/cJNpJvGI9L+R4DRQSwFo5i T4aA4wiXTLmMZslg1Hq0f6VC3ZYkZw73PUvUS3xT2Exm/UaZUOhsgwK4NYPqo5oBegi1 PyfCj2Acy8bo7RAJPvjydPGz3gH5O+81JRGkolVf4T7yJcs/nsh6YmW8qb9VrdJyDuvG wE9g== X-Forwarded-Encrypted: i=1; AJvYcCVV7GOQB8uD8aMVBbkyQnWltdtoSK7GD7N0I453GiRqDXYZky4aSRh3IHizZkCAkK/wFOA2xB5ODcg/1iyVSQ==@lists.infradead.org X-Gm-Message-State: AOJu0YyJmxuSsRZnHnzvERiPJ2lcH9lXABsgMO2vhJpbiDdxBnPDrhED qjCplHmsNhn8p1NJ14avrgnFVIi2ZRECFdFQ/uHNf845wwFEstyGe8i04AS+mLePWQBQ3bjkyBn YE7H6I1U5sn+9/iPp2BV1y8gAvscs/sjlMhAtufPvyoFElN0zo992QnrL/uVrrXEw2Edl8I1zm+ Q= X-Gm-Gg: ASbGnctGXEhNgGoEHuqJfdsSTQ9xN7OEKS7vPSOxR6tXv7wt1NqlaFBvVFeVh9SBqUz vYm/qpdIqyn9/Q8bAr2X/mDLZ1ztR0xkJhm3LzO6AU56PZwpdws9BN2X/fcBnQgVJoBvYvqvjgg LcEBNNZWzzxMKZ1v/Cz9jiSqWG98nvVUea3LiiMp+gIoP03RAzZAgXwI4WzczjSKxpEOHWWWp8k tSZT8canqHNWcZVqWpKTlDlIB13YXd9MtyEhW+H/NkQI77DXk4Q8oO3cNY+Tbbdz13rzEr53XRs toAcGGWsIpTahvNRLVKDFF/08OY+VIo/8PtlSM+KyPLIk+3UR59K1RcGh29gt6e9BCPqlAIpT3A bcQjH7sovPXQocw== X-Received: by 2002:a17:90b:48c8:b0:315:b07a:ac12 with SMTP id 98e67ed59e1d1-31c9e6f71b8mr18347571a91.14.1752858886374; Fri, 18 Jul 2025 10:14:46 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHAZ4uYoT0jpgwok+1LqJLQaSu3L2fEp1diUxE597ewVDpbjd87lEWbuWkSUsEweCpZR2VK2w== X-Received: by 2002:a17:90b:48c8:b0:315:b07a:ac12 with SMTP id 98e67ed59e1d1-31c9e6f71b8mr18347517a91.14.1752858885895; Fri, 18 Jul 2025 10:14:45 -0700 (PDT) Received: from [10.226.59.182] (i-global254.qualcomm.com. [199.106.103.254]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-31cc3e5b56fsm1593934a91.16.2025.07.18.10.14.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 18 Jul 2025 10:14:45 -0700 (PDT) Message-ID: <7753e1e8-5e2d-4d8b-8a46-a6fbc58a144d@oss.qualcomm.com> Date: Fri, 18 Jul 2025 11:14:42 -0600 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v8 02/10] accel/rocket: Add a new driver for Rockchip's NPU To: Tomeu Vizoso , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Heiko Stuebner , Oded Gabbay , Jonathan Corbet , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Sumit Semwal , =?UTF-8?Q?Christian_K=C3=B6nig?= , Sebastian Reichel , Nicolas Frattaroli , Kever Yang , Robin Murphy , Daniel Stone , Da Xue , Philipp Zabel Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-doc@vger.kernel.org, linux-media@vger.kernel.org, linaro-mm-sig@lists.linaro.org, Robert Foss References: <20250713-6-10-rocket-v8-0-64fa3115e910@tomeuvizoso.net> <20250713-6-10-rocket-v8-2-64fa3115e910@tomeuvizoso.net> Content-Language: en-US From: Jeff Hugo In-Reply-To: <20250713-6-10-rocket-v8-2-64fa3115e910@tomeuvizoso.net> X-Authority-Analysis: v=2.4 cv=Z5PsHGRA c=1 sm=1 tr=0 ts=687a8107 cx=c_pps a=0uOsjrqzRL749jD1oC5vDA==:117 a=JYp8KDb2vCoCEuGobkYCKw==:17 a=IkcTkHD0fZMA:10 a=Wb1JkmetP80A:10 a=VwQbUJbxAAAA:8 a=DISFzqtZAAAA:8 a=EUspDBNiAAAA:8 a=V6djkQ_TFPnTOxwyQKcA:9 a=QEXdDO2ut3YA:10 a=mQ_c8vxmzFEMiUWkPHU9:22 a=aug85vrO5LANNmmtkfAW:22 X-Proofpoint-ORIG-GUID: mPk4LyRmGnxsaqCIKr4e4lJJjnG4cQlv X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNzE4MDEzNiBTYWx0ZWRfX9mFGCYQ8H6Lk FyeIs5ejtKN3uq+fyIVF4pfiFfyYI6M/sjklA0NHWYbjqgcic8WlQpiP/jeVwbdGDDd+1TwDp+G nhyYz02y/9IvBfkGpUsgeW8HtoDaT+EXzuFyrYZc4XpHami30LGyLdR94nHo5KSMUJLGvxwBuCm 56qR5Tr+dGTqJOF59LmIkQmECKt7RTBbgzpOLCL+XnvF9Z9ot+i9rd8fQH7il0wdeBk56OQ2wU4 mnMQz/yTwpJtWIF+Og68IwonqmCf1k4A/rC/QqlmuyreKFBE/lcllJasKLh6OytumSpjyq9WpF9 i8VhBPR0GNXNLSaAIlWlcEQm5wm4lF4G1jsb1KYosg4Idh29wu/HLObq+dFFhWFKvuWn0cbjh1e RkziM17/S5XHUJEGD6PpRO0rktnNfvbsF+d8JXp14VdO7rgZA1fb5CIQ0lbHCHIqTFSavFkd X-Proofpoint-GUID: mPk4LyRmGnxsaqCIKr4e4lJJjnG4cQlv X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-07-18_04,2025-07-17_02,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 mlxlogscore=999 suspectscore=0 spamscore=0 clxscore=1015 mlxscore=0 malwarescore=0 phishscore=0 lowpriorityscore=0 adultscore=0 priorityscore=1501 bulkscore=0 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2505280000 definitions=main-2507180136 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250718_101448_082046_36B307AC X-CRM114-Status: GOOD ( 18.37 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org On 7/13/2025 2:38 AM, Tomeu Vizoso wrote: > This initial version supports the NPU as shipped in the RK3588 SoC and > described in the first part of its TRM, in Chapter 36. > > This NPU contains 3 independent cores that the driver can submit jobs > to. > > This commit adds just hardware initialization and power management. > > v2: > - Split cores and IOMMUs as independent devices (Sebastian Reichel) > - Add some documentation (Jeffrey Hugo) > - Be more explicit in the Kconfig documentation (Jeffrey Hugo) > - Remove resets, as these haven't been found useful so far (Zenghui Yu) > - Repack structs (Jeffrey Hugo) > - Use DEFINE_DRM_ACCEL_FOPS (Jeffrey Hugo) > - Use devm_drm_dev_alloc (Jeffrey Hugo) > - Use probe log helper (Jeffrey Hugo) > - Introduce UABI header in a later patch (Jeffrey Hugo) > > v3: > - Adapt to a split of the register block in the DT bindings (Nicolas > Frattaroli) > - Move registers header to its own commit (Thomas Zimmermann) > - Misc. cleanups (Thomas Zimmermann and Jeff Hugo) > - Make use of GPL-2.0-only for the copyright notice (Jeff Hugo) > - PM improvements (Nicolas Frattaroli) > > v4: > - Use bulk clk API (Krzysztof Kozlowski) > > v6: > - Remove mention to NVDLA, as the hardware is only incidentally related > (Kever Yang) > - Use calloc instead of GFP_ZERO (Jeff Hugo) > - Explicitly include linux/container_of.h (Jeff Hugo) > - pclk and npu clocks are now needed by all cores (Rob Herring) > > v7: > - Assign its own IOMMU domain to each client, for isolation (Daniel > Stone and Robin Murphy) > > v8: > - Kconfig: fix depends to be more explicit about Rockchip, and remove > superfluous selects (Robin Murphy) > - Use reset lines to reset the cores (Robin Murphy) > - Reference count the module > - Set dma_set_max_seg_size > - Correctly acquire a reference to the IOMMU (Robin Murphy) > - Remove notion of top core (Robin Murphy) > > Reviewed-by: Robert Foss > Tested-by: Heiko Stuebner > Signed-off-by: Tomeu Vizoso Reviewed-by: Jeff Hugo _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip